From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96515C433DB for ; Wed, 6 Jan 2021 10:49:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E0FD2310F for ; Wed, 6 Jan 2021 10:49:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726430AbhAFKt2 (ORCPT ); Wed, 6 Jan 2021 05:49:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbhAFKt0 (ORCPT ); Wed, 6 Jan 2021 05:49:26 -0500 Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [IPv6:2607:f8b0:4864:20::e2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A1DFC06134C for ; Wed, 6 Jan 2021 02:48:57 -0800 (PST) Received: by mail-vs1-xe2a.google.com with SMTP id e15so1575834vsa.0 for ; Wed, 06 Jan 2021 02:48:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=65bthvYlj9KKIS5KK6JhxNYJMD8s4MDQLZpfgKqd4vM=; b=X7GGMa423pBbYfE4+HR39/XGdoDcfr3nbm8+IarZvID4Pf5pRICqedHoV1eEljrqvh 1wjAGleOvGRLUtM2TA6SjwweF91aOSKSAHJQ+VWXnmcAOjDSGBetJbOtEXmvkzoISqnO gun7Yry+f4793b7Iq7Mmya8p7nFGc8lI/3GsE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=65bthvYlj9KKIS5KK6JhxNYJMD8s4MDQLZpfgKqd4vM=; b=bRQFJfGwXDY46SUDZ117fVA1UXr9Zg1gxs+Mz01DCQYtHf+xBEDAGWOxrhPxLYZtYe 3Xm/vluCFA6Zp9BoPV/4YgX7u89so+KYLBT/QJXT7RGryrHANKmsRqp7ehyT7g4IeLjj WGC1SRmjqAvaI8JW+otHOTVIwexQWyoGqsoWuNmeFOpZRK6CAT//rMwWB3cI6Rmd43AZ SCiKtCtzN62kfyvhw6KSa7fcW8Iwt1a9gV2GXaJPZ4FOJ04Kcs5UDl6ZECDG2/KmOaXr g8cgny3R5zXkodaKlOag347pwsyvIWz+hLChereZlNPnzDPRjjyB0hd6ZaPLVJVcl7Jg Bepw== X-Gm-Message-State: AOAM532W6fNIv7fH6YTCd3rXwK6YqznfQ7dQxI12XPLHB6zl5sV1KhMS F7qHjDuR6qxbVgD/FxKznhXJnl5R01nAs/xgSi7HTg== X-Google-Smtp-Source: ABdhPJz9ON8BwWq+VaecVefOOUeLpjkYUuNp9NU/OAWS/f/jzOReQa42tBRohJ5XkaU0WXUWBPttXpWvspWnaIv70xQ= X-Received: by 2002:a67:5c03:: with SMTP id q3mr2560878vsb.47.1609930136255; Wed, 06 Jan 2021 02:48:56 -0800 (PST) MIME-Version: 1.0 References: <20210106084626.2181286-1-hsinyi@chromium.org> In-Reply-To: From: Nicolas Boichat Date: Wed, 6 Jan 2021 18:48:45 +0800 Message-ID: Subject: Re: [PATCH 1/2] arm64: dts: mt8183: config dsi node To: Hsin-Yi Wang Cc: linux-arm Mailing List , Matthias Brugger , Rob Herring , Enric Balletbo i Serra , Devicetree List , "moderated list:ARM/Mediatek SoC support" , lkml Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 6, 2021 at 6:47 PM Nicolas Boichat wrote: > > On Wed, Jan 6, 2021 at 4:46 PM Hsin-Yi Wang wrote: > > > > Config dsi node for mt8183 kukui. Set panel and ports. > > > > Signed-off-by: Hsin-Yi Wang > > --- > > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 38 +++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > > index bf2ad1294dd30..4cfb3560e5d11 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > > @@ -249,6 +249,36 @@ &cpu7 { > > proc-supply = <&mt6358_vproc11_reg>; > > }; > > > > +&dsi0 { > > + status = "okay"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + panel: panel@0 { > > + compatible = "boe,tv101wum-nl6"; > > We're going to have many panels in the kukui family, so I think I'd > prefer it if you moved the compatible string to krane-sku0 dts: it > makes it easier to figure out what's different with sku0. I meant sku176 (since you are adding sku0 with a different panel compatible later). > > Then maybe leave all the other properties in this file, as it seems > like all MIPI panels use the exact same pin/supplies? > > (And add a comment here saying that the compatible needs to be set in > board dts?) > > > + reg = <0>; > > + enable-gpios = <&pio 45 0>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&panel_pins_default>; > > + avdd-supply = <&ppvarn_lcd>; > > + avee-supply = <&ppvarp_lcd>; > > + pp1800-supply = <&pp1800_lcd>; > > + status = "okay"; > > + port { > > + panel_in: endpoint { > > + remote-endpoint = <&dsi_out>; > > + }; > > + }; > > + }; > > + > > + ports { > > + port { > > + dsi_out: endpoint { > > + remote-endpoint = <&panel_in>; > > + }; > > + }; > > + }; > > +}; > > + > > &i2c0 { > > pinctrl-names = "default"; > > pinctrl-0 = <&i2c0_pins>; > > @@ -547,6 +577,14 @@ pins_clk { > > }; > > }; > > > > + panel_pins_default: panel_pins_default { > > + panel_reset { > > + pinmux = ; > > + output-low; > > + bias-pull-up; > > + }; > > + }; > > + > > pwm0_pin_default: pwm0_pin_default { > > pins1 { > > pinmux = ; > > -- > > 2.29.2.729.g45daf8777d-goog > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD00C433DB for ; Wed, 6 Jan 2021 10:49:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB5A62310E for ; Wed, 6 Jan 2021 10:49:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB5A62310E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zivuDs/ujEy9Y8+AELPZ3J6xKy+H6Oszqbw1rLqKU40=; b=HHn+SNfBiKWYyqWcd+1obx8Tb sNImw/nhgAYc4JdhJlrijlgD6ROmxDOx4B50BKylTe69jf3jviS4gvM2IVWFaxM5vVAV8pUGk+Gbm tXZrJPiRbT9ZukTTdrrxvR0MPMEn/2mecBbFDNG1gzFm5aAsq1zZ/3y8zj6HqGxNX1X4/4OKuhR96 81qlfbFQUL0SfdFM1SsklD09UBuQ+pBF4CPGMvQ1XD3Eh0nWCOwS5JgVIacV3V5py2HKETKBbPfdx dFHbgwq8f4fCPSm7ivJMrn1AoBABLsKfYczfgTpEqpfQPjSau97dsYhDMLki5R2TWxrqXNYTDfNw6 9r6ez/ZbQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx6NA-0004M9-Mb; Wed, 06 Jan 2021 10:49:00 +0000 Received: from mail-vs1-xe36.google.com ([2607:f8b0:4864:20::e36]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx6N8-0004LI-17 for linux-mediatek@lists.infradead.org; Wed, 06 Jan 2021 10:48:59 +0000 Received: by mail-vs1-xe36.google.com with SMTP id h6so1551898vsr.6 for ; Wed, 06 Jan 2021 02:48:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=65bthvYlj9KKIS5KK6JhxNYJMD8s4MDQLZpfgKqd4vM=; b=X7GGMa423pBbYfE4+HR39/XGdoDcfr3nbm8+IarZvID4Pf5pRICqedHoV1eEljrqvh 1wjAGleOvGRLUtM2TA6SjwweF91aOSKSAHJQ+VWXnmcAOjDSGBetJbOtEXmvkzoISqnO gun7Yry+f4793b7Iq7Mmya8p7nFGc8lI/3GsE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=65bthvYlj9KKIS5KK6JhxNYJMD8s4MDQLZpfgKqd4vM=; b=APnj480Xb3HzNBQeGasb8kXOh/Shg6vruyYKP01yyezggJAJbfVe2MNx/6RXgS8rfu 78BZV1DS/BmZ3jrSCUlBW4anw5eR3nWfi7BBipdIMLe/L8aDksvmqZmaKjS2g9BxGHW/ qUlGM+3/WzDvbtyvyMDyihYGXA/xqsVulQz7RZYuQ2EFiP7oHp33h1uSl6x6aMdg1xvK isPexMmdGYnvAjqruq+j0ecrylQ2xldno7jPmKv19ukqN+C0mBDdJ6kysD4HjmHJ3XWM snSfNDAmABO7hs6WnCUoo22Fp0U7jI01Ei9wZObUJD6U1HakMKR4mNPNrIk3Zqqa4pwz rExw== X-Gm-Message-State: AOAM533PokWKpiuD344JLO+QqJ0hngcrxHCZhLzZlpGGCP6E4qczdOC7 cJIgOnsBam4bi+rtaSQtnx3m5BYjfW97KpWJVPGG8Q== X-Google-Smtp-Source: ABdhPJz9ON8BwWq+VaecVefOOUeLpjkYUuNp9NU/OAWS/f/jzOReQa42tBRohJ5XkaU0WXUWBPttXpWvspWnaIv70xQ= X-Received: by 2002:a67:5c03:: with SMTP id q3mr2560878vsb.47.1609930136255; Wed, 06 Jan 2021 02:48:56 -0800 (PST) MIME-Version: 1.0 References: <20210106084626.2181286-1-hsinyi@chromium.org> In-Reply-To: From: Nicolas Boichat Date: Wed, 6 Jan 2021 18:48:45 +0800 Message-ID: Subject: Re: [PATCH 1/2] arm64: dts: mt8183: config dsi node To: Hsin-Yi Wang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_054858_145281_7D2941EC X-CRM114-Status: GOOD ( 20.86 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Devicetree List , lkml , Enric Balletbo i Serra , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Jan 6, 2021 at 6:47 PM Nicolas Boichat wrote: > > On Wed, Jan 6, 2021 at 4:46 PM Hsin-Yi Wang wrote: > > > > Config dsi node for mt8183 kukui. Set panel and ports. > > > > Signed-off-by: Hsin-Yi Wang > > --- > > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 38 +++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > > index bf2ad1294dd30..4cfb3560e5d11 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > > @@ -249,6 +249,36 @@ &cpu7 { > > proc-supply = <&mt6358_vproc11_reg>; > > }; > > > > +&dsi0 { > > + status = "okay"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + panel: panel@0 { > > + compatible = "boe,tv101wum-nl6"; > > We're going to have many panels in the kukui family, so I think I'd > prefer it if you moved the compatible string to krane-sku0 dts: it > makes it easier to figure out what's different with sku0. I meant sku176 (since you are adding sku0 with a different panel compatible later). > > Then maybe leave all the other properties in this file, as it seems > like all MIPI panels use the exact same pin/supplies? > > (And add a comment here saying that the compatible needs to be set in > board dts?) > > > + reg = <0>; > > + enable-gpios = <&pio 45 0>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&panel_pins_default>; > > + avdd-supply = <&ppvarn_lcd>; > > + avee-supply = <&ppvarp_lcd>; > > + pp1800-supply = <&pp1800_lcd>; > > + status = "okay"; > > + port { > > + panel_in: endpoint { > > + remote-endpoint = <&dsi_out>; > > + }; > > + }; > > + }; > > + > > + ports { > > + port { > > + dsi_out: endpoint { > > + remote-endpoint = <&panel_in>; > > + }; > > + }; > > + }; > > +}; > > + > > &i2c0 { > > pinctrl-names = "default"; > > pinctrl-0 = <&i2c0_pins>; > > @@ -547,6 +577,14 @@ pins_clk { > > }; > > }; > > > > + panel_pins_default: panel_pins_default { > > + panel_reset { > > + pinmux = ; > > + output-low; > > + bias-pull-up; > > + }; > > + }; > > + > > pwm0_pin_default: pwm0_pin_default { > > pins1 { > > pinmux = ; > > -- > > 2.29.2.729.g45daf8777d-goog > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A9FC433E0 for ; Wed, 6 Jan 2021 10:51:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F113B23105 for ; Wed, 6 Jan 2021 10:51:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F113B23105 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dpViMlTbCPs3YoBCE6bophJgGkBXeBgsq7EJiALehqI=; b=sldE/Oav+bHTnWmoW/6clsH5r hgqIEWSxbcmNAV4s4kLDsHySmSDbd9l+Mn5/SP+mBlxW9V2SPBInH/ijXgqcDapn0/Za3f9UtCUPv B85i3Tw15Iw1U7mmTB2RYg2bu4X0oL+3+MttCF5iz0ulhEkPmvPnEtOJwc+FfHffycXb5jjxENfYR HaxJpScRLp+PDTiEeNHAbPuIZkSus7/wlkCNLrIMFcbIiAGTKn+1EbDEgkSMVsYiuMVCixx3Uw6kA ePVxdiK+so2DD6cPRp9zLbPu4tJPjos0mu3ZOK+OkhO4mn77GZc6KapzTvhy0+r1v1W67z+r+Mlbl GJufmwPFQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx6NB-0004MN-So; Wed, 06 Jan 2021 10:49:01 +0000 Received: from mail-vs1-xe30.google.com ([2607:f8b0:4864:20::e30]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx6N8-0004LJ-1s for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 10:48:59 +0000 Received: by mail-vs1-xe30.google.com with SMTP id x26so1576720vsq.1 for ; Wed, 06 Jan 2021 02:48:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=65bthvYlj9KKIS5KK6JhxNYJMD8s4MDQLZpfgKqd4vM=; b=X7GGMa423pBbYfE4+HR39/XGdoDcfr3nbm8+IarZvID4Pf5pRICqedHoV1eEljrqvh 1wjAGleOvGRLUtM2TA6SjwweF91aOSKSAHJQ+VWXnmcAOjDSGBetJbOtEXmvkzoISqnO gun7Yry+f4793b7Iq7Mmya8p7nFGc8lI/3GsE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=65bthvYlj9KKIS5KK6JhxNYJMD8s4MDQLZpfgKqd4vM=; b=b2KAB/sTh4ZIRFIg3SlMBdQxr47LbG8fWczkcvnSXD+oP40QvkigFVV44qsrR/bbQT koHJFHf6lG9OyouvqfHjIcuerUW5j0vf+Y+QmM18CKSlxdGkFmM4AR68bN8HQHMMNywV Qz+QXikK/xqityXGSPtuzjxly3Ok8FAnoYiOkHlegmbzup/Wevg0sAEA1XfLcuXxzSSq eDaqPCgdl3HgznUfZShwp30LqJO7wi+KTreYwNdxrGMSb7rgy4VS++MqWvh0QNlSLlqw Omq5XeoO1ObIllA7FPmZImsDLTyJ6wJT32Pre26cGMwi9n5Gli/KUAXTZ2SO0dvUaGNC jm4g== X-Gm-Message-State: AOAM5334lVVkxSzEXouKi+xQVCGc1CH0IjKI4ovdm7OCmHdOwcq1uEUk 51nhj7lqnobLEhzOPhAEA/Fi6UL1fuCpKLM1v9vjUA== X-Google-Smtp-Source: ABdhPJz9ON8BwWq+VaecVefOOUeLpjkYUuNp9NU/OAWS/f/jzOReQa42tBRohJ5XkaU0WXUWBPttXpWvspWnaIv70xQ= X-Received: by 2002:a67:5c03:: with SMTP id q3mr2560878vsb.47.1609930136255; Wed, 06 Jan 2021 02:48:56 -0800 (PST) MIME-Version: 1.0 References: <20210106084626.2181286-1-hsinyi@chromium.org> In-Reply-To: From: Nicolas Boichat Date: Wed, 6 Jan 2021 18:48:45 +0800 Message-ID: Subject: Re: [PATCH 1/2] arm64: dts: mt8183: config dsi node To: Hsin-Yi Wang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_054858_147143_9B6DFFD6 X-CRM114-Status: GOOD ( 22.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Devicetree List , lkml , Enric Balletbo i Serra , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 6, 2021 at 6:47 PM Nicolas Boichat wrote: > > On Wed, Jan 6, 2021 at 4:46 PM Hsin-Yi Wang wrote: > > > > Config dsi node for mt8183 kukui. Set panel and ports. > > > > Signed-off-by: Hsin-Yi Wang > > --- > > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 38 +++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > > index bf2ad1294dd30..4cfb3560e5d11 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > > @@ -249,6 +249,36 @@ &cpu7 { > > proc-supply = <&mt6358_vproc11_reg>; > > }; > > > > +&dsi0 { > > + status = "okay"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + panel: panel@0 { > > + compatible = "boe,tv101wum-nl6"; > > We're going to have many panels in the kukui family, so I think I'd > prefer it if you moved the compatible string to krane-sku0 dts: it > makes it easier to figure out what's different with sku0. I meant sku176 (since you are adding sku0 with a different panel compatible later). > > Then maybe leave all the other properties in this file, as it seems > like all MIPI panels use the exact same pin/supplies? > > (And add a comment here saying that the compatible needs to be set in > board dts?) > > > + reg = <0>; > > + enable-gpios = <&pio 45 0>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&panel_pins_default>; > > + avdd-supply = <&ppvarn_lcd>; > > + avee-supply = <&ppvarp_lcd>; > > + pp1800-supply = <&pp1800_lcd>; > > + status = "okay"; > > + port { > > + panel_in: endpoint { > > + remote-endpoint = <&dsi_out>; > > + }; > > + }; > > + }; > > + > > + ports { > > + port { > > + dsi_out: endpoint { > > + remote-endpoint = <&panel_in>; > > + }; > > + }; > > + }; > > +}; > > + > > &i2c0 { > > pinctrl-names = "default"; > > pinctrl-0 = <&i2c0_pins>; > > @@ -547,6 +577,14 @@ pins_clk { > > }; > > }; > > > > + panel_pins_default: panel_pins_default { > > + panel_reset { > > + pinmux = ; > > + output-low; > > + bias-pull-up; > > + }; > > + }; > > + > > pwm0_pin_default: pwm0_pin_default { > > pins1 { > > pinmux = ; > > -- > > 2.29.2.729.g45daf8777d-goog > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel