From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81231C10F27 for ; Mon, 9 Mar 2020 01:53:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 522CC20675 for ; Mon, 9 Mar 2020 01:53:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aWYnmvWG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726857AbgCIBxt (ORCPT ); Sun, 8 Mar 2020 21:53:49 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:40584 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726610AbgCIBxs (ORCPT ); Sun, 8 Mar 2020 21:53:48 -0400 Received: by mail-vs1-f67.google.com with SMTP id c18so5047168vsq.7 for ; Sun, 08 Mar 2020 18:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=QImbxmTkHKil1pvHr+BDxiJL2XLBZLzoyGW6wsTn3oQ=; b=aWYnmvWGdbntSuhyucIIAMxrZHkM4G5/Q9vbOmCQsekZAYHvr4Eog74dsXDkMYl2xD KvL1zeXKamlcuQTyyvQgkSKnT1gNRPF5uTVUa4a4fHcg/kx4VnHTixsNdroZ764sU1Uy +tKikHrHiZuRBXkYz+/Z8bBjwf8qxvraCz7gQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=QImbxmTkHKil1pvHr+BDxiJL2XLBZLzoyGW6wsTn3oQ=; b=TG11dkfoz2NT6ZPm3UFzVr8NcVo+J9XY4qE1F+VoVaFQumSzRTAtAt9+pingMtV0KN ZRJ9sQLjVmLj7Lbp3TUGS9AWl/5mo2pUWIYGIv4z7Bj2jykUOqS1MQKIUinEYMwqr7+O u/0YmB0gwyesAXQbHL72gaC/z/RC7gZxaJlClbjJbToyP+TSEzq8xmkINFRaXtTAN7YD wk703ytlv5H/eQgM8nPYjLjFdGAO02V4n4PnBsfq2wa1jqu5Tn+/5SfSYxQuRp9EJtQi ap61ZlHgqjTaLuwZzV44e4ZJo7YPT1dTbtqpTr8jnb27ooDPc8kRMPscmJKndJRmEnnM DBmw== X-Gm-Message-State: ANhLgQ3G7aKi/8dgB6zJUSa4+wTtKPI4HZBxjYg93m/tm8G+Si3R2s9m VBQnxk7iiODACyA/k52WhQTLhnxhGYGBAsTHukcteA== X-Google-Smtp-Source: ADFU+vvYsFjqtY5zn3zCc01nvvuQjne4/YR7CEb/r3521XiWmW+BqevLE59/BQHtNHTJV1ro52aTXPZEfqp1TtQdFWA= X-Received: by 2002:a05:6102:9c7:: with SMTP id g7mr8614280vsi.186.1583718826912; Sun, 08 Mar 2020 18:53:46 -0700 (PDT) MIME-Version: 1.0 References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-8-drinkcat@chromium.org> In-Reply-To: From: Nicolas Boichat Date: Mon, 9 Mar 2020 09:53:35 +0800 Message-ID: Subject: Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators To: =?UTF-8?B?TmljayBGYW4gKOiMg+WTsue2rSk=?= Cc: Rob Herring , =?UTF-8?B?V2VpeWkgTHUgKOWRguWogeWEgCk=?= , David Airlie , Daniel Vetter , Mark Rutland , Matthias Brugger , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , Liam Girdwood , Mark Brown , dri-devel , Devicetree List , lkml , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang , Ulf Hansson , Viresh Kumar , Stephen Boyd , =?UTF-8?B?SkIgVHNhaSAo6JSh5b+X5b2sKQ==?= , =?UTF-8?B?U2ogSHVhbmcgKOm7g+S/oeeSiyk=?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looping back on this, after digging a bit deeper... On Fri, Feb 14, 2020 at 9:38 AM Nick Fan (=E8=8C=83=E5=93=B2=E7=B6=AD) wrote: > [snip] > > > Another thing that I'm not implementing is the dance that Mediatek > > > does in their kbase driver when changing the clock (described in > > > patch > > > 2/7): > > > "" > > > The binding we use with out-of-tree Mali drivers includes more > > > clocks, this is used for devfreq: the out-of-tree driver switches > > > clk_mux to clk_sub_parent (26Mhz), adjusts clk_main_parent, then > > > switches clk_mux back to clk_main_parent: > > > (see > > > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ch > > > romeos-4.19/drivers/gpu/arm/midgard/platform/mediatek/mali_kbase_run > > > time_pm.c#423) > > > clocks =3D > > > <&topckgen CLK_TOP_MFGPLL_CK>, > > > <&topckgen CLK_TOP_MUX_MFG>, > > > <&clk26m>, > > > <&mfgcfg CLK_MFG_BG3D>; > > > clock-names =3D > > > "clk_main_parent", > > > "clk_mux", > > > "clk_sub_parent", > > > "subsys_mfg_cg"; > > > "" > > > Is there a clean/simple way to implement this in the clock > > > framework/device tree? Or should we implement something in the > > > panfrost driver? > > > > Putting parent clocks into 'clocks' for a device is a pretty common > > abuse. The 'assigned-clocks' binding is what's used for parent clock > > setup. Not sure that's going to help here though. Is this dance > > because the parent clock frequency can't be changed cleanly? > > Nick/Weiyi, any idea why we do that dance in the first place? (maybe the = PLL clock is unstable while it's being changed?) > > Clock source may become unstable during clock frequency changes, so it is= always safer to switch to a more reliable clock source. > Otherwise, it may cause some problem in some corner case. > I would suggest to keep it. The Mediatek CPUfreq driver actually does a very similar dance: https://github.com/torvalds/linux/blob/master/drivers/cpufreq/mediatek-cpuf= req.c#L249 What they have in the device tree is the main clock, and the "intermediate" clock that is required during switching: clocks =3D <&mcucfg CLK_MCU_MP0_SEL>, <&topckgen CLK_TOP_ARMPLL_DIV_PLL1>; clock-names =3D "cpu", "intermediate"; The topology looks like this: clk26m 15 15 1 26000000 0 0 50000 armpll_ll 1 1 0 1417000000 0 0 50000 mcu_mp0_sel 0 0 0 1417000000 0 0 50000 And device tree provides mcu_mp0_sel as "cpu", and the armpll_div_pll1 as "intermediate". The driver looks up armpll_ll by calling get_parent, then: - set_parent(mcu_mp0_sel, armpll_div_pll1) - set_rate(armpll_ll, new_rate) - set_parent(mcu_mp0_sel, armpll_ll) On MT8183's GPU, the topology is a little bit more complicated (but I think there should be a way to merge mfg_bg3d an mfg_sel in the clock core) clk26m 15 15 1 26000000 0 0 50000 mfgpll 1 1 0 419999817 0 0 50000 mfgpll_ck 2 2 0 419999817 0 0 50000 mfg_sel 3 3 0 419999817 0 0 50000 mfg_bg3d 1 1 0 419999817 0 0 50000 We're going to need a special panfrost devfreq driver for mt8183 anyway (to handle the 2 regulators), so it would be easy to take a similar approach: - Add "intermediate" clock in the device tree (clk26m) - Find mfg_sel/mfgpll_ck using 1/2 clk_get_parent calls. - Switch mfg_sel to clk26m, set mfgpll_ck rate, switch mfg_sel back to mfgpll_ck. (BTW, I tried to look, and couldn't find examples or reparenting during clock changes in drivers/clk, are there existing drivers doing similar things? Or this would be new?). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50F4AC10DCE for ; Mon, 9 Mar 2020 01:54:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24E0B20675 for ; Mon, 9 Mar 2020 01:54:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fvQsYd30"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aWYnmvWG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24E0B20675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b3Sf2INTVlwA2sFa/+6hZwF9XBoTlLoS9A/R+ztzv2Y=; b=fvQsYd30PU4/GE 5/b7LhLyba5/J3VY7qNL5R504slZfXkEVm5ggGMJS/vP2nh1Gq1vi5IunArCjNTAcpwpIOf8qgUOD Mq1zcSSO6G7Vu752GN0XLLBo6X2yrNZTGdJj0DFVjo+KbjygWLcG9G/8Pzuw3ZKazlqxeReLVyxr7 ZL14Bu+Xgo8qioDSkeACIaEhXF9gr+XATCZFZdy4r4lkLXlXgI1Tsqxa+Yg6G/ircQ5ynXF1lIlRZ 2Y9IYYcuCtezGKArnHNiM0gV8tTFJuPVq6EZ7LoeAibaCF95oViAxRn4Vja3A6hCQMzi/fRu1vLJB +d6OMgMWzkkiFbkkki4g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jB7c7-0002XI-JX; Mon, 09 Mar 2020 01:53:51 +0000 Received: from mail-vs1-xe43.google.com ([2607:f8b0:4864:20::e43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jB7c4-0002WX-GZ for linux-mediatek@lists.infradead.org; Mon, 09 Mar 2020 01:53:50 +0000 Received: by mail-vs1-xe43.google.com with SMTP id z125so1145668vsb.13 for ; Sun, 08 Mar 2020 18:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=QImbxmTkHKil1pvHr+BDxiJL2XLBZLzoyGW6wsTn3oQ=; b=aWYnmvWGdbntSuhyucIIAMxrZHkM4G5/Q9vbOmCQsekZAYHvr4Eog74dsXDkMYl2xD KvL1zeXKamlcuQTyyvQgkSKnT1gNRPF5uTVUa4a4fHcg/kx4VnHTixsNdroZ764sU1Uy +tKikHrHiZuRBXkYz+/Z8bBjwf8qxvraCz7gQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=QImbxmTkHKil1pvHr+BDxiJL2XLBZLzoyGW6wsTn3oQ=; b=SA8vANQfIECPsXUooF091uQCINLwShp4Q1bvtZdkDJLcdwA2RdJNCsj9VQu/psRFRk uomZ37niIZhhGjDoFfxr9CJyNb2MRk6iHu3ub8bF9TmdbW0zzPhXMIFgXKuETQv/o2Sp X7eRD5z5NfQOgWh+9nsscVyQlOUEwTgkhaieXNYKjlCZ2RF79YyHDGbaj5l5xRb2H8vB qxwpuVJ0bCQUga4uw/Wf2aC6RWP7C7diTcamKGu3cmaEKgll9xLJgPgAP4d0oM+zaYff 27mIprLtJGgE7AZDQkaDXB4cQnI6c2EAIfZcXd+oWHSravZKBH6PdFc1+lDvttUUsZo6 3Jpg== X-Gm-Message-State: ANhLgQ0QPqRaMowyKU271B1Nz6E/swdQIcLsZfXapwSttEtgrG+5Exaq 1h/sdblBepTkSBGGYDzwxg6ShOpHlzKAhtvBBQrNPQ== X-Google-Smtp-Source: ADFU+vvYsFjqtY5zn3zCc01nvvuQjne4/YR7CEb/r3521XiWmW+BqevLE59/BQHtNHTJV1ro52aTXPZEfqp1TtQdFWA= X-Received: by 2002:a05:6102:9c7:: with SMTP id g7mr8614280vsi.186.1583718826912; Sun, 08 Mar 2020 18:53:46 -0700 (PDT) MIME-Version: 1.0 References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-8-drinkcat@chromium.org> In-Reply-To: From: Nicolas Boichat Date: Mon, 9 Mar 2020 09:53:35 +0800 Message-ID: Subject: Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators To: =?UTF-8?B?TmljayBGYW4gKOiMg+WTsue2rSk=?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200308_185348_578891_5276FF1E X-CRM114-Status: GOOD ( 23.19 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ulf Hansson , David Airlie , Viresh Kumar , dri-devel , Liam Girdwood , =?UTF-8?B?V2VpeWkgTHUgKOWRguWogeWEgCk=?= , Steven Price , Alyssa Rosenzweig , Devicetree List , =?UTF-8?B?U2ogSHVhbmcgKOm7g+S/oeeSiyk=?= , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang , Matthias Brugger , linux-arm Mailing List , Tomeu Vizoso , Stephen Boyd , lkml , =?UTF-8?B?SkIgVHNhaSAo6JSh5b+X5b2sKQ==?= , Rob Herring , Daniel Vetter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org TG9vcGluZyBiYWNrIG9uIHRoaXMsIGFmdGVyIGRpZ2dpbmcgYSBiaXQgZGVlcGVyLi4uCgpPbiBG cmksIEZlYiAxNCwgMjAyMCBhdCA5OjM4IEFNIE5pY2sgRmFuICjojIPlk7Lntq0pIDxOaWNrLkZh bkBtZWRpYXRlay5jb20+IHdyb3RlOgo+IFtzbmlwXQo+ID4gPiBBbm90aGVyIHRoaW5nIHRoYXQg SSdtIG5vdCBpbXBsZW1lbnRpbmcgaXMgdGhlIGRhbmNlIHRoYXQgTWVkaWF0ZWsKPiA+ID4gZG9l cyBpbiB0aGVpciBrYmFzZSBkcml2ZXIgd2hlbiBjaGFuZ2luZyB0aGUgY2xvY2sgKGRlc2NyaWJl ZCBpbgo+ID4gPiBwYXRjaAo+ID4gPiAyLzcpOgo+ID4gPiAiIgo+ID4gPiBUaGUgYmluZGluZyB3 ZSB1c2Ugd2l0aCBvdXQtb2YtdHJlZSBNYWxpIGRyaXZlcnMgaW5jbHVkZXMgbW9yZQo+ID4gPiBj bG9ja3MsIHRoaXMgaXMgdXNlZCBmb3IgZGV2ZnJlcTogdGhlIG91dC1vZi10cmVlIGRyaXZlciBz d2l0Y2hlcwo+ID4gPiBjbGtfbXV4IHRvIGNsa19zdWJfcGFyZW50ICgyNk1oeiksIGFkanVzdHMg Y2xrX21haW5fcGFyZW50LCB0aGVuCj4gPiA+IHN3aXRjaGVzIGNsa19tdXggYmFjayB0byBjbGtf bWFpbl9wYXJlbnQ6Cj4gPiA+IChzZWUKPiA+ID4gaHR0cHM6Ly9jaHJvbWl1bS5nb29nbGVzb3Vy Y2UuY29tL2Nocm9taXVtb3MvdGhpcmRfcGFydHkva2VybmVsLysvY2gKPiA+ID4gcm9tZW9zLTQu MTkvZHJpdmVycy9ncHUvYXJtL21pZGdhcmQvcGxhdGZvcm0vbWVkaWF0ZWsvbWFsaV9rYmFzZV9y dW4KPiA+ID4gdGltZV9wbS5jIzQyMykKPiA+ID4gY2xvY2tzID0KPiA+ID4gICAgICAgICA8JnRv cGNrZ2VuIENMS19UT1BfTUZHUExMX0NLPiwKPiA+ID4gICAgICAgICA8JnRvcGNrZ2VuIENMS19U T1BfTVVYX01GRz4sCj4gPiA+ICAgICAgICAgPCZjbGsyNm0+LAo+ID4gPiAgICAgICAgIDwmbWZn Y2ZnIENMS19NRkdfQkczRD47Cj4gPiA+IGNsb2NrLW5hbWVzID0KPiA+ID4gICAgICAgICAiY2xr X21haW5fcGFyZW50IiwKPiA+ID4gICAgICAgICAiY2xrX211eCIsCj4gPiA+ICAgICAgICAgImNs a19zdWJfcGFyZW50IiwKPiA+ID4gICAgICAgICAic3Vic3lzX21mZ19jZyI7Cj4gPiA+ICIiCj4g PiA+IElzIHRoZXJlIGEgY2xlYW4vc2ltcGxlIHdheSB0byBpbXBsZW1lbnQgdGhpcyBpbiB0aGUg Y2xvY2sKPiA+ID4gZnJhbWV3b3JrL2RldmljZSB0cmVlPyBPciBzaG91bGQgd2UgaW1wbGVtZW50 IHNvbWV0aGluZyBpbiB0aGUKPiA+ID4gcGFuZnJvc3QgZHJpdmVyPwo+ID4KPiA+IFB1dHRpbmcg cGFyZW50IGNsb2NrcyBpbnRvICdjbG9ja3MnIGZvciBhIGRldmljZSBpcyBhIHByZXR0eSBjb21t b24KPiA+IGFidXNlLiBUaGUgJ2Fzc2lnbmVkLWNsb2NrcycgYmluZGluZyBpcyB3aGF0J3MgdXNl ZCBmb3IgcGFyZW50IGNsb2NrCj4gPiBzZXR1cC4gTm90IHN1cmUgdGhhdCdzIGdvaW5nIHRvIGhl bHAgaGVyZSB0aG91Z2guIElzIHRoaXMgZGFuY2UKPiA+IGJlY2F1c2UgdGhlIHBhcmVudCBjbG9j ayBmcmVxdWVuY3kgY2FuJ3QgYmUgY2hhbmdlZCBjbGVhbmx5Pwo+Cj4gTmljay9XZWl5aSwgYW55 IGlkZWEgd2h5IHdlIGRvIHRoYXQgZGFuY2UgaW4gdGhlIGZpcnN0IHBsYWNlPyAobWF5YmUgdGhl IFBMTCBjbG9jayBpcyB1bnN0YWJsZSB3aGlsZSBpdCdzIGJlaW5nIGNoYW5nZWQ/KQo+Cj4gQ2xv Y2sgc291cmNlIG1heSBiZWNvbWUgdW5zdGFibGUgZHVyaW5nIGNsb2NrIGZyZXF1ZW5jeSBjaGFu Z2VzLCBzbyBpdCBpcyBhbHdheXMgc2FmZXIgdG8gc3dpdGNoIHRvIGEgbW9yZSByZWxpYWJsZSBj bG9jayBzb3VyY2UuCj4gT3RoZXJ3aXNlLCBpdCBtYXkgY2F1c2Ugc29tZSBwcm9ibGVtIGluIHNv bWUgY29ybmVyIGNhc2UuCj4gSSB3b3VsZCBzdWdnZXN0IHRvIGtlZXAgaXQuCgpUaGUgTWVkaWF0 ZWsgQ1BVZnJlcSBkcml2ZXIgYWN0dWFsbHkgZG9lcyBhIHZlcnkgc2ltaWxhciBkYW5jZToKaHR0 cHM6Ly9naXRodWIuY29tL3RvcnZhbGRzL2xpbnV4L2Jsb2IvbWFzdGVyL2RyaXZlcnMvY3B1ZnJl cS9tZWRpYXRlay1jcHVmcmVxLmMjTDI0OQoKV2hhdCB0aGV5IGhhdmUgaW4gdGhlIGRldmljZSB0 cmVlIGlzIHRoZSBtYWluIGNsb2NrLCBhbmQgdGhlCiJpbnRlcm1lZGlhdGUiIGNsb2NrIHRoYXQg aXMgcmVxdWlyZWQgZHVyaW5nIHN3aXRjaGluZzoKY2xvY2tzID0gPCZtY3VjZmcgQ0xLX01DVV9N UDBfU0VMPiwgPCZ0b3Bja2dlbiBDTEtfVE9QX0FSTVBMTF9ESVZfUExMMT47CmNsb2NrLW5hbWVz ID0gImNwdSIsICJpbnRlcm1lZGlhdGUiOwoKVGhlIHRvcG9sb2d5IGxvb2tzIGxpa2UgdGhpczoK IGNsazI2bSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDE1ICAgICAgIDE1ICAgICAgICAx ICAgIDI2MDAwMDAwCiAgICAgICAgMCAgICAgMCAgNTAwMDAKICAgIGFybXBsbF9sbCAgICAgICAg ICAgICAgICAgICAgICAgICAxICAgICAgICAxICAgICAgICAwICAxNDE3MDAwMDAwCiAgICAgICAg MCAgICAgMCAgNTAwMDAKICAgICAgIG1jdV9tcDBfc2VsICAgICAgICAgICAgICAgICAgICAwICAg ICAgICAwICAgICAgICAwICAxNDE3MDAwMDAwCiAgICAgICAgMCAgICAgMCAgNTAwMDAKCkFuZCBk ZXZpY2UgdHJlZSBwcm92aWRlcyBtY3VfbXAwX3NlbCBhcyAiY3B1IiwgYW5kIHRoZSBhcm1wbGxf ZGl2X3BsbDEKYXMgImludGVybWVkaWF0ZSIuCgpUaGUgZHJpdmVyIGxvb2tzIHVwIGFybXBsbF9s bCBieSBjYWxsaW5nIGdldF9wYXJlbnQsIHRoZW46CiAtIHNldF9wYXJlbnQobWN1X21wMF9zZWws IGFybXBsbF9kaXZfcGxsMSkKIC0gc2V0X3JhdGUoYXJtcGxsX2xsLCBuZXdfcmF0ZSkKIC0gc2V0 X3BhcmVudChtY3VfbXAwX3NlbCwgYXJtcGxsX2xsKQoKT24gTVQ4MTgzJ3MgR1BVLCB0aGUgdG9w b2xvZ3kgaXMgYSBsaXR0bGUgYml0IG1vcmUgY29tcGxpY2F0ZWQgKGJ1dCBJCnRoaW5rIHRoZXJl IHNob3VsZCBiZSBhIHdheSB0byBtZXJnZSBtZmdfYmczZCBhbiBtZmdfc2VsIGluIHRoZSBjbG9j awpjb3JlKQogY2xrMjZtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMTUgICAgICAgMTUg ICAgICAgIDEgICAgMjYwMDAwMDAKICAgICAgICAwICAgICAwICA1MDAwMAogICAgbWZncGxsICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDEgICAgICAgIDEgICAgICAgIDAgICA0MTk5OTk4MTcK ICAgICAgICAwICAgICAwICA1MDAwMAogICAgICAgbWZncGxsX2NrICAgICAgICAgICAgICAgICAg ICAgIDIgICAgICAgIDIgICAgICAgIDAgICA0MTk5OTk4MTcKICAgICAgICAwICAgICAwICA1MDAw MAogICAgICAgICAgbWZnX3NlbCAgICAgICAgICAgICAgICAgICAgIDMgICAgICAgIDMgICAgICAg IDAgICA0MTk5OTk4MTcKICAgICAgICAwICAgICAwICA1MDAwMAogICAgICAgICAgICAgbWZnX2Jn M2QgICAgICAgICAgICAgICAgIDEgICAgICAgIDEgICAgICAgIDAgICA0MTk5OTk4MTcKICAgICAg ICAwICAgICAwICA1MDAwMAoKV2UncmUgZ29pbmcgdG8gbmVlZCBhIHNwZWNpYWwgcGFuZnJvc3Qg ZGV2ZnJlcSBkcml2ZXIgZm9yIG10ODE4Mwphbnl3YXkgKHRvIGhhbmRsZSB0aGUgMiByZWd1bGF0 b3JzKSwgc28gaXQgd291bGQgYmUgZWFzeSB0byB0YWtlIGEKc2ltaWxhciBhcHByb2FjaDoKIC0g QWRkICJpbnRlcm1lZGlhdGUiIGNsb2NrIGluIHRoZSBkZXZpY2UgdHJlZSAoY2xrMjZtKQogLSBG aW5kIG1mZ19zZWwvbWZncGxsX2NrIHVzaW5nIDEvMiBjbGtfZ2V0X3BhcmVudCBjYWxscy4KIC0g U3dpdGNoIG1mZ19zZWwgdG8gY2xrMjZtLCBzZXQgbWZncGxsX2NrIHJhdGUsIHN3aXRjaCBtZmdf c2VsIGJhY2sKdG8gbWZncGxsX2NrLgoKKEJUVywgSSB0cmllZCB0byBsb29rLCBhbmQgY291bGRu J3QgZmluZCBleGFtcGxlcyBvciByZXBhcmVudGluZwpkdXJpbmcgY2xvY2sgY2hhbmdlcyBpbiBk cml2ZXJzL2NsaywgYXJlIHRoZXJlIGV4aXN0aW5nIGRyaXZlcnMgZG9pbmcKc2ltaWxhciB0aGlu Z3M/IE9yIHRoaXMgd291bGQgYmUgbmV3PykuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpMaW51eC1tZWRpYXRlayBtYWlsaW5nIGxpc3QKTGludXgtbWVk aWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B322C10DCE for ; Mon, 9 Mar 2020 01:53:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3CCE20675 for ; Mon, 9 Mar 2020 01:53:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AL1lOknu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aWYnmvWG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3CCE20675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+ZcAgLy4bfDIv1laHM6uxc3WI2dzWWF2yGIqdE+pDvI=; b=AL1lOknuf/dX/o je8/CmV8XAFhVGFeH3NZwOzdrHX44LJGdohjMJVq48522XG9TtSSP6ZBkRXzaFN2VxhPklu3NvQEE ezCBTXPG0foezF7Zpnao/3whVV53Dd+Uu+uZ0dZiFXt/qI0TFdUpdffCuRcvruVEL5Za6e9bWoDIt IWF6livkKeuDTPTuzfFrxh9zsrjTtkgeVb6bMjkXwI75Gdb9l6uezFrFS2T7cPifyFNkXQCAZIyDl z5mzBpe9VLI+fN9uCMv/ogYBnZrL1MsquBLhm4cZv7wGQqyiP5PQBb21F2sxqRxXia1XnshnClQRX CZP7NrZI3vMs/PL7wiHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jB7c8-0002Y1-DN; Mon, 09 Mar 2020 01:53:52 +0000 Received: from mail-vs1-xe44.google.com ([2607:f8b0:4864:20::e44]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jB7c4-0002WW-Ga for linux-arm-kernel@lists.infradead.org; Mon, 09 Mar 2020 01:53:50 +0000 Received: by mail-vs1-xe44.google.com with SMTP id n27so5087520vsa.0 for ; Sun, 08 Mar 2020 18:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=QImbxmTkHKil1pvHr+BDxiJL2XLBZLzoyGW6wsTn3oQ=; b=aWYnmvWGdbntSuhyucIIAMxrZHkM4G5/Q9vbOmCQsekZAYHvr4Eog74dsXDkMYl2xD KvL1zeXKamlcuQTyyvQgkSKnT1gNRPF5uTVUa4a4fHcg/kx4VnHTixsNdroZ764sU1Uy +tKikHrHiZuRBXkYz+/Z8bBjwf8qxvraCz7gQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=QImbxmTkHKil1pvHr+BDxiJL2XLBZLzoyGW6wsTn3oQ=; b=RqtDtm3N/jCj9a9m9C+dYUCybCPiflXQBEWMW481BlbWwQDh2XvccujhMmMYp61yXu 521RKO40Z+o1K7fZBGHPdWCNGQ+HXOjj4SWIA+2zbPwpkVSxO0p/cHCKiNPVmPaKpVWc Y41kFj0fc3/kn84SS/eOtf70ef4xwpup7R45zhVTieCri2dOebziwsjg4aIhBowZGG5Z dTBZgfMfn4vX1U/3ZL/NZnfeaw44FCrNfvjniaEeB7ko6UA41C4nxUEB+EWHjhZTKh4C oWGzI9RBlRle5G1dwLt5lLqipjeZ1CoAv24i84SrpuqfXb/wh24I7OOWqMzeQe3xg6Nz t8Bg== X-Gm-Message-State: ANhLgQ2LsXoQTKYgIoOGDwoe3jMIyLXLBhJU74wOgZtf/JjrYeAOerSV p/iBBAAzW8za6jjPHOqr7LTWlRh0lQeclGzwh8D/vg== X-Google-Smtp-Source: ADFU+vvYsFjqtY5zn3zCc01nvvuQjne4/YR7CEb/r3521XiWmW+BqevLE59/BQHtNHTJV1ro52aTXPZEfqp1TtQdFWA= X-Received: by 2002:a05:6102:9c7:: with SMTP id g7mr8614280vsi.186.1583718826912; Sun, 08 Mar 2020 18:53:46 -0700 (PDT) MIME-Version: 1.0 References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-8-drinkcat@chromium.org> In-Reply-To: From: Nicolas Boichat Date: Mon, 9 Mar 2020 09:53:35 +0800 Message-ID: Subject: Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators To: =?UTF-8?B?TmljayBGYW4gKOiMg+WTsue2rSk=?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200308_185348_579110_42BA3510 X-CRM114-Status: GOOD ( 24.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ulf Hansson , David Airlie , Viresh Kumar , dri-devel , Liam Girdwood , =?UTF-8?B?V2VpeWkgTHUgKOWRguWogeWEgCk=?= , Steven Price , Alyssa Rosenzweig , Devicetree List , =?UTF-8?B?U2ogSHVhbmcgKOm7g+S/oeeSiyk=?= , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang , Matthias Brugger , linux-arm Mailing List , Tomeu Vizoso , Stephen Boyd , lkml , =?UTF-8?B?SkIgVHNhaSAo6JSh5b+X5b2sKQ==?= , Rob Herring , Daniel Vetter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org TG9vcGluZyBiYWNrIG9uIHRoaXMsIGFmdGVyIGRpZ2dpbmcgYSBiaXQgZGVlcGVyLi4uCgpPbiBG cmksIEZlYiAxNCwgMjAyMCBhdCA5OjM4IEFNIE5pY2sgRmFuICjojIPlk7Lntq0pIDxOaWNrLkZh bkBtZWRpYXRlay5jb20+IHdyb3RlOgo+IFtzbmlwXQo+ID4gPiBBbm90aGVyIHRoaW5nIHRoYXQg SSdtIG5vdCBpbXBsZW1lbnRpbmcgaXMgdGhlIGRhbmNlIHRoYXQgTWVkaWF0ZWsKPiA+ID4gZG9l cyBpbiB0aGVpciBrYmFzZSBkcml2ZXIgd2hlbiBjaGFuZ2luZyB0aGUgY2xvY2sgKGRlc2NyaWJl ZCBpbgo+ID4gPiBwYXRjaAo+ID4gPiAyLzcpOgo+ID4gPiAiIgo+ID4gPiBUaGUgYmluZGluZyB3 ZSB1c2Ugd2l0aCBvdXQtb2YtdHJlZSBNYWxpIGRyaXZlcnMgaW5jbHVkZXMgbW9yZQo+ID4gPiBj bG9ja3MsIHRoaXMgaXMgdXNlZCBmb3IgZGV2ZnJlcTogdGhlIG91dC1vZi10cmVlIGRyaXZlciBz d2l0Y2hlcwo+ID4gPiBjbGtfbXV4IHRvIGNsa19zdWJfcGFyZW50ICgyNk1oeiksIGFkanVzdHMg Y2xrX21haW5fcGFyZW50LCB0aGVuCj4gPiA+IHN3aXRjaGVzIGNsa19tdXggYmFjayB0byBjbGtf bWFpbl9wYXJlbnQ6Cj4gPiA+IChzZWUKPiA+ID4gaHR0cHM6Ly9jaHJvbWl1bS5nb29nbGVzb3Vy Y2UuY29tL2Nocm9taXVtb3MvdGhpcmRfcGFydHkva2VybmVsLysvY2gKPiA+ID4gcm9tZW9zLTQu MTkvZHJpdmVycy9ncHUvYXJtL21pZGdhcmQvcGxhdGZvcm0vbWVkaWF0ZWsvbWFsaV9rYmFzZV9y dW4KPiA+ID4gdGltZV9wbS5jIzQyMykKPiA+ID4gY2xvY2tzID0KPiA+ID4gICAgICAgICA8JnRv cGNrZ2VuIENMS19UT1BfTUZHUExMX0NLPiwKPiA+ID4gICAgICAgICA8JnRvcGNrZ2VuIENMS19U T1BfTVVYX01GRz4sCj4gPiA+ICAgICAgICAgPCZjbGsyNm0+LAo+ID4gPiAgICAgICAgIDwmbWZn Y2ZnIENMS19NRkdfQkczRD47Cj4gPiA+IGNsb2NrLW5hbWVzID0KPiA+ID4gICAgICAgICAiY2xr X21haW5fcGFyZW50IiwKPiA+ID4gICAgICAgICAiY2xrX211eCIsCj4gPiA+ICAgICAgICAgImNs a19zdWJfcGFyZW50IiwKPiA+ID4gICAgICAgICAic3Vic3lzX21mZ19jZyI7Cj4gPiA+ICIiCj4g PiA+IElzIHRoZXJlIGEgY2xlYW4vc2ltcGxlIHdheSB0byBpbXBsZW1lbnQgdGhpcyBpbiB0aGUg Y2xvY2sKPiA+ID4gZnJhbWV3b3JrL2RldmljZSB0cmVlPyBPciBzaG91bGQgd2UgaW1wbGVtZW50 IHNvbWV0aGluZyBpbiB0aGUKPiA+ID4gcGFuZnJvc3QgZHJpdmVyPwo+ID4KPiA+IFB1dHRpbmcg cGFyZW50IGNsb2NrcyBpbnRvICdjbG9ja3MnIGZvciBhIGRldmljZSBpcyBhIHByZXR0eSBjb21t b24KPiA+IGFidXNlLiBUaGUgJ2Fzc2lnbmVkLWNsb2NrcycgYmluZGluZyBpcyB3aGF0J3MgdXNl ZCBmb3IgcGFyZW50IGNsb2NrCj4gPiBzZXR1cC4gTm90IHN1cmUgdGhhdCdzIGdvaW5nIHRvIGhl bHAgaGVyZSB0aG91Z2guIElzIHRoaXMgZGFuY2UKPiA+IGJlY2F1c2UgdGhlIHBhcmVudCBjbG9j ayBmcmVxdWVuY3kgY2FuJ3QgYmUgY2hhbmdlZCBjbGVhbmx5Pwo+Cj4gTmljay9XZWl5aSwgYW55 IGlkZWEgd2h5IHdlIGRvIHRoYXQgZGFuY2UgaW4gdGhlIGZpcnN0IHBsYWNlPyAobWF5YmUgdGhl IFBMTCBjbG9jayBpcyB1bnN0YWJsZSB3aGlsZSBpdCdzIGJlaW5nIGNoYW5nZWQ/KQo+Cj4gQ2xv Y2sgc291cmNlIG1heSBiZWNvbWUgdW5zdGFibGUgZHVyaW5nIGNsb2NrIGZyZXF1ZW5jeSBjaGFu Z2VzLCBzbyBpdCBpcyBhbHdheXMgc2FmZXIgdG8gc3dpdGNoIHRvIGEgbW9yZSByZWxpYWJsZSBj bG9jayBzb3VyY2UuCj4gT3RoZXJ3aXNlLCBpdCBtYXkgY2F1c2Ugc29tZSBwcm9ibGVtIGluIHNv bWUgY29ybmVyIGNhc2UuCj4gSSB3b3VsZCBzdWdnZXN0IHRvIGtlZXAgaXQuCgpUaGUgTWVkaWF0 ZWsgQ1BVZnJlcSBkcml2ZXIgYWN0dWFsbHkgZG9lcyBhIHZlcnkgc2ltaWxhciBkYW5jZToKaHR0 cHM6Ly9naXRodWIuY29tL3RvcnZhbGRzL2xpbnV4L2Jsb2IvbWFzdGVyL2RyaXZlcnMvY3B1ZnJl cS9tZWRpYXRlay1jcHVmcmVxLmMjTDI0OQoKV2hhdCB0aGV5IGhhdmUgaW4gdGhlIGRldmljZSB0 cmVlIGlzIHRoZSBtYWluIGNsb2NrLCBhbmQgdGhlCiJpbnRlcm1lZGlhdGUiIGNsb2NrIHRoYXQg aXMgcmVxdWlyZWQgZHVyaW5nIHN3aXRjaGluZzoKY2xvY2tzID0gPCZtY3VjZmcgQ0xLX01DVV9N UDBfU0VMPiwgPCZ0b3Bja2dlbiBDTEtfVE9QX0FSTVBMTF9ESVZfUExMMT47CmNsb2NrLW5hbWVz ID0gImNwdSIsICJpbnRlcm1lZGlhdGUiOwoKVGhlIHRvcG9sb2d5IGxvb2tzIGxpa2UgdGhpczoK IGNsazI2bSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDE1ICAgICAgIDE1ICAgICAgICAx ICAgIDI2MDAwMDAwCiAgICAgICAgMCAgICAgMCAgNTAwMDAKICAgIGFybXBsbF9sbCAgICAgICAg ICAgICAgICAgICAgICAgICAxICAgICAgICAxICAgICAgICAwICAxNDE3MDAwMDAwCiAgICAgICAg MCAgICAgMCAgNTAwMDAKICAgICAgIG1jdV9tcDBfc2VsICAgICAgICAgICAgICAgICAgICAwICAg ICAgICAwICAgICAgICAwICAxNDE3MDAwMDAwCiAgICAgICAgMCAgICAgMCAgNTAwMDAKCkFuZCBk ZXZpY2UgdHJlZSBwcm92aWRlcyBtY3VfbXAwX3NlbCBhcyAiY3B1IiwgYW5kIHRoZSBhcm1wbGxf ZGl2X3BsbDEKYXMgImludGVybWVkaWF0ZSIuCgpUaGUgZHJpdmVyIGxvb2tzIHVwIGFybXBsbF9s bCBieSBjYWxsaW5nIGdldF9wYXJlbnQsIHRoZW46CiAtIHNldF9wYXJlbnQobWN1X21wMF9zZWws IGFybXBsbF9kaXZfcGxsMSkKIC0gc2V0X3JhdGUoYXJtcGxsX2xsLCBuZXdfcmF0ZSkKIC0gc2V0 X3BhcmVudChtY3VfbXAwX3NlbCwgYXJtcGxsX2xsKQoKT24gTVQ4MTgzJ3MgR1BVLCB0aGUgdG9w b2xvZ3kgaXMgYSBsaXR0bGUgYml0IG1vcmUgY29tcGxpY2F0ZWQgKGJ1dCBJCnRoaW5rIHRoZXJl IHNob3VsZCBiZSBhIHdheSB0byBtZXJnZSBtZmdfYmczZCBhbiBtZmdfc2VsIGluIHRoZSBjbG9j awpjb3JlKQogY2xrMjZtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMTUgICAgICAgMTUg ICAgICAgIDEgICAgMjYwMDAwMDAKICAgICAgICAwICAgICAwICA1MDAwMAogICAgbWZncGxsICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDEgICAgICAgIDEgICAgICAgIDAgICA0MTk5OTk4MTcK ICAgICAgICAwICAgICAwICA1MDAwMAogICAgICAgbWZncGxsX2NrICAgICAgICAgICAgICAgICAg ICAgIDIgICAgICAgIDIgICAgICAgIDAgICA0MTk5OTk4MTcKICAgICAgICAwICAgICAwICA1MDAw MAogICAgICAgICAgbWZnX3NlbCAgICAgICAgICAgICAgICAgICAgIDMgICAgICAgIDMgICAgICAg IDAgICA0MTk5OTk4MTcKICAgICAgICAwICAgICAwICA1MDAwMAogICAgICAgICAgICAgbWZnX2Jn M2QgICAgICAgICAgICAgICAgIDEgICAgICAgIDEgICAgICAgIDAgICA0MTk5OTk4MTcKICAgICAg ICAwICAgICAwICA1MDAwMAoKV2UncmUgZ29pbmcgdG8gbmVlZCBhIHNwZWNpYWwgcGFuZnJvc3Qg ZGV2ZnJlcSBkcml2ZXIgZm9yIG10ODE4Mwphbnl3YXkgKHRvIGhhbmRsZSB0aGUgMiByZWd1bGF0 b3JzKSwgc28gaXQgd291bGQgYmUgZWFzeSB0byB0YWtlIGEKc2ltaWxhciBhcHByb2FjaDoKIC0g QWRkICJpbnRlcm1lZGlhdGUiIGNsb2NrIGluIHRoZSBkZXZpY2UgdHJlZSAoY2xrMjZtKQogLSBG aW5kIG1mZ19zZWwvbWZncGxsX2NrIHVzaW5nIDEvMiBjbGtfZ2V0X3BhcmVudCBjYWxscy4KIC0g U3dpdGNoIG1mZ19zZWwgdG8gY2xrMjZtLCBzZXQgbWZncGxsX2NrIHJhdGUsIHN3aXRjaCBtZmdf c2VsIGJhY2sKdG8gbWZncGxsX2NrLgoKKEJUVywgSSB0cmllZCB0byBsb29rLCBhbmQgY291bGRu J3QgZmluZCBleGFtcGxlcyBvciByZXBhcmVudGluZwpkdXJpbmcgY2xvY2sgY2hhbmdlcyBpbiBk cml2ZXJzL2NsaywgYXJlIHRoZXJlIGV4aXN0aW5nIGRyaXZlcnMgZG9pbmcKc2ltaWxhciB0aGlu Z3M/IE9yIHRoaXMgd291bGQgYmUgbmV3PykuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A3A9C10DCE for ; Mon, 9 Mar 2020 01:53:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FDF620675 for ; Mon, 9 Mar 2020 01:53:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aWYnmvWG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FDF620675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 446216E0CA; Mon, 9 Mar 2020 01:53:48 +0000 (UTC) Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by gabe.freedesktop.org (Postfix) with ESMTPS id EAEA16E0CA for ; Mon, 9 Mar 2020 01:53:47 +0000 (UTC) Received: by mail-vs1-xe44.google.com with SMTP id k26so5066494vso.5 for ; Sun, 08 Mar 2020 18:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=QImbxmTkHKil1pvHr+BDxiJL2XLBZLzoyGW6wsTn3oQ=; b=aWYnmvWGdbntSuhyucIIAMxrZHkM4G5/Q9vbOmCQsekZAYHvr4Eog74dsXDkMYl2xD KvL1zeXKamlcuQTyyvQgkSKnT1gNRPF5uTVUa4a4fHcg/kx4VnHTixsNdroZ764sU1Uy +tKikHrHiZuRBXkYz+/Z8bBjwf8qxvraCz7gQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=QImbxmTkHKil1pvHr+BDxiJL2XLBZLzoyGW6wsTn3oQ=; b=YbboqpGWNRdnW9vaV7mjRWPY1NNq8H5DO4Z83lUdxEsv1Uzug0BHxLd6iGU2FCtpwG fxASQdW1c3u6PQgHYBN8CgGWafRFYgLncSpx5bJ1IVIUW46e8rfQd14BqvWYTmBzA/xh zedWqRj/B9udif2ZD2lKkAY0OIowdC8ROCFKFTpwDbBerIMkvphnjSd++ewH0+RgElYI I4oRn2zw7kBzBWfa8662aRa0pxIhoHIpjhDMClRmGfgUkeWy8Q6TZxQgeXr1j9qgTFNx Q9jvDQMwCnCg2X9+WVdMM0wVSsLrglCfy/4bnHrQXKEJ5IyL5nBrKh9kxbgjTOAOWi1T Ci0w== X-Gm-Message-State: ANhLgQ0DBKXLYOHECLdr64JE0CFhjiyUqdYP6P5DUjhg5sV2Tjcu8XG0 KVlPZXKnwLc/qUUOtSE+YsXmeE/PNo9xWhAARipR2w== X-Google-Smtp-Source: ADFU+vvYsFjqtY5zn3zCc01nvvuQjne4/YR7CEb/r3521XiWmW+BqevLE59/BQHtNHTJV1ro52aTXPZEfqp1TtQdFWA= X-Received: by 2002:a05:6102:9c7:: with SMTP id g7mr8614280vsi.186.1583718826912; Sun, 08 Mar 2020 18:53:46 -0700 (PDT) MIME-Version: 1.0 References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-8-drinkcat@chromium.org> In-Reply-To: From: Nicolas Boichat Date: Mon, 9 Mar 2020 09:53:35 +0800 Message-ID: Subject: Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators To: =?UTF-8?B?TmljayBGYW4gKOiMg+WTsue2rSk=?= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ulf Hansson , David Airlie , Viresh Kumar , dri-devel , Liam Girdwood , =?UTF-8?B?V2VpeWkgTHUgKOWRguWogeWEgCk=?= , Steven Price , Alyssa Rosenzweig , Devicetree List , =?UTF-8?B?U2ogSHVhbmcgKOm7g+S/oeeSiyk=?= , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang , Matthias Brugger , linux-arm Mailing List , Tomeu Vizoso , Stephen Boyd , lkml , =?UTF-8?B?SkIgVHNhaSAo6JSh5b+X5b2sKQ==?= , Rob Herring Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" TG9vcGluZyBiYWNrIG9uIHRoaXMsIGFmdGVyIGRpZ2dpbmcgYSBiaXQgZGVlcGVyLi4uCgpPbiBG cmksIEZlYiAxNCwgMjAyMCBhdCA5OjM4IEFNIE5pY2sgRmFuICjojIPlk7Lntq0pIDxOaWNrLkZh bkBtZWRpYXRlay5jb20+IHdyb3RlOgo+IFtzbmlwXQo+ID4gPiBBbm90aGVyIHRoaW5nIHRoYXQg SSdtIG5vdCBpbXBsZW1lbnRpbmcgaXMgdGhlIGRhbmNlIHRoYXQgTWVkaWF0ZWsKPiA+ID4gZG9l cyBpbiB0aGVpciBrYmFzZSBkcml2ZXIgd2hlbiBjaGFuZ2luZyB0aGUgY2xvY2sgKGRlc2NyaWJl ZCBpbgo+ID4gPiBwYXRjaAo+ID4gPiAyLzcpOgo+ID4gPiAiIgo+ID4gPiBUaGUgYmluZGluZyB3 ZSB1c2Ugd2l0aCBvdXQtb2YtdHJlZSBNYWxpIGRyaXZlcnMgaW5jbHVkZXMgbW9yZQo+ID4gPiBj bG9ja3MsIHRoaXMgaXMgdXNlZCBmb3IgZGV2ZnJlcTogdGhlIG91dC1vZi10cmVlIGRyaXZlciBz d2l0Y2hlcwo+ID4gPiBjbGtfbXV4IHRvIGNsa19zdWJfcGFyZW50ICgyNk1oeiksIGFkanVzdHMg Y2xrX21haW5fcGFyZW50LCB0aGVuCj4gPiA+IHN3aXRjaGVzIGNsa19tdXggYmFjayB0byBjbGtf bWFpbl9wYXJlbnQ6Cj4gPiA+IChzZWUKPiA+ID4gaHR0cHM6Ly9jaHJvbWl1bS5nb29nbGVzb3Vy Y2UuY29tL2Nocm9taXVtb3MvdGhpcmRfcGFydHkva2VybmVsLysvY2gKPiA+ID4gcm9tZW9zLTQu MTkvZHJpdmVycy9ncHUvYXJtL21pZGdhcmQvcGxhdGZvcm0vbWVkaWF0ZWsvbWFsaV9rYmFzZV9y dW4KPiA+ID4gdGltZV9wbS5jIzQyMykKPiA+ID4gY2xvY2tzID0KPiA+ID4gICAgICAgICA8JnRv cGNrZ2VuIENMS19UT1BfTUZHUExMX0NLPiwKPiA+ID4gICAgICAgICA8JnRvcGNrZ2VuIENMS19U T1BfTVVYX01GRz4sCj4gPiA+ICAgICAgICAgPCZjbGsyNm0+LAo+ID4gPiAgICAgICAgIDwmbWZn Y2ZnIENMS19NRkdfQkczRD47Cj4gPiA+IGNsb2NrLW5hbWVzID0KPiA+ID4gICAgICAgICAiY2xr X21haW5fcGFyZW50IiwKPiA+ID4gICAgICAgICAiY2xrX211eCIsCj4gPiA+ICAgICAgICAgImNs a19zdWJfcGFyZW50IiwKPiA+ID4gICAgICAgICAic3Vic3lzX21mZ19jZyI7Cj4gPiA+ICIiCj4g PiA+IElzIHRoZXJlIGEgY2xlYW4vc2ltcGxlIHdheSB0byBpbXBsZW1lbnQgdGhpcyBpbiB0aGUg Y2xvY2sKPiA+ID4gZnJhbWV3b3JrL2RldmljZSB0cmVlPyBPciBzaG91bGQgd2UgaW1wbGVtZW50 IHNvbWV0aGluZyBpbiB0aGUKPiA+ID4gcGFuZnJvc3QgZHJpdmVyPwo+ID4KPiA+IFB1dHRpbmcg cGFyZW50IGNsb2NrcyBpbnRvICdjbG9ja3MnIGZvciBhIGRldmljZSBpcyBhIHByZXR0eSBjb21t b24KPiA+IGFidXNlLiBUaGUgJ2Fzc2lnbmVkLWNsb2NrcycgYmluZGluZyBpcyB3aGF0J3MgdXNl ZCBmb3IgcGFyZW50IGNsb2NrCj4gPiBzZXR1cC4gTm90IHN1cmUgdGhhdCdzIGdvaW5nIHRvIGhl bHAgaGVyZSB0aG91Z2guIElzIHRoaXMgZGFuY2UKPiA+IGJlY2F1c2UgdGhlIHBhcmVudCBjbG9j ayBmcmVxdWVuY3kgY2FuJ3QgYmUgY2hhbmdlZCBjbGVhbmx5Pwo+Cj4gTmljay9XZWl5aSwgYW55 IGlkZWEgd2h5IHdlIGRvIHRoYXQgZGFuY2UgaW4gdGhlIGZpcnN0IHBsYWNlPyAobWF5YmUgdGhl IFBMTCBjbG9jayBpcyB1bnN0YWJsZSB3aGlsZSBpdCdzIGJlaW5nIGNoYW5nZWQ/KQo+Cj4gQ2xv Y2sgc291cmNlIG1heSBiZWNvbWUgdW5zdGFibGUgZHVyaW5nIGNsb2NrIGZyZXF1ZW5jeSBjaGFu Z2VzLCBzbyBpdCBpcyBhbHdheXMgc2FmZXIgdG8gc3dpdGNoIHRvIGEgbW9yZSByZWxpYWJsZSBj bG9jayBzb3VyY2UuCj4gT3RoZXJ3aXNlLCBpdCBtYXkgY2F1c2Ugc29tZSBwcm9ibGVtIGluIHNv bWUgY29ybmVyIGNhc2UuCj4gSSB3b3VsZCBzdWdnZXN0IHRvIGtlZXAgaXQuCgpUaGUgTWVkaWF0 ZWsgQ1BVZnJlcSBkcml2ZXIgYWN0dWFsbHkgZG9lcyBhIHZlcnkgc2ltaWxhciBkYW5jZToKaHR0 cHM6Ly9naXRodWIuY29tL3RvcnZhbGRzL2xpbnV4L2Jsb2IvbWFzdGVyL2RyaXZlcnMvY3B1ZnJl cS9tZWRpYXRlay1jcHVmcmVxLmMjTDI0OQoKV2hhdCB0aGV5IGhhdmUgaW4gdGhlIGRldmljZSB0 cmVlIGlzIHRoZSBtYWluIGNsb2NrLCBhbmQgdGhlCiJpbnRlcm1lZGlhdGUiIGNsb2NrIHRoYXQg aXMgcmVxdWlyZWQgZHVyaW5nIHN3aXRjaGluZzoKY2xvY2tzID0gPCZtY3VjZmcgQ0xLX01DVV9N UDBfU0VMPiwgPCZ0b3Bja2dlbiBDTEtfVE9QX0FSTVBMTF9ESVZfUExMMT47CmNsb2NrLW5hbWVz ID0gImNwdSIsICJpbnRlcm1lZGlhdGUiOwoKVGhlIHRvcG9sb2d5IGxvb2tzIGxpa2UgdGhpczoK IGNsazI2bSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDE1ICAgICAgIDE1ICAgICAgICAx ICAgIDI2MDAwMDAwCiAgICAgICAgMCAgICAgMCAgNTAwMDAKICAgIGFybXBsbF9sbCAgICAgICAg ICAgICAgICAgICAgICAgICAxICAgICAgICAxICAgICAgICAwICAxNDE3MDAwMDAwCiAgICAgICAg MCAgICAgMCAgNTAwMDAKICAgICAgIG1jdV9tcDBfc2VsICAgICAgICAgICAgICAgICAgICAwICAg ICAgICAwICAgICAgICAwICAxNDE3MDAwMDAwCiAgICAgICAgMCAgICAgMCAgNTAwMDAKCkFuZCBk ZXZpY2UgdHJlZSBwcm92aWRlcyBtY3VfbXAwX3NlbCBhcyAiY3B1IiwgYW5kIHRoZSBhcm1wbGxf ZGl2X3BsbDEKYXMgImludGVybWVkaWF0ZSIuCgpUaGUgZHJpdmVyIGxvb2tzIHVwIGFybXBsbF9s bCBieSBjYWxsaW5nIGdldF9wYXJlbnQsIHRoZW46CiAtIHNldF9wYXJlbnQobWN1X21wMF9zZWws IGFybXBsbF9kaXZfcGxsMSkKIC0gc2V0X3JhdGUoYXJtcGxsX2xsLCBuZXdfcmF0ZSkKIC0gc2V0 X3BhcmVudChtY3VfbXAwX3NlbCwgYXJtcGxsX2xsKQoKT24gTVQ4MTgzJ3MgR1BVLCB0aGUgdG9w b2xvZ3kgaXMgYSBsaXR0bGUgYml0IG1vcmUgY29tcGxpY2F0ZWQgKGJ1dCBJCnRoaW5rIHRoZXJl IHNob3VsZCBiZSBhIHdheSB0byBtZXJnZSBtZmdfYmczZCBhbiBtZmdfc2VsIGluIHRoZSBjbG9j awpjb3JlKQogY2xrMjZtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMTUgICAgICAgMTUg ICAgICAgIDEgICAgMjYwMDAwMDAKICAgICAgICAwICAgICAwICA1MDAwMAogICAgbWZncGxsICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDEgICAgICAgIDEgICAgICAgIDAgICA0MTk5OTk4MTcK ICAgICAgICAwICAgICAwICA1MDAwMAogICAgICAgbWZncGxsX2NrICAgICAgICAgICAgICAgICAg ICAgIDIgICAgICAgIDIgICAgICAgIDAgICA0MTk5OTk4MTcKICAgICAgICAwICAgICAwICA1MDAw MAogICAgICAgICAgbWZnX3NlbCAgICAgICAgICAgICAgICAgICAgIDMgICAgICAgIDMgICAgICAg IDAgICA0MTk5OTk4MTcKICAgICAgICAwICAgICAwICA1MDAwMAogICAgICAgICAgICAgbWZnX2Jn M2QgICAgICAgICAgICAgICAgIDEgICAgICAgIDEgICAgICAgIDAgICA0MTk5OTk4MTcKICAgICAg ICAwICAgICAwICA1MDAwMAoKV2UncmUgZ29pbmcgdG8gbmVlZCBhIHNwZWNpYWwgcGFuZnJvc3Qg ZGV2ZnJlcSBkcml2ZXIgZm9yIG10ODE4Mwphbnl3YXkgKHRvIGhhbmRsZSB0aGUgMiByZWd1bGF0 b3JzKSwgc28gaXQgd291bGQgYmUgZWFzeSB0byB0YWtlIGEKc2ltaWxhciBhcHByb2FjaDoKIC0g QWRkICJpbnRlcm1lZGlhdGUiIGNsb2NrIGluIHRoZSBkZXZpY2UgdHJlZSAoY2xrMjZtKQogLSBG aW5kIG1mZ19zZWwvbWZncGxsX2NrIHVzaW5nIDEvMiBjbGtfZ2V0X3BhcmVudCBjYWxscy4KIC0g U3dpdGNoIG1mZ19zZWwgdG8gY2xrMjZtLCBzZXQgbWZncGxsX2NrIHJhdGUsIHN3aXRjaCBtZmdf c2VsIGJhY2sKdG8gbWZncGxsX2NrLgoKKEJUVywgSSB0cmllZCB0byBsb29rLCBhbmQgY291bGRu J3QgZmluZCBleGFtcGxlcyBvciByZXBhcmVudGluZwpkdXJpbmcgY2xvY2sgY2hhbmdlcyBpbiBk cml2ZXJzL2NsaywgYXJlIHRoZXJlIGV4aXN0aW5nIGRyaXZlcnMgZG9pbmcKc2ltaWxhciB0aGlu Z3M/IE9yIHRoaXMgd291bGQgYmUgbmV3PykuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=