From: Alexander Kanavin <alex.kanavin@gmail.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>
Cc: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>,
Alexander Kanavin <alex@linutronix.de>
Subject: Re: [OE-core] [PATCH] scripts/oe-setup-builddir: migrate build/conf/templateconf.cfg to new template locations
Date: Fri, 2 Sep 2022 09:16:15 +0200 [thread overview]
Message-ID: <CANNYZj-YxzNONuKM5UVsvW7aS+k+aDTUw4GeK=MkMgGCdygxFg@mail.gmail.com> (raw)
In-Reply-To: <1710F0E3F6A43399.12033@lists.openembedded.org>
On Fri, 2 Sept 2022 at 06:32, Alexander Kanavin via
lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org>
wrote:
> We can however add a hint to check what is in
> build/conf/templateconf.cfg if the test fails, as it is not obvious
> that TEMPLATECONF obtained from there takes priority over other
> sources (which are, in order, TEMPLATECONF passed via environment,
> then .templateconf next to oe-init-build-env).
Ok, the more I think about this, the more I'm convinced that
oe-setup-builddir needs a complete refactor. Specifically:
1. Let's rewrite it in python; shell just isn't expressive or readable
enough for what it needs to do.
2. Let's have a clear, logical priority order: TEMPLATECONF env var,
build/conf/templateconf.cfg, dirname('oe-init-build-env') +
'/.templateconf'
3. build/conf/templateconf.cfg becomes read-only; the final selected
value for TEMPLATECONF is written into a separate file (for having a
reference to where the configs came from).
4. oe-setup-builddir can also later be extended to support
'configuration fragments' management, see my email to oe-archtecture
from yesterday.
It's just too late to do this in this release cycle, but worth looking
into afterwards.
Alex
next prev parent reply other threads:[~2022-09-02 7:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 14:23 [PATCH] scripts/oe-setup-builddir: migrate build/conf/templateconf.cfg to new template locations Alexander Kanavin
2022-09-02 0:12 ` [OE-core] " Peter Kjellerstedt
2022-09-02 4:31 ` Alexander Kanavin
2022-09-02 14:47 ` Peter Kjellerstedt
2022-09-02 15:08 ` Alexander Kanavin
2022-09-02 15:41 ` Peter Kjellerstedt
2022-09-02 16:50 ` Alexander Kanavin
[not found] ` <1710F0E3F6A43399.12033@lists.openembedded.org>
2022-09-02 7:16 ` Alexander Kanavin [this message]
2022-09-02 7:37 ` Richard Purdie
2022-09-02 7:41 ` Alexander Kanavin
[not found] ` <1710FB3AA9843A6F.13805@lists.openembedded.org>
2022-09-02 10:57 ` Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANNYZj-YxzNONuKM5UVsvW7aS+k+aDTUw4GeK=MkMgGCdygxFg@mail.gmail.com' \
--to=alex.kanavin@gmail.com \
--cc=alex@linutronix.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.