On Mon, 24 May 2021 at 19:16, Vinay Kumar <vinay.m.engg@gmail.com> wrote:

> Build remote-test-server copy to image and execute
> remotely through background ssh.
>

Thanks, I do not have any further comments about the overall structure, the
below are more specific concerns.


> +               with runqemu("core-image-minimal", runqemuparams =
> "nographic", qemuparams= " -monitor \
> +                        telnet:127.0.0.1:1234,server,nowait -serial
> mon:stdio -serial null") as qemu:
>

Hardcoding the ip port this way is problematic and prone to conflicts. What
is -monitor used for?


> +                       cmd = cmd + " cd %s;  python3
> src/bootstrap/bootstrap.py -j 40 --verbose test %s --target %s >
> summary.txt 2> /dev/null " % (builddir, testargs, targetsys)
>

What does -j 40 do? Keep in mind that qemu has only 4 virtual cpu cores.


> +                       runCmd(cmd)
>

What happens if the test executed via runCmd fails? Specifically, will the
failure be properly reported?

I'm wondering because the output of the test is redirected to summary.txt
(which is then left unused), and stderr is discarded altogether.


> +                       # Stop ssh background execution
> +                       t_thread.stop()
>

Will t_thread be stopped if runCmd fails?

Alex