From: Alexander Kanavin <alex.kanavin@gmail.com>
To: Marek Vasut <marex@denx.de>, Konrad Weihmann <kweihmann@outlook.com>
Cc: Martin Jansa <martin.jansa@gmail.com>,
OpenEmbedded Devel List
<openembedded-devel@lists.openembedded.org>,
Khem Raj <raj.khem@gmail.com>
Subject: Re: [oe] [meta-oe][PATCH] freerdp: Use DEPENDS:append
Date: Tue, 7 Dec 2021 14:23:53 +0100 [thread overview]
Message-ID: <CANNYZj-w7xB2r-FvXKbj88CNO5ibxnF1MfmN2z+p-j+_-HNLvg@mail.gmail.com> (raw)
In-Reply-To: <4a4bd8ca-9fae-c03a-acf1-d25fc44a84dd@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
Perhaps this issue should be addressed to Konrad first before rushing to
write a patch?
Alex
On Tue, 7 Dec 2021 at 14:22, Marek Vasut <marex@denx.de> wrote:
> On 12/7/21 13:35, Martin Jansa wrote:
> >> The build system might have put something into DEPENDS already
> >
> > There is only copyright notice before this chunk, so this doesn't make
> much
> > sense to me (and no other recipe does this).
>
> At least oelint-adv warns about it here:
>
> https://github.com/priv-kweihmann/oelint-adv/blob/master/oelint_adv/rule_base/rule_var_depends_append.py
>
> And as far as I can tell, bitbake can stick something into DEPENDS
> before it parses this recipe, so the :append is valid.
>
> Furthermore, git grep through oe-core already indicates a few recipes
> which use DEPENDS:append.
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#94231):
> https://lists.openembedded.org/g/openembedded-devel/message/94231
> Mute This Topic: https://lists.openembedded.org/mt/87562882/1686489
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
[-- Attachment #2: Type: text/html, Size: 2243 bytes --]
next prev parent reply other threads:[~2021-12-07 13:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 11:39 [meta-oe][PATCH] freerdp: Use DEPENDS:append Marek Vasut
2021-12-07 12:03 ` [oe] " Jacob Kroon
2021-12-07 12:09 ` Alexander Kanavin
2021-12-07 12:35 ` Martin Jansa
2021-12-07 13:22 ` Marek Vasut
2021-12-07 13:23 ` Alexander Kanavin [this message]
2021-12-07 13:27 ` Marek Vasut
2021-12-07 13:33 ` Alexander Kanavin
2021-12-07 13:35 ` Marek Vasut
2021-12-07 13:42 ` Konrad Weihmann
2021-12-07 17:16 ` Konrad Weihmann
2021-12-08 9:36 ` Konrad Weihmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANNYZj-w7xB2r-FvXKbj88CNO5ibxnF1MfmN2z+p-j+_-HNLvg@mail.gmail.com \
--to=alex.kanavin@gmail.com \
--cc=kweihmann@outlook.com \
--cc=marex@denx.de \
--cc=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.