All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kanavin <alex.kanavin@gmail.com>
To: Martin Jansa <Martin.Jansa@gmail.com>,
	s.mueller-klieser@phytec.de, n.wesp@phytec.de
Cc: Rudolf J Streif <rudolf.streif@ibeeto.com>,
	Zoran <zoran.stojsavljevic@gmail.com>,
	 Yocto-mailing-list <yocto@lists.yoctoproject.org>
Subject: Re: [yocto] LAYERSERIES_COMPAT_ variable in the layer's recipe
Date: Thu, 1 Dec 2022 11:09:43 +0100	[thread overview]
Message-ID: <CANNYZj8uXJ189UckEVktdEuRgLpAcn+driQqnxj0KLaGYSU=wQ@mail.gmail.com> (raw)
In-Reply-To: <CA+chaQcphLsdya8v9SD=+XAb2bNWQ1bWxCdCRWOVpjwyiZePQg@mail.gmail.com>

And this is the commit that did this:
https://git.phytec.de/meta-phytec/commit/conf/layer.conf?id=8261e896d2b43211e7377feb38e919336d47c39f

Shame on you, phytec. Shame on you. What you do in your layers perhaps
doesn't matter so much, but you also give everyone a bad example to
follow.

Alex

On Thu, 1 Dec 2022 at 08:47, Martin Jansa <Martin.Jansa@gmail.com> wrote:
>
> Agreed with Rudolf.
>
> If the layer maintainer didn't bother to do at least do one build with new release and adjust LAYERSERIES_COMPAT, then I don't consider that layer well maintained (it could be someone else who uses the layer, tests it with new release and sends PR to adjust LAYERSERIES_COMPAT).
>
> Recently I've also seen this:
> LAYERSERIES_COMPAT_phytec = "${LAYERSERIES_COMPAT_core}"
>
> which is also bad as it completely disables the check (seen in https://git.phytec.de/meta-phytec/tree/conf/layer.conf#n14).
>
> On Thu, Dec 1, 2022 at 7:06 AM Rudolf J Streif <rudolf.streif@ibeeto.com> wrote:
>>
>>
>>
>> On Wed, Nov 30, 2022, 20:27 Zoran <zoran.stojsavljevic@gmail.com> wrote:
>>>
>>> Hello to Yocto community,
>>>
>>> As I am much more passive yocto wise these few years ( working on
>>> Android build systems and around, this is also a nightmare, I should
>>> say ;-) ), I have one Yocto question which I never really understood.
>>>
>>> I will ask it by example. I have one layer for the CAN tools and apps
>>> which I have created 4 years ago:
>>> https://github.com/ZoranStojsavljevic/meta-socketcan
>>>
>>> In there, in conf/layer.conf:
>>> https://github.com/ZoranStojsavljevic/meta-socketcan/blob/master/conf/layer.conf
>>>
>>> I have the following line (layers' compatibility):
>>> LAYERSERIES_COMPAT_meta-socketcan = "sumo thud warrior zeus dunfell
>>> gatesgarth hardknott honister kirkstone"
>>>
>>> I do not understand why we need to explicitly name releases for such
>>> simple generic layers?!
>>
>>
>> To me this indicates that the maintainer of the layer has tested the compatibility of his layer with all of these releases of the Yocto Project.
>>
>> A maintainer of a layer should make a deliberate decision of adding a release or dropping one from the compatibility list. It should be an attestation that the layer's compatibility with the releases in the list is actually maintained and tested.
>>
>> There have been changes to the syntax to conditional variables. Your layer might well be compatible with all of the releases and it's great if you tested it. But it's not a given.
>>>
>>>
>>> Instead, for a virtual example:
>>> LAYERSERIES_COMPAT_meta-socketcan = "${AUTOLAYER x}"
>>>
>>> So all the layers might be included (or for at least lets say x = 4
>>> latest releases, where x = 0 would be include all)? I do understand
>>> that complex layers could NOT have such a definition (because of the
>>> dependencies), but for the generic layers (as such presented), this
>>> would be beneficial.
>>
>>
>> I never cared for ${AUTOREV}, which is similar, in the first place for the very reason that it creates inconsistent behavior. This would do the same thing. What would the last 4 releases even mean? What is the reference and where is it obtained from?
>>>
>>>
>>> Thank you for the answers,
>>> Zee
>>>
>>> _______
>>
>>
>> Best,
>> :rjs
>>>
>>>
>>>
>>>
>>
>>
>>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#58691): https://lists.yoctoproject.org/g/yocto/message/58691
> Mute This Topic: https://lists.yoctoproject.org/mt/95375670/1686489
> Group Owner: yocto+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


  reply	other threads:[~2022-12-01 10:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01  4:27 LAYERSERIES_COMPAT_ variable in the layer's recipe Zoran Stojsavljevic
2022-12-01  6:06 ` [yocto] " Rudolf Streif
2022-12-01  7:46   ` Martin Jansa
2022-12-01 10:09     ` Alexander Kanavin [this message]
2022-12-01 10:41       ` Richard Purdie
2022-12-09 11:20       ` Stefan Müller-Klieser
2022-12-01 16:41     ` Rudolf J Streif
2022-12-01 17:01       ` Alexander Kanavin
2022-12-01 18:32         ` Zoran Stojsavljevic
2022-12-01 11:09 ` Ross Burton
2022-12-01 11:17   ` Martin Jansa
2022-12-01 12:46     ` Zoran Stojsavljevic
2022-12-01 12:48       ` Ross Burton
2022-12-01 13:01         ` Zoran Stojsavljevic
2022-12-01 12:38   ` Zoran Stojsavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANNYZj8uXJ189UckEVktdEuRgLpAcn+driQqnxj0KLaGYSU=wQ@mail.gmail.com' \
    --to=alex.kanavin@gmail.com \
    --cc=Martin.Jansa@gmail.com \
    --cc=n.wesp@phytec.de \
    --cc=rudolf.streif@ibeeto.com \
    --cc=s.mueller-klieser@phytec.de \
    --cc=yocto@lists.yoctoproject.org \
    --cc=zoran.stojsavljevic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.