Re: [bitbake-devel] [PATCH 2/2] fetch2: Fix race condition in latest_revision

[Alexander Kanavin <alex.kanavin@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1611 bytes --]

It helps if you can provide a specific example/test case for this.

Alex

On Mon, 8 Nov 2021 at 11:26, Martin Koppehel <martin@mko.dev> wrote:

> -- snip
> > I'm afraid I don't understand why this is a race condition? Where is the
> timeout
> > that stops one being set?
>
> The commit message is misleading here, will change that. It is actually
> not a race condition as we originally thought, but more a problem of
> recursive calls to _latest_revision.
>
> The git fetcher does something similar in _lsremote, where the git
> lsremote would be called recursively to populate the environment, and
> there's code in place to prevent that.
>
> In our case, since we persist the revs, we have to filter out empty revs
> because otherwise the next repo fetcher invocation would also try to
> populate the environment but then revs[key] would already be set to an
> empty string, causing a metadata mismatch later.
>
> Therefore we only populate the revision cache if _latest_revision
> actually returns a valid value.
> We did reproduce this with multiple recipes that used up the same
> SRC_URI and therefore influencing each other, this case works fine now.
>
> Cheers,
> Martin
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#12933):
> https://lists.openembedded.org/g/bitbake-devel/message/12933
> Mute This Topic: https://lists.openembedded.org/mt/86840265/1686489
> Group Owner: bitbake-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 2500 bytes --]