All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alexander Kanavin" <alex.kanavin@gmail.com>
To: Andre McCurdy <armccurdy@gmail.com>
Cc: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
	Konrad Weihmann <kweihmann@outlook.com>,
	 OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] pypi: set SRC_URI with =, not with +=
Date: Thu, 24 Jun 2021 10:28:32 +0200	[thread overview]
Message-ID: <CANNYZj9dGnOrZPC8i5mA706BLMMNsgu-5+huje230WH9G+EXQQ@mail.gmail.com> (raw)
In-Reply-To: <CAJ86T=WnCZ9pFtejfiNOe5TVzu3niRiaRPoGLfEJX9hC99Q2bQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

On Thu, 24 Jun 2021 at 09:21, Andre McCurdy <armccurdy@gmail.com> wrote:

> On Wed, Jun 23, 2021 at 3:18 AM Alexander Kanavin
> <alex.kanavin@gmail.com> wrote:
> >
> > Frankly guys, I think maybe we should just break stuff in this case, and
> have it fixed up properly, then try to guess what workaround might work.
> >
> > From that perspective the original patch is the most clear.
>
> The typical ordering of variables etc in recipes is to put SRC_URI
> before inherit.
>
> From the perspective of trying to get recipes to stick to a standard
> ordering of variables etc, _prepend seems to be the best solution.
>

That's fine with me, we should probably fix up gnomebase.bbclass as well,
as using = there adds friction to how SRC_URI must be set in the recipes.

Alex

[-- Attachment #2: Type: text/html, Size: 1265 bytes --]

      reply	other threads:[~2021-06-24  8:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 19:27 [PATCH] pypi: set SRC_URI with =, not with += Alexander Kanavin
2021-06-23  7:01 ` Konrad Weihmann
2021-06-23  8:34   ` [OE-core] " Alexander Kanavin
2021-06-23  9:26     ` Peter Kjellerstedt
2021-06-23 10:17       ` Alexander Kanavin
2021-06-24  7:21         ` Andre McCurdy
2021-06-24  8:28           ` Alexander Kanavin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANNYZj9dGnOrZPC8i5mA706BLMMNsgu-5+huje230WH9G+EXQQ@mail.gmail.com \
    --to=alex.kanavin@gmail.com \
    --cc=armccurdy@gmail.com \
    --cc=kweihmann@outlook.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.kjellerstedt@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.