All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kanavin <alex.kanavin@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] rust: Disable 64bit atomics on crossbeam on riscv32
Date: Fri, 21 Oct 2022 08:03:54 +0200	[thread overview]
Message-ID: <CANNYZj_-7o3VNCONa1sTgscrWOZtSKy6iB1mL6pOT40wt5fTow@mail.gmail.com> (raw)
In-Reply-To: <20221020223004.1665512-1-raj.khem@gmail.com>

We carry this patch, so that manual per-target fixups like this are
not needed, and crossbeam's internal lists are used properly:

https://git.yoctoproject.org/poky/tree/meta/recipes-devtools/rust/rust/crossbeam_atomic.patch?h=master-next&id=f4fe7cdaa7fc5785c55bd507c897f4d25d43cffa

Is it not working somehow? Does the list itself need to be fixed?

Alex

On Fri, 21 Oct 2022 at 00:30, Khem Raj <raj.khem@gmail.com> wrote:
>
> riscv32 builds fail since AtomicI64 is not available in sync::atomic for
> this architecture. Therefore it needs to be opted out and the way out is
> to pass it by RUSTFLAGS, however rust target recipe overrides RUSTFLAGS
> before exporting it so its better to piggy back on the variable its
> using which is RUST_DEBUG_REMAP
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-devtools/rust/rust_1.64.0.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-devtools/rust/rust_1.64.0.bb b/meta/recipes-devtools/rust/rust_1.64.0.bb
> index 1f9dbd3cce..b05f188d9c 100644
> --- a/meta/recipes-devtools/rust/rust_1.64.0.bb
> +++ b/meta/recipes-devtools/rust/rust_1.64.0.bb
> @@ -9,6 +9,7 @@ FILES:${PN}-dev = ""
>
>  # Used by crossbeam_atomic.patch
>  export TARGET_VENDOR
> +RUST_DEBUG_REMAP:append:riscv32 = " --cfg crossbeam_no_atomic_64"
>
>  do_compile () {
>      rust_runx build --stage 2
> --
> 2.38.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#172006): https://lists.openembedded.org/g/openembedded-core/message/172006
> Mute This Topic: https://lists.openembedded.org/mt/94464934/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


  reply	other threads:[~2022-10-21  6:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20 22:30 [PATCH] rust: Disable 64bit atomics on crossbeam on riscv32 Khem Raj
2022-10-21  6:03 ` Alexander Kanavin [this message]
2022-10-21 14:05   ` [OE-core] " Khem Raj
2022-10-21 15:41     ` Alexander Kanavin
2022-10-21 16:06       ` Khem Raj
2022-10-21 16:18         ` Alexander Kanavin
2022-10-21 16:59           ` Khem Raj
2022-10-21 17:12             ` Alexander Kanavin
2022-10-21 17:16               ` Khem Raj
2022-10-21 17:28                 ` Alexander Kanavin
2022-10-21 20:10                   ` Khem Raj
2022-10-22 19:56 ` Alexander Kanavin
     [not found] ` <17207C5BC457528C.2993@lists.openembedded.org>
2022-10-25 16:15   ` Alexander Kanavin
2022-10-26  0:45     ` Khem Raj
2022-10-26  7:58       ` Alexander Kanavin
2022-10-26 13:12         ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANNYZj_-7o3VNCONa1sTgscrWOZtSKy6iB1mL6pOT40wt5fTow@mail.gmail.com \
    --to=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.