Re: [PATCH 1/5] libva: Split out the base parts into an include file

From: Alexander Kanavin <alex.kanavin@gmail.com>
To: "Böszörményi Zoltán" <zboszor@pr.hu>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/5] libva: Split out the base parts into an include file
Date: Wed, 26 Feb 2020 17:08:10 +0100	[thread overview]
Message-ID: <CANNYZj_-CwN4oikVz78dhrq272rGM+xSVRG-FKYu4Efse+J=gQ@mail.gmail.com> (raw)
In-Reply-To: <20200226135716.49255-1-zboszor@pr.hu>

[-- Attachment #1: Type: text/plain, Size: 4356 bytes --]

Don't version the .inc please, this will break automated version updates.

Alex

On Wed, 26 Feb 2020 at 15:08, Böszörményi Zoltán via Openembedded-core <
openembedded-core@lists.openembedded.org> wrote:

> Signed-off-by: Böszörményi Zoltán <zboszor@pr.hu>
> ---
>  meta/recipes-graphics/libva/libva-2.6.1.inc | 30 ++++++++++++++++++++
>  meta/recipes-graphics/libva/libva_2.6.1.bb  | 31 ++-------------------
>  2 files changed, 32 insertions(+), 29 deletions(-)
>  create mode 100644 meta/recipes-graphics/libva/libva-2.6.1.inc
>
> diff --git a/meta/recipes-graphics/libva/libva-2.6.1.inc
> b/meta/recipes-graphics/libva/libva-2.6.1.inc
> new file mode 100644
> index 0000000000..ca1386d80b
> --- /dev/null
> +++ b/meta/recipes-graphics/libva/libva-2.6.1.inc
> @@ -0,0 +1,30 @@
> +SUMMARY = "Video Acceleration (VA) API for Linux"
> +DESCRIPTION = "Video Acceleration API (VA API) is a library (libVA) \
> +and API specification which enables and provides access to graphics \
> +hardware (GPU) acceleration for video processing on Linux and UNIX \
> +based operating systems. Accelerated processing includes video \
> +decoding, video encoding, subpicture blending and rendering. The \
> +specification was originally designed by Intel for its GMA (Graphics \
> +Media Accelerator) series of GPU hardware, the API is however not \
> +limited to GPUs or Intel specific hardware, as other hardware and \
> +manufacturers can also freely use this API for hardware accelerated \
> +video decoding."
> +
> +HOMEPAGE = "https://01.org/linuxmedia/vaapi"
> +BUGTRACKER = "https://github.com/intel/libva/issues"
> +
> +SECTION = "x11"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=2e48940f94acb0af582e5ef03537800f"
> +
> +SRC_URI = "
> https://github.com/intel/${BPN}/releases/download/${PV}/${BP}.tar.bz2"
> +SRC_URI[md5sum] = "aef13eb48e01a47d1416d97462a22a11"
> +SRC_URI[sha256sum] =
> "6c57eb642d828af2411aa38f55dc10111e8c98976dbab8fd62e48629401eaea5"
> +
> +UPSTREAM_CHECK_URI = "https://github.com/intel/libva/releases"
> +
> +DEPENDS = "libdrm"
> +
> +inherit meson pkgconfig features_check
> +
> +REQUIRED_DISTRO_FEATURES = "opengl"
> diff --git a/meta/recipes-graphics/libva/libva_2.6.1.bb
> b/meta/recipes-graphics/libva/libva_2.6.1.bb
> index 92cea83bc1..af4c1c98ab 100644
> --- a/meta/recipes-graphics/libva/libva_2.6.1.bb
> +++ b/meta/recipes-graphics/libva/libva_2.6.1.bb
> @@ -1,33 +1,6 @@
> -SUMMARY = "Video Acceleration (VA) API for Linux"
> -DESCRIPTION = "Video Acceleration API (VA API) is a library (libVA) \
> -and API specification which enables and provides access to graphics \
> -hardware (GPU) acceleration for video processing on Linux and UNIX \
> -based operating systems. Accelerated processing includes video \
> -decoding, video encoding, subpicture blending and rendering. The \
> -specification was originally designed by Intel for its GMA (Graphics \
> -Media Accelerator) series of GPU hardware, the API is however not \
> -limited to GPUs or Intel specific hardware, as other hardware and \
> -manufacturers can also freely use this API for hardware accelerated \
> -video decoding."
> +require libva-${PV}.inc
>
> -HOMEPAGE = "https://01.org/linuxmedia/vaapi"
> -BUGTRACKER = "https://github.com/intel/libva/issues"
> -
> -SECTION = "x11"
> -LICENSE = "MIT"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=2e48940f94acb0af582e5ef03537800f"
> -
> -SRC_URI = "
> https://github.com/intel/${BPN}/releases/download/${PV}/${BP}.tar.bz2"
> -SRC_URI[md5sum] = "aef13eb48e01a47d1416d97462a22a11"
> -SRC_URI[sha256sum] =
> "6c57eb642d828af2411aa38f55dc10111e8c98976dbab8fd62e48629401eaea5"
> -
> -UPSTREAM_CHECK_URI = "https://github.com/intel/libva/releases"
> -
> -DEPENDS = "libdrm virtual/mesa"
> -
> -inherit meson pkgconfig features_check
> -
> -REQUIRED_DISTRO_FEATURES = "opengl"
> +DEPENDS += "virtual/mesa"
>
>  PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'wayland x11',
> d)}"
>  PACKAGECONFIG[x11] = "-Dwith_x11=yes, -Dwith_x11=no,virtual/libx11
> libxext libxfixes"
> --
> 2.24.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 6515 bytes --]