All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alexander Kanavin" <alex.kanavin@gmail.com>
To: wangmy <wangmy@fujitsu.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] elfutils: upgrade 0.183 -> 0.184
Date: Tue, 18 May 2021 11:40:27 +0200	[thread overview]
Message-ID: <CANNYZj_3u5AWuKB_fFS+-=iWUNn6ZTYZwt-BwexTD10dYbgvDA@mail.gmail.com> (raw)
In-Reply-To: <1621302185-15385-1-git-send-email-wangmy@fujitsu.com>

[-- Attachment #1: Type: text/plain, Size: 1644 bytes --]

On Tue, 18 May 2021 at 03:43, wangmy <wangmy@fujitsu.com> wrote:

> -@@ -263,7 +263,7 @@ debuginfod_clean_cache(debuginfod_client *c,
> -       if (interval_file == NULL)
> -         return -errno;
> -
> --      int rc = fprintf(interval_file, "%ld",
> cache_clean_default_interval_s);
> -+      int rc = fprintf(interval_file, "%jd",
> (intmax_t)cache_clean_default_interval_s);
> -       fclose(interval_file);
> -
> -       if (rc < 0)
> -@@ -275,7 +275,7 @@ debuginfod_clean_cache(debuginfod_client *c,
> -   interval_file = fopen(interval_path, "r");
> -   if (interval_file)
> -     {
> --      if (fscanf(interval_file, "%ld", &clean_interval) != 1)
> -+      if (fscanf(interval_file, "%jd", (intmax_t*)(&clean_interval)) !=
> 1)
> -         clean_interval = cache_clean_default_interval_s;
> -       fclose(interval_file);
> -     }
> -@@ -291,7 +291,7 @@ debuginfod_clean_cache(debuginfod_client *c,
> -   max_unused_file = fopen(max_unused_path, "r");
> -   if (max_unused_file)
> -     {
> --      if (fscanf(max_unused_file, "%ld", &max_unused_age) != 1)
> -+      if (fscanf(max_unused_file, "%jd", (intmax_t*)(&max_unused_age))
> != 1)
> -         max_unused_age = cache_default_max_unused_age_s;
> -       fclose(max_unused_file);
> -     }
>

I think this cannot be removed, it needs to be rebased (e.g. using 'devtool
upgrade') - the problem is still there, it just moved to different
functions:
https://sourceware.org/git/?p=elfutils.git;a=blob;f=debuginfod/debuginfod-client.c;h=ee7eda24df9f672eb291663cc35fb4b945ad70f5;hb=HEAD#l217

Can you try a x32 build to check please?

Alex

[-- Attachment #2: Type: text/html, Size: 2381 bytes --]

  reply	other threads:[~2021-05-18  9:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  1:43 [OE-core] [PATCH] elfutils: upgrade 0.183 -> 0.184 wangmy
2021-05-18  9:40 ` Alexander Kanavin [this message]
2021-05-20  8:49   ` wangmy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANNYZj_3u5AWuKB_fFS+-=iWUNn6ZTYZwt-BwexTD10dYbgvDA@mail.gmail.com' \
    --to=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=wangmy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.