From: "Alexander Kanavin" <alex.kanavin@gmail.com>
To: Michael Opdenacker <michael.opdenacker@bootlin.com>
Cc: Khem Raj <raj.khem@gmail.com>,
OE-core <openembedded-core@lists.openembedded.org>,
YP docs mailing list <docs@lists.yoctoproject.org>
Subject: Re: [docs] [OE-core] [PATCH] musl: Set UPSTREAM_CHECK_COMMITS
Date: Mon, 14 Jun 2021 15:17:51 +0200 [thread overview]
Message-ID: <CANNYZj_3wjJSczi0pNAoHxhGF=TmyH9Tgz0nR3GR1TdY0Qrv2w@mail.gmail.com> (raw)
In-Reply-To: <8825b363-ef7b-626c-908b-a2c6405410ff@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]
That would be very useful, but you should check if the entire nomenclature
of UPSTREAM_CHECK_* variables is documented as well
(_COMMITS, _REGEX, _URI, _GITTAGREGEX).
Alex
On Mon, 14 Jun 2021 at 15:12, Michael Opdenacker <
michael.opdenacker@bootlin.com> wrote:
> Hi Khem
>
> On 6/13/21 12:10 AM, Khem Raj wrote:
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > meta/recipes-core/musl/musl_git.bb | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/recipes-core/musl/musl_git.bb
> b/meta/recipes-core/musl/musl_git.bb
> > index 6569d1b37b..bd9d5f1d4b 100644
> > --- a/meta/recipes-core/musl/musl_git.bb
> > +++ b/meta/recipes-core/musl/musl_git.bb
> > @@ -84,3 +84,5 @@ RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"
> > LEAD_SONAME = "libc.so"
> > INSANE_SKIP_${PN}-dev = "staticdev"
> > INSANE_SKIP_${PN} = "libdir"
> > +
> > +UPSTREAM_CHECK_COMMITS = "1"
>
>
> Thanks for the patch.
> Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>
> I realize that the UPSTREAM_CHECK_COMMITS variable doesn't appear in the
> documentation, and it's in relatively frequent use.
>
> Would it make sense to propose to add a description based on the initial
> commit
> (
> https://git.openembedded.org/openembedded-core/commit/?id=591d57877d3d3e659d78c0ed33f4c515e3f6f8fb
> )?
>
> Thanks in advance,
> Michael.
>
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 2715 bytes --]
next prev parent reply other threads:[~2021-06-14 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 22:10 [PATCH] musl: Set UPSTREAM_CHECK_COMMITS Khem Raj
2021-06-14 13:12 ` [OE-core] " Michael Opdenacker
2021-06-14 13:17 ` Alexander Kanavin [this message]
2021-06-14 16:06 ` [docs] " Michael Opdenacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANNYZj_3wjJSczi0pNAoHxhGF=TmyH9Tgz0nR3GR1TdY0Qrv2w@mail.gmail.com' \
--to=alex.kanavin@gmail.com \
--cc=docs@lists.yoctoproject.org \
--cc=michael.opdenacker@bootlin.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.