Re: [OE-core] [PATCH 4/5] devtool: add support for multiple git url inside a cargo based recipe

[Alexander Kanavin <alex.kanavin@gmail.com>]

I'm fine with v2, except for the zvariant recipe, that should probably
go to meta-rust (which itself should go to meta-oe, with cleanups).

Alex

On Sun, 26 Mar 2023 at 16:58, Frédéric Martinsons
<frederic.martinsons@gmail.com> wrote:
>
> I submit a V2 series where I made modifications you suggested, I choose to use a more
> generic type (git-dependency instead of cargo-dep) since I foresee that could be used also
> for npm based recipe (see https://bugzilla.yoctoproject.org/show_bug.cgi?id=11015)
>
> For the moment, I let the example recipe in oe-core because I don't know where it should
> go (or even if I should keep it or remove it)
>
> On Sun, 26 Mar 2023 at 07:15, Frédéric Martinsons <frederic.martinsons@gmail.com> wrote:
>>
>> Ah, good idea, I'll try that and provide a V2 of this series if it fits.
>>
>> On Sat, 25 Mar 2023 at 20:02, Alexander Kanavin <alex.kanavin@gmail.com> wrote:
>>>
>>> On Sat, 25 Mar 2023 at 10:01, Frederic Martinsons
>>> <frederic.martinsons@gmail.com> wrote:
>>> > @@ -72,6 +73,8 @@ python () {
>>> >                      url_data.type == 'npmsw' or url_data.type == 'crate' or
>>> >                      'type' in parm and parm['type'] == 'kmeta'):
>>> >                  local_srcuri.append(url)
>>> > +            if url in cargo_git_deps:
>>> > +                local_srcuri.append(url)
>>>
>>> Come to think of it, it's better to use the same type parameter with a
>>> special value as in kernel recipes:
>>>
>>> git://.....;type=cargo-dep;...
>>>
>>> This would avoid the ugly special variable.
>>>
>>> Alex