From: Alexander Kanavin <alex.kanavin@gmail.com>
To: Quentin Schulz <quentin.schulz@streamunlimited.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] package.bbclass: allow shell-style wildcards in PRIVATE_LIBS
Date: Wed, 4 Sep 2019 16:52:10 +0200 [thread overview]
Message-ID: <CANNYZj_N9hz-mwKPofSUY7Lrf-L9B2Ep+z1sbCcL9wdhtBP0Gw@mail.gmail.com> (raw)
In-Reply-To: <20190904125538.c6f6mz6cwcz56ebr@qschulz>
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
On Wed, 4 Sep 2019 at 14:55, Quentin Schulz <
quentin.schulz@streamunlimited.com> wrote:
> So we just need to invert the logic actually.
>
> matched = False
> for pattern in private_libs:
> if fnmatch.fnmatch(this_soname, pattern)]) == 0:
> matched = True
> break
>
> if not matched:
> sonames.add(prov)
>
I think you are looking for the "for...else" feature in Python :) Still,
the original code is not adding any lines at all while yours adds eight so
I'd just keep the patch as it is.
Alex
[-- Attachment #2: Type: text/html, Size: 938 bytes --]
next prev parent reply other threads:[~2019-09-04 14:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 16:32 [PATCH] package.bbclass: allow shell-style wildcards in PRIVATE_LIBS Alexander Kanavin
2019-09-04 7:32 ` Quentin Schulz
2019-09-04 10:04 ` Alexander Kanavin
2019-09-04 10:11 ` Alexander Kanavin
2019-09-04 12:55 ` Quentin Schulz
2019-09-04 14:52 ` Alexander Kanavin [this message]
2019-09-04 14:57 ` Quentin Schulz
2019-09-04 15:08 ` Alexander Kanavin
2019-09-06 10:22 Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANNYZj_N9hz-mwKPofSUY7Lrf-L9B2Ep+z1sbCcL9wdhtBP0Gw@mail.gmail.com \
--to=alex.kanavin@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=quentin.schulz@streamunlimited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.