[PATCH 1/2] boost: switch over to sourceforge

[PATCH 1/2] boost: switch over to sourceforge

[Andrew Geissler]

dl.binary has a monthly download limit. The issue is documented in
https://github.com/boostorg/boost/issues/299

Yocto has backup/caching for issues like this but it's best to not
contribute to that download limit if the same file is hosted over
at sourceforge.

Signed-off-by: Andrew Geissler <geissonator@gmail.com>
---
 meta/recipes-support/boost/boost-1.72.0.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/boost/boost-1.72.0.inc b/meta/recipes-support/boost/boost-1.72.0.inc
index 55a095bf1c..3a7ea2c06e 100644
--- a/meta/recipes-support/boost/boost-1.72.0.inc
+++ b/meta/recipes-support/boost/boost-1.72.0.inc
@@ -11,7 +11,7 @@ BOOST_VER = "${@"_".join(d.getVar("PV").split("."))}"
 BOOST_MAJ = "${@"_".join(d.getVar("PV").split(".")[0:2])}"
 BOOST_P = "boost_${BOOST_VER}"
 
-SRC_URI = "https://dl.bintray.com/boostorg/release/${PV}/source/${BOOST_P}.tar.bz2"
+SRC_URI = "${SOURCEFORGE_MIRROR}/project/boost/boost/${PV}/${BOOST_P}.tar.bz2"
 SRC_URI[md5sum] = "cb40943d2a2cb8ce08d42bc48b0f84f0"
 SRC_URI[sha256sum] = "59c9b274bc451cf91a9ba1dd2c7fdcaf5d60b1b3aa83f2c9fa143417cc660722"
 
-- 
2.21.0 (Apple Git-122)

[PATCH 2/2] boost: revert 1.72.0 regression

[Andrew Geissler]

https://www.boost.org/users/history/version_1_72_0.html documents a
"Known Issue" and has a revert patch for an issue that causes code to
fail to compile that includes the coroutine function. Without this
patch, code which includes the asymmetric_coroutine.hpp will fail to
compile.

Signed-off-by: Andrew Geissler <geissonator@gmail.com>
---
 meta/recipes-support/boost/boost_1.72.0.bb    |  1 +
 ...001-revert-cease-dependence-on-range.patch | 49 +++++++++++++++++++
 2 files changed, 50 insertions(+)
 create mode 100644 meta/recipes-support/boost/files/0001-revert-cease-dependence-on-range.patch

diff --git a/meta/recipes-support/boost/boost_1.72.0.bb b/meta/recipes-support/boost/boost_1.72.0.bb
index 5e9e0d87d7..0b7badbc76 100644
--- a/meta/recipes-support/boost/boost_1.72.0.bb
+++ b/meta/recipes-support/boost/boost_1.72.0.bb
@@ -7,4 +7,5 @@ SRC_URI += "file://arm-intrinsics.patch \
            file://0001-Apply-boost-1.62.0-no-forced-flags.patch.patch \
            file://0001-Don-t-set-up-arch-instruction-set-flags-we-do-that-o.patch \
            file://0001-dont-setup-compiler-flags-m32-m64.patch \
+           file://0001-revert-cease-dependence-on-range.patch \
            "
diff --git a/meta/recipes-support/boost/files/0001-revert-cease-dependence-on-range.patch b/meta/recipes-support/boost/files/0001-revert-cease-dependence-on-range.patch
new file mode 100644
index 0000000000..a6002074ab
--- /dev/null
+++ b/meta/recipes-support/boost/files/0001-revert-cease-dependence-on-range.patch
@@ -0,0 +1,49 @@
+From 436e1dbe6fcd31523d261d18ad011392f1d6fbbc Mon Sep 17 00:00:00 2001
+From: Oliver Kowalke <oliver.kowalke@gmail.com>
+Date: Sun, 1 Dec 2019 20:40:28 +0100
+Subject: [PATCH] Revert "Cease dependence on Range"
+
+This reverts commit 0c556bb59241e682bbcd3f572815149c5a9b17db.
+
+see #44 (One test fails to compile after boostorg/coroutine submodule updated)
+---
+ boost/coroutine/asymmetric_coroutine.hpp | 12 +++---------
+ 1 file changed, 3 insertions(+), 9 deletions(-)
+
+diff --git a/boost/coroutine/asymmetric_coroutine.hpp b/boost/coroutine/asymmetric_coroutine.hpp
+index ea96981..640896f 100644
+--- a/boost/coroutine/asymmetric_coroutine.hpp
++++ b/boost/coroutine/asymmetric_coroutine.hpp
+@@ -14,6 +14,7 @@
+ #include <boost/assert.hpp>
+ #include <boost/config.hpp>
+ #include <boost/move/move.hpp>
++#include <boost/range.hpp>
+ #include <boost/throw_exception.hpp>
+ #include <boost/utility/explicit_operator_bool.hpp>
+ 
+@@ -2354,19 +2355,12 @@ end( push_coroutine< R > & c)
+ 
+ }
+ 
+-// forward declaration of Boost.Range traits to break dependency on it
+-template<typename C, typename Enabler>
+-struct range_mutable_iterator;
+-
+-template<typename C, typename Enabler>
+-struct range_const_iterator;
+-
+ template< typename Arg >
+-struct range_mutable_iterator< coroutines::push_coroutine< Arg >, void >
++struct range_mutable_iterator< coroutines::push_coroutine< Arg > >
+ { typedef typename coroutines::push_coroutine< Arg >::iterator type; };
+ 
+ template< typename R >
+-struct range_mutable_iterator< coroutines::pull_coroutine< R >, void >
++struct range_mutable_iterator< coroutines::pull_coroutine< R > >
+ { typedef typename coroutines::pull_coroutine< R >::iterator type; };
+ 
+ }
+-- 
+2.24.1
+
-- 
2.21.0 (Apple Git-122)

Re: [OE-core] [PATCH 2/2] boost: revert 1.72.0 regression

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 3738 bytes --]

The patch needs an Upstream-Status. Is it a backport (then the link to repo
needs to be provided)?

Alex

On Tue, 21 Apr 2020 at 18:12, Andrew Geissler <geissonator@gmail.com> wrote:

> https://www.boost.org/users/history/version_1_72_0.html documents a
> "Known Issue" and has a revert patch for an issue that causes code to
> fail to compile that includes the coroutine function. Without this
> patch, code which includes the asymmetric_coroutine.hpp will fail to
> compile.
>
> Signed-off-by: Andrew Geissler <geissonator@gmail.com>
> ---
>  meta/recipes-support/boost/boost_1.72.0.bb    |  1 +
>  ...001-revert-cease-dependence-on-range.patch | 49 +++++++++++++++++++
>  2 files changed, 50 insertions(+)
>  create mode 100644
> meta/recipes-support/boost/files/0001-revert-cease-dependence-on-range.patch
>
> diff --git a/meta/recipes-support/boost/boost_1.72.0.bb
> b/meta/recipes-support/boost/boost_1.72.0.bb
> index 5e9e0d87d7..0b7badbc76 100644
> --- a/meta/recipes-support/boost/boost_1.72.0.bb
> +++ b/meta/recipes-support/boost/boost_1.72.0.bb
> @@ -7,4 +7,5 @@ SRC_URI += "file://arm-intrinsics.patch \
>             file://0001-Apply-boost-1.62.0-no-forced-flags.patch.patch \
>
> file://0001-Don-t-set-up-arch-instruction-set-flags-we-do-that-o.patch \
>             file://0001-dont-setup-compiler-flags-m32-m64.patch \
> +           file://0001-revert-cease-dependence-on-range.patch \
>             "
> diff --git
> a/meta/recipes-support/boost/files/0001-revert-cease-dependence-on-range.patch
> b/meta/recipes-support/boost/files/0001-revert-cease-dependence-on-range.patch
> new file mode 100644
> index 0000000000..a6002074ab
> --- /dev/null
> +++
> b/meta/recipes-support/boost/files/0001-revert-cease-dependence-on-range.patch
> @@ -0,0 +1,49 @@
> +From 436e1dbe6fcd31523d261d18ad011392f1d6fbbc Mon Sep 17 00:00:00 2001
> +From: Oliver Kowalke <oliver.kowalke@gmail.com>
> +Date: Sun, 1 Dec 2019 20:40:28 +0100
> +Subject: [PATCH] Revert "Cease dependence on Range"
> +
> +This reverts commit 0c556bb59241e682bbcd3f572815149c5a9b17db.
> +
> +see #44 (One test fails to compile after boostorg/coroutine submodule
> updated)
> +---
> + boost/coroutine/asymmetric_coroutine.hpp | 12 +++---------
> + 1 file changed, 3 insertions(+), 9 deletions(-)
> +
> +diff --git a/boost/coroutine/asymmetric_coroutine.hpp
> b/boost/coroutine/asymmetric_coroutine.hpp
> +index ea96981..640896f 100644
> +--- a/boost/coroutine/asymmetric_coroutine.hpp
> ++++ b/boost/coroutine/asymmetric_coroutine.hpp
> +@@ -14,6 +14,7 @@
> + #include <boost/assert.hpp>
> + #include <boost/config.hpp>
> + #include <boost/move/move.hpp>
> ++#include <boost/range.hpp>
> + #include <boost/throw_exception.hpp>
> + #include <boost/utility/explicit_operator_bool.hpp>
> +
> +@@ -2354,19 +2355,12 @@ end( push_coroutine< R > & c)
> +
> + }
> +
> +-// forward declaration of Boost.Range traits to break dependency on it
> +-template<typename C, typename Enabler>
> +-struct range_mutable_iterator;
> +-
> +-template<typename C, typename Enabler>
> +-struct range_const_iterator;
> +-
> + template< typename Arg >
> +-struct range_mutable_iterator< coroutines::push_coroutine< Arg >, void >
> ++struct range_mutable_iterator< coroutines::push_coroutine< Arg > >
> + { typedef typename coroutines::push_coroutine< Arg >::iterator type; };
> +
> + template< typename R >
> +-struct range_mutable_iterator< coroutines::pull_coroutine< R >, void >
> ++struct range_mutable_iterator< coroutines::pull_coroutine< R > >
> + { typedef typename coroutines::pull_coroutine< R >::iterator type; };
> +
> + }
> +--
> +2.24.1
> +
> --
> 2.21.0 (Apple Git-122)
>
> 
>

[-- Attachment #2: Type: text/html, Size: 4998 bytes --]

✗ patchtest: failure for "boost: switch over to sourcefo..." and 1 more

[Patchwork]

== Series Details ==

Series: "boost: switch over to sourcefo..." and 1 more
Revision: 1
URL   : https://patchwork.openembedded.org/series/23826/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             A patch file has been added, but does not have a Signed-off-by tag [test_signed_off_by_presence] 
  Suggested fix    Sign off the added patch file (meta/recipes-support/boost/files/0001-revert-cease-dependence-on-range.patch)

* Issue             Added patch file is missing Upstream-Status in the header [test_upstream_status_presence_format] 
  Suggested fix    Add Upstream-Status: <Valid status> to the header of meta/recipes-support/boost/files/0001-revert-cease-dependence-on-range.patch
  Standard format  Upstream-Status: <Valid status>
  Valid status     Pending, Accepted, Backport, Denied, Inappropriate [reason], Submitted [where]



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH 2/2] boost: revert 1.72.0 regression

[Andrew Geissler]

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

> 
> The patch needs an Upstream-Status. Is it a backport (then the link to
> repo needs to be provided)?

Thanks for the quick review Alexander. My understanding is that boost released 1.72.0 and then found this regression so they provide a link to this patch on their 1.72.0 release page.

Here's a link to the upstream revert commit:
https://github.com/boostorg/coroutine/commit/9c73b2f7c1759a9508ba8780b38dc15f07f1a447

I saw an automated response from patchwork asking for a Signed-off-by tag for the patch but since the upstream commit does not have it, not sure what to do?

[-- Attachment #2: Type: text/html, Size: 625 bytes --]

Re: [OE-core] [PATCH 2/2] boost: revert 1.72.0 regression

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

You need to sign-off the patch as yourself. Upstream-Status: should be
Backport [link to github commit]

Alex

On Tue, 21 Apr 2020 at 21:31, Andrew Geissler <geissonator@gmail.com> wrote:

> The patch needs an Upstream-Status. Is it a backport (then the link to
> repo needs to be provided)?
>
> Thanks for the quick review Alexander. My understanding is that boost
> released 1.72.0 and then found this regression so they provide a link to
> this patch on their 1.72.0 release page.
>
> Here's a link to the upstream revert commit:
>
> https://github.com/boostorg/coroutine/commit/9c73b2f7c1759a9508ba8780b38dc15f07f1a447
>
> I saw an automated response from patchwork asking for a Signed-off-by tag
> for the patch but since the upstream commit does not have it, not sure what
> to do? 
>

[-- Attachment #2: Type: text/html, Size: 1250 bytes --]