From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f196.google.com (mail-vk1-f196.google.com [209.85.221.196]) by mx.groups.io with SMTP id smtpd.web12.6233.1591086483508879013 for ; Tue, 02 Jun 2020 01:28:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mCCTyrhZ; spf=pass (domain: gmail.com, ip: 209.85.221.196, mailfrom: alex.kanavin@gmail.com) Received: by mail-vk1-f196.google.com with SMTP id n22so686609vkm.7 for ; Tue, 02 Jun 2020 01:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1Kb3gtJbumWJSmCPZhMGQVepqY33VbWLFOBNm0B3GAU=; b=mCCTyrhZU8RGZk6wIRlVNKhgPFBcKaof36rARyDerxA1xZh2c+EkSLY0tz5+gL+z7W 5VABhl7dTDGp7e//bNOY+J8W9/8E/FhmzT7wghlPcCzfYFE3wTu5KkNHqFNSND1q3QcJ mvYget5RXMYvmSe3MxSCZNVZliUML02LVF8lmcgna3U7GtqCvXg74RhyExf8dLgiz1SO Zvdm2c7oLfcNYdD7AYNpdFPssQRTMAXNZ8U12yfPUKCc6fdhiP/kKEirPp2xx0RE5Z96 oe/MeFpgc+EXc23h8+CIADK/HfJWPI8R8/7Yb39QLiV2pRrVv2VMrIx6wWETDh3zHxWu WXzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1Kb3gtJbumWJSmCPZhMGQVepqY33VbWLFOBNm0B3GAU=; b=H61uPWh3duaDo4oo90bifqSu2SAAtdigJJrDFrqprWjAPP8ZnWVCFDd+FkPJqtppMj bYqouWjvmZyvw1ER9A6BZpEqlVug7MC5Bh2j4ksK4O2djUNqZ/yCs960gSZ3Ef2Rf7pd SwsaabktAUR25fvHR+zphBu60u23BstOfOuOYhlT/E3wAMILhnPCi+KJTJTifwJaFgyg Gasc7KCo6l6kQsFQL/9qExl50jgmf4G3A0MSLPkWfxpa4x8mDUj82R/jO8biIxfEwIrN G+m8v+WIwKMtu5n0ezb944vFRLZiAoNCrSc76szeu+ouuNXGhgEyBYUEjEqp9rBrDQlm 8yYg== X-Gm-Message-State: AOAM530SeDGhADu1D06X4w+0W+DsTbItDiFLmXBog3c9V3xI/2Mtqwr6 q1sia2x89VfkxMCk5jD7EYhYIZ5zbKSfnSUseO/Imb94 X-Google-Smtp-Source: ABdhPJwaB79iYC+WrXCN/Gwj/dOrh6WTljasNZg/Xyv/CcPScc+MJ/PJqelcPDewNCjqKRsFfjZbFV88FdV76i4EUTg= X-Received: by 2002:a1f:1bd6:: with SMTP id b205mr12135245vkb.29.1591086482605; Tue, 02 Jun 2020 01:28:02 -0700 (PDT) MIME-Version: 1.0 References: <20200531155254.10283-1-alex.kanavin@gmail.com> <20200531155254.10283-65-alex.kanavin@gmail.com> <77be6de7fa4b447eab96bfb9cc2253d5@XBOX03.axis.com> In-Reply-To: <77be6de7fa4b447eab96bfb9cc2253d5@XBOX03.axis.com> From: "Alexander Kanavin" Date: Tue, 2 Jun 2020 10:27:50 +0200 Message-ID: Subject: Re: [OE-core] [PATCH 65/70] libyaml: adjust license checksum to omit copyright year lines. To: Peter Kjellerstedt Cc: "openembedded-core@lists.openembedded.org" Content-Type: multipart/alternative; boundary="0000000000009a4bf205a715b039" --0000000000009a4bf205a715b039 Content-Type: text/plain; charset="UTF-8" Right, in that case this commit should indeed be dropped or reverted. Alex On Tue, 2 Jun 2020 at 09:39, Peter Kjellerstedt wrote: > If you have COPY_LIC_DIRS enabled, the license files (the ones listed in > LICENSE and the (parts) listed in LIC_FILES_CHKSUM) will be included in > the generated image by license_image.bbclass. Extraction of the license > information is handled by license.bbclass, which also is responsible for > creating ${PN}-lic packages if LICENSE_CREATE_PACKAGE is set. > > > > //Peter > > > > *From:* Alexander Kanavin > *Sent:* den 2 juni 2020 09:30 > *To:* Peter Kjellerstedt > *Cc:* openembedded-core@lists.openembedded.org > *Subject:* Re: [OE-core] [PATCH 65/70] libyaml: adjust license checksum > to omit copyright year lines. > > > > On Tue, 2 Jun 2020 at 00:12, Peter Kjellerstedt < > peter.kjellerstedt@axis.com> wrote: > > > -----Original Message----- > > From: openembedded-core@lists.openembedded.org > core@lists.openembedded.org> On Behalf Of Alexander Kanavin > > Sent: den 31 maj 2020 17:53 > > To: openembedded-core@lists.openembedded.org > > Cc: Alexander Kanavin > > Subject: [OE-core] [PATCH 65/70] libyaml: adjust license checksum to omit > > copyright year lines. > > Eh, what? That's definitely not the right thing to do. For a license > that says "The above copyright notice and this permission notice shall > be included in all copies or substantial portions of the Software.", > removing the copyright information makes the file useless as part of, > e.g., ${PN}-lic. > > > > As far as I understand, the extracts from LIC_FILES_CHKSUM are not used in > copies or substantial portions of the software, > > they are used in tmp/deploy/licenses (which is neither). Is it beneficial > to have the copyright years and owners > > there? The idea behind dropping them is that we can avoid continuous > adjusting of the checksum on version updates. > > > > If you archive the source code, or install binaries to the target, this > mechanism is not involved. > > > > I am not aware of ${PN}-lic, can you please point where that is defined? > > > > Alex > --0000000000009a4bf205a715b039 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Right, in that case this commit should indeed be drop= ped or reverted.

Alex

On Tue, 2 Jun 2020 = at 09:39, Peter Kjellerstedt <peter.kjellerstedt@axis.com> wrote:

= If you have COPY_LIC_DIRS enabled, the license files (the ones listed in LICENSE and= the (parts) listed in LIC_FILES_CHKSUM) will be included in the generated image by license_image.bbclass. Ex= traction of the license information is handled by license.bbclass, which also is re= sponsible for creating ${PN}-lic packages if LICENSE_CREATE_PACKAGE is set.

= =C2=A0

= //Peter

= =C2=A0

From: Alexander Kanavin <alex.kanavin@gmail.com>
Sent: den 2 juni 2020 09:30
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 65/70] libyaml: adjust license checksu= m to omit copyright year lines.

=C2=A0

On Tue, 2 Jun 2020 at 00:12, Peter Kjellerstedt <= peter.kjel= lerstedt@axis.com> wrote:

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@= lists.openembedded.org> On Behalf Of Alexander Kanavin
> Sent: den 31 maj 2020 17:53
> To: openembedded-core@lists.openembedded.org
> Cc: Alexander Kanavin <alex.kanavin@gmail.com>
> Subject: [OE-core] [PATCH 65/70] libyaml: adjust license checksum to o= mit
> copyright year lines.

Eh, what? That's definitely not the right thing to do. For a license that says "The above copyright notice and this permission notice shall=
be included in all copies or substantial portions of the Software.", <= br> removing the copyright information makes the file useless as part of,
e.g., ${PN}-lic.

=C2=A0

As far as I understand, the extracts from LIC_FILES_= CHKSUM are not used in copies or substantial portions of the software,

they are used in tmp/deploy/licenses (which is neith= er). Is it beneficial to have the copyright years and owners<= /p>

there? The idea behind dropping them is that we can = avoid continuous adjusting of the checksum on version updates.

=C2=A0

If you archive the source code, or install binaries = to the target, this mechanism is not involved.

=C2=A0

I am not aware of ${PN}-lic, can you please point wh= ere that is defined?

=C2=A0

Alex

--0000000000009a4bf205a715b039--