From: Grazvydas Ignotas <notasas@gmail.com>
To: Andreas Naumann <dev@andin.de>
Cc: Linux USB Mailing List <linux-usb@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: WG: [PATCH] usb: musb: omap2430: fix occasional musb breakage on boot
Date: Mon, 16 Dec 2013 12:49:04 +0200 [thread overview]
Message-ID: <CANOLnOP6923w_qSeVU4hUDpKtgMzWxA2WevQW=PPUAX_=BWdGQ@mail.gmail.com> (raw)
In-Reply-To: <52AB3589.6010606@andin.de>
On Fri, Dec 13, 2013 at 6:27 PM, Andreas Naumann <dev@andin.de> wrote:
> On 13.12.2013 13:34, Grazvydas Ignotas wrote:
>>
>> Hmm I don't know about that, this would be inconsistent with what all
>> other OMAP drivers do. Maybe we should do what musb_core.c does just
>
> Ok, thats cool.
>
>> to be consistent and add a similar comment. Only the static variable
>> could be avoided in favor of struct omap2430_glue member.
>
> Whats wrong with the static?
Well besides minor memory wastage when the driver is compiled in but
not used, you'd cause problems if TI makes a SoC with multiple musb
instances. Yes this driver already contains global variables, but
still we can avoid adding more easily.
Gražvydas
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-12-16 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <EE4E4767751A8B40949306E403F4DDD8032AA82A@sv03ultra002.ultratronik.de>
[not found] ` <EE4E4767751A8B40949306E403F4DDD8032AA82A-zDU4f0UzlK41cL/Vr7vMjYWky2maIgj/G9Ur7JDdleE@public.gmane.org>
2013-12-12 21:29 ` WG: [PATCH] usb: musb: omap2430: fix occasional musb breakage on boot Andreas Naumann
2013-12-13 12:34 ` Grazvydas Ignotas
2013-12-13 16:27 ` Andreas Naumann
2013-12-16 10:49 ` Grazvydas Ignotas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANOLnOP6923w_qSeVU4hUDpKtgMzWxA2WevQW=PPUAX_=BWdGQ@mail.gmail.com' \
--to=notasas@gmail.com \
--cc=dev@andin.de \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.