From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755766AbaIQPdj (ORCPT ); Wed, 17 Sep 2014 11:33:39 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:42762 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755242AbaIQPdh (ORCPT ); Wed, 17 Sep 2014 11:33:37 -0400 MIME-Version: 1.0 In-Reply-To: <20140917135611.GT24821@kvack.org> References: <20140916214254.GK4322@dastard> <20140917122448.GR24821@kvack.org> <20140917134702.GB10720@thunk.org> <20140917135611.GT24821@kvack.org> Date: Wed, 17 Sep 2014 11:33:35 -0400 Message-ID: Subject: Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances From: Milosz Tanski To: Benjamin LaHaise Cc: "Theodore Ts'o" , Dave Chinner , Jeff Moyer , LKML , Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , linux-aio@kvack.org, Mel Gorman , Volker Lendecke , Tejun Heo Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 17, 2014 at 9:56 AM, Benjamin LaHaise wrote: > On Wed, Sep 17, 2014 at 09:47:02AM -0400, Theodore Ts'o wrote: > ... >> % git version >> git version 2.1.0 >> >> Perhaps you and other people are using your own scripts, and not using >> git send-email? > > That would be because none of my systems have git 2.1.0 on them. Fedora > (and EPEL) appear to still be back on git 1.9.3 which does not have git > send-email. Until that command is more widely propagated, I expect we'll > see people making this mistake every once in a while. > > -ben > -- > "Thought is the essence of where you are now." My workflow has been to use git format-patch (1.7.9.5 was shipped with my distro), edit the cover letter then use and mutt to send the generated emails. Before that I used git apply to import the patches that Christoph sent me. I thought about it too, but hand editing the email generated by format-patch to essentially having me take credit for this sounded like a shady thing to do. The updated version of git's (2.1.0) format-patch doesn't change the from email address field either. The submitting patches document doesn't really describe what to do if you take patches / collaborate with somebody else or how to credit the original author. It only deals with the case of a subsystem maintainers editing the submitters code to fix it up. All that aside, if somebody has a clear workflow that ensures this doesn't happen I'm more then willing to follow it. -- Milosz Tanski CTO 16 East 34th Street, 15th floor New York, NY 10016 p: 646-253-9055 e: milosz@adfin.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Milosz Tanski Subject: Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances Date: Wed, 17 Sep 2014 11:33:35 -0400 Message-ID: References: <20140916214254.GK4322@dastard> <20140917122448.GR24821@kvack.org> <20140917134702.GB10720@thunk.org> <20140917135611.GT24821@kvack.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "Theodore Ts'o" , Dave Chinner , Jeff Moyer , LKML , Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , linux-aio@kvack.org, Mel Gorman , Volker Lendecke , Tejun Heo To: Benjamin LaHaise Return-path: In-Reply-To: <20140917135611.GT24821@kvack.org> Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Sep 17, 2014 at 9:56 AM, Benjamin LaHaise wrote: > On Wed, Sep 17, 2014 at 09:47:02AM -0400, Theodore Ts'o wrote: > ... >> % git version >> git version 2.1.0 >> >> Perhaps you and other people are using your own scripts, and not using >> git send-email? > > That would be because none of my systems have git 2.1.0 on them. Fedora > (and EPEL) appear to still be back on git 1.9.3 which does not have git > send-email. Until that command is more widely propagated, I expect we'll > see people making this mistake every once in a while. > > -ben > -- > "Thought is the essence of where you are now." My workflow has been to use git format-patch (1.7.9.5 was shipped with my distro), edit the cover letter then use and mutt to send the generated emails. Before that I used git apply to import the patches that Christoph sent me. I thought about it too, but hand editing the email generated by format-patch to essentially having me take credit for this sounded like a shady thing to do. The updated version of git's (2.1.0) format-patch doesn't change the from email address field either. The submitting patches document doesn't really describe what to do if you take patches / collaborate with somebody else or how to credit the original author. It only deals with the case of a subsystem maintainers editing the submitters code to fix it up. All that aside, if somebody has a clear workflow that ensures this doesn't happen I'm more then willing to follow it. -- Milosz Tanski CTO 16 East 34th Street, 15th floor New York, NY 10016 p: 646-253-9055 e: milosz@adfin.com -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org