All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maciej Żenczykowski" <maze@google.com>
To: patchwork-bot+netdevbpf@kernel.org, stable@vger.kernel.org
Cc: Riccardo Paolo Bestetti <pbl@bestov.io>,
	Carlos Llamas <cmllamas@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	David Ahern <dsahern@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	kernel-team@android.com,
	Kernel hackers <linux-kernel@vger.kernel.org>,
	Linux NetDev <netdev@vger.kernel.org>,
	Miaohe Lin <linmiaohe@huawei.com>
Subject: Re: [PATCH v2] ipv4: ping: fix bind address validity check
Date: Fri, 17 Jun 2022 16:45:52 -0700	[thread overview]
Message-ID: <CANP3RGcMqXH2+g1=40zwpzbpDORjDpyo4cVYZWS_tfVR8A_6CQ@mail.gmail.com> (raw)
In-Reply-To: <165546541315.12170.9716012665055247467.git-patchwork-notify@kernel.org>

On Fri, Jun 17, 2022 at 4:30 AM <patchwork-bot+netdevbpf@kernel.org> wrote:
>
> Hello:
>
> This patch was applied to netdev/net.git (master)
> by David S. Miller <davem@davemloft.net>:
>
> On Fri, 17 Jun 2022 10:54:35 +0200 you wrote:
> > Commit 8ff978b8b222 ("ipv4/raw: support binding to nonlocal addresses")
> > introduced a helper function to fold duplicated validity checks of bind
> > addresses into inet_addr_valid_or_nonlocal(). However, this caused an
> > unintended regression in ping_check_bind_addr(), which previously would
> > reject binding to multicast and broadcast addresses, but now these are
> > both incorrectly allowed as reported in [1].
> >
> > [...]
>
> Here is the summary with links:
>   - [v2] ipv4: ping: fix bind address validity check
>     https://git.kernel.org/netdev/net/c/b4a028c4d031
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html

I believe this [
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=b4a028c4d031
] needs to end up in 5.17+ LTS (though I guess 5.17 is eol, so
probably just 5.18)

  reply	other threads:[~2022-06-17 23:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17  8:54 [PATCH v2] ipv4: ping: fix bind address validity check Riccardo Paolo Bestetti
2022-06-17 11:30 ` patchwork-bot+netdevbpf
2022-06-17 23:45   ` Maciej Żenczykowski [this message]
2022-06-20 10:11     ` Greg KH
2022-06-23 18:18       ` Maciej Żenczykowski
2022-06-25 14:26         ` Greg KH
2022-06-18  0:32   ` NEEDS FIXING - Was: " Riccardo Paolo Bestetti
2022-06-18  2:58     ` Jakub Kicinski
2022-06-18  7:36       ` Riccardo Paolo Bestetti
2022-06-19 16:44       ` Riccardo Paolo Bestetti
2022-06-17 16:39 ` Carlos Llamas
2022-06-17 18:26   ` Riccardo Paolo Bestetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANP3RGcMqXH2+g1=40zwpzbpDORjDpyo4cVYZWS_tfVR8A_6CQ@mail.gmail.com' \
    --to=maze@google.com \
    --cc=cmllamas@google.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kernel-team@android.com \
    --cc=kuba@kernel.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=patchwork-bot+netdevbpf@kernel.org \
    --cc=pbl@bestov.io \
    --cc=stable@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.