From: "Maciej Żenczykowski" <maze@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux NetDev <netdev@vger.kernel.org>,
Hayes Wang <hayeswang@realtek.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: nt: usb: USB_RTL8153_ECM should not default to y
Date: Mon, 20 Sep 2021 22:19:53 +0200 [thread overview]
Message-ID: <CANP3RGd5Hiwvx1W=UOCY166MUpLP38u5V6=zJR9c=FPAR52ubg@mail.gmail.com> (raw)
In-Reply-To: <20210920121523.7da6f53d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, Sep 20, 2021 at 9:15 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Sat, 18 Sep 2021 12:53:31 +0200 Geert Uytterhoeven wrote:
> > > Yeah.. more context here:
> > >
> > > https://lore.kernel.org/all/7fd014f2-c9a5-e7ec-f1c6-b3e4bb0f6eb6@samsung.com/
> > >
> > > default !USB_RTL8152 would be my favorite but that probably doesn't
> > > compute in kconfig land. Or perhaps bring back the 'y' but more clearly
> > > mark it as a sub-option of CDCETHER? It's hard to blame people for
> > > expecting drivers to default to n, we should make it clearer that this
> > > is more of a "make driver X support variation Y", 'cause now it sounds
> > > like a completely standalone driver from the Kconfig wording. At least
> > > to a lay person like myself.
> >
> > If it can be a module (tristate), it must be a separate (sub)driver, right?
>
> Fair point.
The problem is CDCETHER (ECM) tries to be a generic driver that just
works for USB standards compliant generic hardware...
(similarly the EEM/NCM drivers)
There shouldn't be a 'subdriver'
next prev parent reply other threads:[~2021-09-21 2:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 17:59 nt: usb: USB_RTL8153_ECM should not default to y Maciej Żenczykowski
2021-09-17 18:49 ` Jakub Kicinski
2021-09-17 19:05 ` Maciej Żenczykowski
2021-09-17 19:37 ` Jakub Kicinski
2021-09-18 11:16 ` Geert Uytterhoeven
2021-09-18 10:53 ` Geert Uytterhoeven
2021-09-20 19:15 ` Jakub Kicinski
2021-09-20 20:19 ` Maciej Żenczykowski [this message]
2021-09-21 7:30 ` Geert Uytterhoeven
2021-09-21 21:28 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANP3RGd5Hiwvx1W=UOCY166MUpLP38u5V6=zJR9c=FPAR52ubg@mail.gmail.com' \
--to=maze@google.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hayeswang@realtek.com \
--cc=kuba@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.