Re: [OE-core] [PATCH v3 5/5] spirv-tools: fix identation

["Jose Quaresma" <quaresma.jose@gmail.com>]

This patch it's only a little fix in the identencion and it can be
dropped from the series.
This is not really necessary for now and I don't need a new revision
only to fix this patch.

Peter Kjellerstedt <peter.kjellerstedt@axis.com> escreveu no dia
segunda, 19/10/2020 à(s) 09:29:
>
> > -----Original Message-----
> > From: openembedded-core@lists.openembedded.org <openembedded-
> > core@lists.openembedded.org> On Behalf Of Jose Quaresma
> > Sent: den 17 oktober 2020 16:30
> > To: openembedded-core@lists.openembedded.org
> > Cc: Jose Quaresma <quaresma.jose@gmail.com>
> > Subject: [OE-core] [PATCH v3 5/5] spirv-tools: fix identation
> >
> > replace tabs with spaces and remove extra spaces
> >
> > Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> > ---
> >  meta/recipes-graphics/spir/spirv-tools_git.bb | 20 +++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/meta/recipes-graphics/spir/spirv-tools_git.bb b/meta/recipes-graphics/spir/spirv-tools_git.bb
> > index d1c2436cd9..8c4d4299ed 100644
> > --- a/meta/recipes-graphics/spir/spirv-tools_git.bb
> > +++ b/meta/recipes-graphics/spir/spirv-tools_git.bb
> > @@ -9,12 +9,12 @@ SECTION = "graphics"
> >  S = "${WORKDIR}/git"
> >  DEST_DIR = "${S}/external"
> >  SRC_URI = "git://github.com/KhronosGroup/SPIRV-Tools.git;name=spirv-tools \
> > -     git://github.com/KhronosGroup/SPIRV-Headers.git;name=spirv-headers;destsuffix=${DEST_DIR}/spirv-headers \
> > -     git://github.com/google/effcee.git;name=effcee;destsuffix=${DEST_DIR}/effcee \
> > -     git://github.com/google/re2.git;name=re2;destsuffix=${DEST_DIR}/re2 \
> > -     git://github.com/google/googletest.git;name=googletest;destsuffix=${DEST_DIR}/googletest \
> > -        file://0001-Respect-CMAKE_INSTALL_LIBDIR-in-installed-CMake-file.patch \
> > -        file://0001-Avoid-pessimizing-std-move-3124.patch \
> > +           git://github.com/KhronosGroup/SPIRV-Headers.git;name=spirv-headers;destsuffix=${DEST_DIR}/spirv-headers \
> > +           git://github.com/google/effcee.git;name=effcee;destsuffix=${DEST_DIR}/effcee \
> > +           git://github.com/google/re2.git;name=re2;destsuffix=${DEST_DIR}/re2 \
> > +           git://github.com/google/googletest.git;name=googletest;destsuffix=${DEST_DIR}/googletest \
> > +           file://0001-Respect-CMAKE_INSTALL_LIBDIR-in-installed-CMake-file.patch;destsuffix=${DEST_DIR}/effcee \
> > +           file://0001-Avoid-pessimizing-std-move-3124.patch \
> >  "
> >  SRCREV_spirv-tools = "c413b982c316b14e784f50d941814fc737b55b4a"
> >  SRCREV_spirv-headers = "af64a9e826bf5bb5fcd2434dd71be1e41e922563"
> > @@ -27,10 +27,10 @@ inherit cmake python3native
> >  EXTRA_OECMAKE += "-DSPIRV_WERROR=OFF"
> >
> >  do_install_append() {
> > -     install -d ${D}/${includedir}/spirv
> > -     install -m 0644 ${DEST_DIR}/spirv-headers/include/spirv/1.2/* ${D}/${includedir}/spirv
> > -     install -d ${D}/${includedir}/spirv/unified1
> > -     install -m 0644 ${DEST_DIR}/spirv-headers/include/spirv/unified1/* ${D}/${includedir}/spirv/unified1
> > +    install -d ${D}/${includedir}/spirv
> > +    install -m 0644 ${DEST_DIR}/spirv-headers/include/spirv/1.2/* ${D}/${includedir}/spirv
> > +    install -d ${D}/${includedir}/spirv/unified1
> > +    install -m 0644 ${DEST_DIR}/spirv-headers/include/spirv/unified1/* ${D}/${includedir}/spirv/unified1
>
> Shell code in OE-Core is actually expected to be indented using tabs,
> so this part should be reverted. However, while you are here, you
> should change "${D}/${includedir}" to "${D}${includedir}".
>
> >  }
> >
> >  FILES_SOLIBSDEV = ""
> > --
> > 2.28.0
>
> //Peter
>


-- 
best regards,
José Quaresma