Hi Richard,

Unfortunately this patch breaks the usage of the icecc.bbclass.

Currently I build with icecc inside a container with network isolation and
my icecc demon runs outside of the container.
The only thing I need to do for using the icecc inside my build container is
mounting the unix /var/run/icecc/iceccd.socket inside the container.

I think that we need something like this functionality to have access to
some sockets connections inside the tasks with the new namespace.

Jose


Richard Purdie <richard.purdie@linuxfoundation.org> escreveu no dia sexta, 7/01/2022 à(s) 23:15:
This patch changes behaviour. After this change any task which does not
have the network flag set will have networking disabled on systems that
support that (kernel version dependent).

Add a "network" task specific flag which then triggers networking to
be enabled for this task, it is otherwise disabled.

This needs to happen before we enter the fakeroot environment of the task
due to the need for the real uid/gid which we save in the parent process.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 bin/bitbake-worker | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/bin/bitbake-worker b/bin/bitbake-worker
index bf96207edc..3aaf3c2444 100755
--- a/bin/bitbake-worker
+++ b/bin/bitbake-worker
@@ -152,6 +152,10 @@ def fork_off_task(cfg, data, databuilder, workerdata, fn, task, taskname, taskha
     fakeenv = {}
     umask = None

+    uid = os.getuid()
+    gid = os.getgid()
+
+
     taskdep = workerdata["taskdeps"][fn]
     if 'umask' in taskdep and taskname in taskdep['umask']:
         umask = taskdep['umask'][taskname]
@@ -257,6 +261,10 @@ def fork_off_task(cfg, data, databuilder, workerdata, fn, task, taskname, taskha

                 bb.utils.set_process_name("%s:%s" % (the_data.getVar("PN"), taskname.replace("do_", "")))

+                if not the_data.getVarFlag(taskname, 'network', False):
+                    logger.debug("Attempting to disable network")
+                    bb.utils.disable_network(uid, gid)
+
                 # exported_vars() returns a generator which *cannot* be passed to os.environ.update()
                 # successfully. We also need to unset anything from the environment which shouldn't be there
                 exports = bb.data.exported_vars(the_data)
--
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#13225): https://lists.openembedded.org/g/bitbake-devel/message/13225
Mute This Topic: https://lists.openembedded.org/mt/88273738/5052612
Group Owner: bitbake-devel+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [quaresma.jose@gmail.com]
-=-=-=-=-=-=-=-=-=-=-=-



--
Best regards,

José Quaresma