Re: [meta-arm][PATCH 1/3] optee-ftpm/optee-os: add missing space in EXTRA_OEMAKE

[Jose Quaresma <quaresma.jose@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1987 bytes --]

Hi Mikko,

Mikko Rapeli <mikko.rapeli@linaro.org> escreveu no dia quinta, 27/10/2022
à(s) 07:18:

> Hi,
>
> On Wed, Oct 26, 2022 at 02:18:52PM +0000, Jose Quaresma wrote:
> > When append to variable a space is required at the beginning.
> >
> > Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
> > ---
> >  meta-arm/recipes-security/optee-ftpm/optee-os_%.bbappend | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-arm/recipes-security/optee-ftpm/optee-os_%.bbappend
> b/meta-arm/recipes-security/optee-ftpm/optee-os_%.bbappend
> > index acea7502..40423615 100644
> > --- a/meta-arm/recipes-security/optee-ftpm/optee-os_%.bbappend
> > +++ b/meta-arm/recipes-security/optee-ftpm/optee-os_%.bbappend
> > @@ -7,7 +7,8 @@ DEPENDS:append = "\
> >                   '' , \
> >                   d)}"
> >
> > -EXTRA_OEMAKE:append = "${@bb.utils.contains('MACHINE_FEATURES', \
> > +EXTRA_OEMAKE:append = "\
>
> There is no need to use :append here. += will do and will add the
> space.


Right, I can use the += but in this case I follow this pattern to make the
change consistent
with what already existed in the file. I can change it, let's see the
maintainer's opinion.


>
> Using :append everywhere without machine or distro qualifiers is
> an annoying antipattern which intermediate layers should not use.
>
> Higher level product specific layers can't easily change the variables
> which have been amended with :append.
>

This will always be tricky to do, a lot due to the freedom of bitbake
syntax.
With :append usage we need to use the :remove because this needs to be done
at the end of the parsing.
While with += you can assign a new value for the variable during parsing
but you will lose all the others that had already possible been added with
+=

Great to talk with you again about bitbake stuff ;)

Jose


> Cheers,
>
> -Mikko
>


-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 2960 bytes --]