All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jose Quaresma <quaresma.jose@gmail.com>
To: Joakim Roubert <joakim.roubert@axis.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>,
	Joakim Roubert <joakimr@axis.com>
Subject: Re: [OE-Core][PATCH v2] gstreamer1.0-plugins-bad: Add support for mpegtsmux
Date: Mon, 3 Jan 2022 15:32:32 +0000	[thread overview]
Message-ID: <CANPvuRmoXvv4yYDqfeDyXYxbYSDrGxF-FRyX2UibBTtP-XMYwQ@mail.gmail.com> (raw)
In-Reply-To: <20220103083850.385326-1-joakim.roubert@axis.com>

[-- Attachment #1: Type: text/plain, Size: 2309 bytes --]

Joakim Roubert <joakim.roubert@axis.com> escreveu no dia segunda, 3/01/2022
à(s) 08:39:

> From: Joakim Roubert <joakimr@axis.com>
>
> When enabling srt one most likely also wants to use mpegtsmux.
>
> Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
> ---
>  .../gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb                 | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-bad_1.18.5.bb b/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-bad_1.18.5.bb
> index f90dff693d..9233c3bec1 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb
> @@ -65,6 +65,7 @@ PACKAGECONFIG[libmms]          =
> "-Dlibmms=enabled,-Dlibmms=disabled,libmms"
>  PACKAGECONFIG[libssh2]         =
> "-Dcurl-ssh2=enabled,-Dcurl-ssh2=disabled,libssh2"
>  PACKAGECONFIG[lcms2]           =
> "-Dcolormanagement=enabled,-Dcolormanagement=disabled,lcms"
>  PACKAGECONFIG[modplug]         =
> "-Dmodplug=enabled,-Dmodplug=disabled,libmodplug"
> +PACKAGECONFIG[mpegtsmux]       =
> "-Dmpegtsmux=enabled,-Dmpegtsmux=disabled""
>

this patch is not backward compatible as it will disable the mpegtsmux
plugin because PACKAGECONFIG don't have mpegtsmux

mpegtsmux doesn't have any external dependencies and is not present
in EXTRA_OEMESON so it is always enabled.
with this patch the default config will build it with -Dmpegtsmux=disabled

Jose


>  PACKAGECONFIG[msdk]            =
> "-Dmsdk=enabled,-Dmsdk=disabled,intel-mediasdk"
>  PACKAGECONFIG[neon]            = "-Dneon=enabled,-Dneon=disabled,neon"
>  PACKAGECONFIG[openal]          =
> "-Dopenal=enabled,-Dopenal=disabled,openal-soft"
> --
> 2.30.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#160115):
> https://lists.openembedded.org/g/openembedded-core/message/160115
> Mute This Topic: https://lists.openembedded.org/mt/88108871/5052612
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 4164 bytes --]

  reply	other threads:[~2022-01-03 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03  8:38 [OE-Core][PATCH v2] gstreamer1.0-plugins-bad: Add support for mpegtsmux Joakim Roubert
2022-01-03 15:32 ` Jose Quaresma [this message]
2022-01-10  7:38   ` Joakim Roubert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANPvuRmoXvv4yYDqfeDyXYxbYSDrGxF-FRyX2UibBTtP-XMYwQ@mail.gmail.com \
    --to=quaresma.jose@gmail.com \
    --cc=joakim.roubert@axis.com \
    --cc=joakimr@axis.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.