From: Matthew Weber <matthew.weber@rockwellcollins.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Config.in: security hardening: disable FORTIFY_SOURCE for gcc < 6
Date: Mon, 5 Nov 2018 14:35:56 -0600 [thread overview]
Message-ID: <CANQCQpYGPBpEivKh893TPeoqoOtS+FxGmNjYvmgwGWoArOyu=A@mail.gmail.com> (raw)
In-Reply-To: <20181105200750.6039-1-romain.naour@gmail.com>
Romain ,
On Mon, Nov 5, 2018, 14:07 Romain Naour <romain.naour@gmail.com wrote:
> As reported in the bug report [1], gcc < 6 doesn't build when
> FORTIFY_SOURCE is set to 1 or 2. The issue is related to the
> upstream bug report [2] but the patch fixing the issue for gcc 6
> has not been backported to earlier gcc versions.
>
> Add a dependency on gcc at least version 6 to BR2_FORTIFY_SOURCE_1
> and BR2_FORTIFY_SOURCE_2.
>
Sorry about the HTML email.
Could this dependency be conditional on if a internal toolchain is used?
> [1] https://bugs.busybox.net/show_bug.cgi?id=11476
> [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61164
> [3]
> https://github.com/gcc-mirror/gcc/commit/55f12fce4ccf77513644a247f9c401a5b1fa2402
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Matthew Weber <matthew.weber@rockwellcollins.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> ---
> To be backported up to Buildroot 2018.02.x.
> ---
> Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Config.in b/Config.in
> index 584a1f087f..6176433fc0 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -798,6 +798,8 @@ config BR2_FORTIFY_SOURCE_NONE
>
> config BR2_FORTIFY_SOURCE_1
> bool "Conservative"
> + # gcc bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61164
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_6
> help
> This option sets _FORTIFY_SOURCE to 1 and only introduces
> checks that shouldn't change the behavior of conforming
> @@ -805,6 +807,8 @@ config BR2_FORTIFY_SOURCE_1
>
> config BR2_FORTIFY_SOURCE_2
> bool "Aggressive"
> + # gcc bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61164
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_6
> help
> This option sets _FORTIFY_SOURCES to 2 and some more
> checking is added, but some conforming programs might fail.
> --
> 2.14.5
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181105/39860aad/attachment.html>
next prev parent reply other threads:[~2018-11-05 20:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 20:07 [Buildroot] [PATCH] Config.in: security hardening: disable FORTIFY_SOURCE for gcc < 6 Romain Naour
2018-11-05 20:35 ` Matthew Weber [this message]
2018-11-05 22:17 ` Peter Korsgaard
2018-11-05 22:21 ` Matthew Weber
2018-11-06 12:27 ` Matthew Weber
2018-11-06 21:06 ` Romain Naour
2018-11-06 9:06 ` Peter Korsgaard
2018-11-25 20:49 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANQCQpYGPBpEivKh893TPeoqoOtS+FxGmNjYvmgwGWoArOyu=A@mail.gmail.com' \
--to=matthew.weber@rockwellcollins.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.