From: Matthew Weber <matthew.weber@rockwellcollins.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] tclap: new package
Date: Tue, 10 Jun 2014 21:03:22 -0500 [thread overview]
Message-ID: <CANQCQpYOrNEFP=TpzjJk8AcHS1B3+ek+fgEKJtYiE93Fq=1EZg@mail.gmail.com> (raw)
In-Reply-To: <20140610221111.5181dcb3@free-electrons.com>
Thomas,
On Tue, Jun 10, 2014 at 3:11 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Matt Weber,
>
> On Tue, 10 Jun 2014 08:02:05 -0700, Matt Weber wrote:
>
>> diff --git a/package/tclap/Config.in b/package/tclap/Config.in
>> new file mode 100644
>> index 0000000..e50704b
>> --- /dev/null
>> +++ b/package/tclap/Config.in
>> @@ -0,0 +1,12 @@
>> +config BR2_PACKAGE_TCLAP
>> + bool "tclap"
>
> This package needs C++ support, so the appropriate 'depends on' +
> comment is needed.
>
>> + help
>> + This is a small, flexible library that provides a simple interface for
>> + defining and accessing command line arguments. It was intially inspired
>
> intially -> initially.
Agree.
>
>> + by the user friendly CLAP libary. The difference is that this library is
>> + templatized, so the argument class is type independent. Type independence
>> + avoids identical-except-for-type objects, such as IntArg, FloatArg, and
>> + StringArg. While the library is not strictly compliant with the GNU or
>> + POSIX standards, it is close.
>
> Please check lines do not exceed 72 chars.
Agree.
>
>> + http://tclap.sourceforge.net/
>> diff --git a/package/tclap/tclap.mk b/package/tclap/tclap.mk
>> new file mode 100644
>> index 0000000..268b90b
>> --- /dev/null
>> +++ b/package/tclap/tclap.mk
>> @@ -0,0 +1,16 @@
>> +################################################################################
>> +#
>> +# tclap
>> +#
>> +################################################################################
>> +
>> +TCLAP_VERSION = 1.2.1
>> +TCLAP_SITE = http://downloads.sourceforge.net/project/tclap
>> +TCLAP_SOURCE = tclap-$(TCLAP_VERSION).tar.gz
>
> Not needed, that's the default.
Sure.
>
>> +TCLAP_LICENSE = MIT
>> +TCLAP_LICENSE_FILES = COPYING
>> +
>> +TCLAP_INSTALL_STAGING = YES
>> +TCLAP_INSTALL_TARGET = NO
>
> A short comment that explains why INSTALL_TARGET = NO is useful. Just
> say it's a pure C++ template library, only made of headers.
Sure.
<snip>
--
Matthew L Weber / Sr Software Engineer / Platform Software
matthew.weber at rockwellcollins.com
www.rockwellcollins.com
next prev parent reply other threads:[~2014-06-11 2:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 15:02 [Buildroot] [PATCH 0/3] Support for the Freescale frame manager utility Matt Weber
2014-06-10 15:02 ` [Buildroot] [PATCH 1/3] fmlib: new package Matt Weber
2014-06-10 20:01 ` Thomas Petazzoni
2014-06-11 2:06 ` Matthew Weber
2014-06-10 15:02 ` [Buildroot] [PATCH 2/3] tclap: " Matt Weber
2014-06-10 20:11 ` Thomas Petazzoni
2014-06-11 2:03 ` Matthew Weber [this message]
2014-06-10 15:02 ` [Buildroot] [PATCH 3/3] fmc: " Matt Weber
2014-06-10 20:21 ` Thomas Petazzoni
2014-06-11 2:00 ` Matthew Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANQCQpYOrNEFP=TpzjJk8AcHS1B3+ek+fgEKJtYiE93Fq=1EZg@mail.gmail.com' \
--to=matthew.weber@rockwellcollins.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.