All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Weber <matthew.weber@rockwellcollins.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/openjdk: modify site from mirror to official repos
Date: Mon, 2 Dec 2019 07:57:07 -0600	[thread overview]
Message-ID: <CANQCQpYkA+ZisfWXFLWtjfL3Xk6Mk4CZi6FBMFnkBP0ATqzKYA@mail.gmail.com> (raw)
In-Reply-To: <3c9e68edd0b8700b3914ff63ff773ed0@tudorholton.com>

Tudor,



On Mon, Dec 2, 2019 at 12:09 AM Tudor Holton <tudor@tudorholton.com> wrote:
>
> On 2019-12-02 01:18, Arnout Vandecappelle wrote:
> > On 27/11/2019 06:39, Tudor Holton wrote:

[snip]

> >> @@ -7,7 +7,10 @@
> >>  OPENJDK_VERSION_MAJOR = 12.0.2
> >>  OPENJDK_VERSION_MINOR = 10
> >>  OPENJDK_VERSION = $(OPENJDK_VERSION_MAJOR)+$(OPENJDK_VERSION_MINOR)
> >> -OPENJDK_SITE = $(call
> >> github,AdoptOpenJDK,openjdk-jdk12u,jdk-$(OPENJDK_VERSION))
> >> +OPENJDK_PROJECT = jdk-updates
> >> +OPENJDK_RELEASE = jdk12u
> >
> >  Is it relevant to create variables for these? Just use them directly
> > in the
> > _SITE, like we do for most other packages.
> >
> >
>
> This was inspired by a few other buildroot openjdk packages that have
> been floating around the internet.
>
> It's more a style choice, but also an understanding of the upstream
> repos layout:
>
> Since OpenJDK has multiple streams this may become needed later on.
> Things like aarch32 aren't in jdk-updates (yet).  Config.in may
> eventually be able to select the project and release, but I was trying
> to keep this all as close to the current version as possible.  Don't
> forget, also, that OpenJDK now has LTS releases, which I think would be
> preferable, but there will always be a demand for newer releases also.

If you could, please verify the openjdk run-tests test case still
passes after this site change.  From within your buildroot clone with
this patchset applied, run the following.

./support/testing/run-tests -d ./dl/ -k -o test_dir
tests.package.test_openjdk.TestOpenJdk

Regards,
Matt

  parent reply	other threads:[~2019-12-02 13:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27  5:39 [Buildroot] [PATCH 1/1] package/openjdk: modify site from mirror to official repos Tudor Holton
2019-12-01 14:18 ` Arnout Vandecappelle
2019-12-02  6:09   ` Tudor Holton
2019-12-02  8:40     ` Arnout Vandecappelle
2019-12-02 13:57     ` Matthew Weber [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-11-27  5:31 Tudor Holton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANQCQpYkA+ZisfWXFLWtjfL3Xk6Mk4CZi6FBMFnkBP0ATqzKYA@mail.gmail.com \
    --to=matthew.weber@rockwellcollins.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.