All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Weber <matthew.weber@rockwellcollins.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] skeleton: /etc/network/interface.d/* support
Date: Tue, 25 Oct 2016 08:14:28 -0500	[thread overview]
Message-ID: <CANQCQpZ5EyFnKAjzkyunDLOW2tn0g+dq6q2mF4UhXW16TKBcsQ@mail.gmail.com> (raw)
In-Reply-To: <87twc1kkr2.fsf@dell.be.48ers.dk>

Peter,

On Tue, Oct 25, 2016 at 1:25 AM, Peter Korsgaard <peter@korsgaard.com> wrote:
>>>>>> "Matthew" == Matthew Weber <matthew.weber@rockwellcollins.com> writes:
>
> Hi,
>
>  >> > We afaik provide no explicit guarantees on the ordering of the various
>  >> > _TARGET_FINALIZE hooks
>  >>
>  >> Correct.
>  >>
>  >> >, but it afaik will run in (package-)alphabetical
>  >> > order, E.G. before the finalize hooks of skeleton so this doesn't work
>  >> > :/
>  >>
>  >> Hum, my thinking was that it did not matter if the "source" line is
>  >> before or after the lo definition. However, the skeleton package
>  >> completely overwrites the file, so indeed, it doesn't work.
>
>  > So leave it as is in the skeleton.mk?
>
> I think that is the only place we can add it, yes.
>
> With that said, there's afaik no packages using interface.d, so if this
> is just for project customization then you might as well handle it there
> (E.G. you might already have a custom interfaces or appending the line
> to it in your post-build is easy).

Agree, but in this case we thought it might make sense to include by
default, so that we encourage the practice of using that style of
interface configuration which follows the behavior/intent of larger
Linux distros.  Especially since the user intentionally enables
ifupdown for more advanced use cases.

I'm good either way.

-- 
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / Security Systems and Software / Secure Platforms
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
www.rockwellcollins.com

Note: Any Export License Required Information and License Restricted
Third Party Intellectual Property (TPIP) content must be encrypted and
sent to matthew.weber at corp.rockwellcollins.com.

      reply	other threads:[~2016-10-25 13:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16 15:38 [Buildroot] [PATCH v2] skeleton: /etc/network/interface.d/* support Matt Weber
2016-10-22 21:28 ` Thomas Petazzoni
2016-10-23 12:06   ` Peter Korsgaard
2016-10-23 12:17     ` Thomas Petazzoni
2016-10-25  2:22       ` Matthew Weber
2016-10-25  6:25         ` Peter Korsgaard
2016-10-25 13:14           ` Matthew Weber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANQCQpZ5EyFnKAjzkyunDLOW2tn0g+dq6q2mF4UhXW16TKBcsQ@mail.gmail.com \
    --to=matthew.weber@rockwellcollins.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.