All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Weber <matthew.weber@rockwellcollins.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] python: disable _ssl.c build when --disable-ssl
Date: Fri, 10 Mar 2017 12:15:18 -0600	[thread overview]
Message-ID: <CANQCQpa1Lp8hqpmaZREEoYbJEusrAerNQriQ_H4+ENped3DVAA@mail.gmail.com> (raw)
In-Reply-To: <20170310000437.5513602a@free-electrons.com>

Adam


On Mar 9, 2017 5:04 PM, "Thomas Petazzoni" <
thomas.petazzoni@free-electrons.com> wrote:

Hello,

On Wed, 11 Jan 2017 15:22:22 -0600, Matt Weber wrote:
> From: Adam <adam.allison@rockwellcollins.com>
>
> When --disable-ssl is provided as an option,
> prevent the building of _ssl.c.
> Without this change, some GCC toolchains fail
> to build the _ssl module depending on the
> build configuration
> (we observed 4.85 worked and 4.9.4).
>
> Signed-off-by: Adam Allison <adam.allison@rockwellcollins.com>
> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>

Thanks for this patch. However I fixed it in a different/simpler way in
commit
https://git.buildroot.org/buildroot/commit/package/python?id=
3c98442669f173818a8cce9479ebb0806cb9f8a2

Let me know if that works for you.


  Adam, do you have a test you could run?  It looks fine to me but I can't
test.


Best regards,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170310/9309ed6b/attachment.html>

  reply	other threads:[~2017-03-10 18:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11 21:22 [Buildroot] [PATCH 1/1] python: disable _ssl.c build when --disable-ssl Matt Weber
2017-01-13  9:31 ` Nicolas Cavallari
2017-03-09 23:04 ` Thomas Petazzoni
2017-03-10 18:15   ` Matthew Weber [this message]
     [not found]     ` <CAO1odpw8E=b2eTsVX8vCjhUF_vpg34WJvUxCKGCm+p0OSMsdkw@mail.gmail.com>
     [not found]       ` <CAO1odpzng87mcYwEFs72B9bRTdLgewtGscH1GsuEAyndOVuntw@mail.gmail.com>
     [not found]         ` <CAO1odpzB59BT3cgh3AVznLzcWz+nShYsok1GqEv_SV9N3wXbLA@mail.gmail.com>
2017-03-10 20:30           ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANQCQpa1Lp8hqpmaZREEoYbJEusrAerNQriQ_H4+ENped3DVAA@mail.gmail.com \
    --to=matthew.weber@rockwellcollins.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.