All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Weber <matthew.weber@collins.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/uboot-tools: resolve uboot env source file error
Date: Mon, 25 Jan 2021 15:30:42 -0600	[thread overview]
Message-ID: <CANQCQpbmPKCP74bEZHfcAxL33j+ATmgOe6m4eMPQRKS=9A=3hA@mail.gmail.com> (raw)
In-Reply-To: <20210125221537.5cb4dbdd@windsurf.home>

Thomas,

On Mon, Jan 25, 2021 at 3:16 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Mon, 25 Jan 2021 08:57:41 -0600
> Matt Weber <matthew.weber@rockwellcollins.com> wrote:
>
> > From: Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>
> >
> > If Target u-boot is not available, the host build of uboot-tools
> > requires user to provide u-boot environment source file.
> > This change resolves a missing parentheses and updates the comment
> > for the same.
> >
> > Signed-off-by: Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>
> > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
> > ---
> >  package/uboot-tools/uboot-tools.mk | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
>
> Applied to master, thanks. I think this bug really shows we need some
> unit tests for this uboot-tools package functionality, in
> supporting/testing/.

I did add autobuilder testing of this feature but it didn't do a case
for when the file isn't provided....
https://github.com/buildroot/buildroot/blob/master/utils/genrandconfig#L304

Matt

  reply	other threads:[~2021-01-25 21:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 14:57 [Buildroot] [PATCH 1/2] package/uboot-tools: resolve uboot env source file error Matt Weber
2021-01-25 14:57 ` [Buildroot] [PATCH 2/2] package/uboot-tools: env/script generation need BINARIES_DIR Matt Weber
2021-01-25 21:16   ` Thomas Petazzoni
2021-01-25 21:22     ` Matthew Weber
2021-01-25 21:42       ` Yann E. MORIN
2021-01-25 22:22         ` Thomas Petazzoni
2021-01-26 13:09           ` [Buildroot] [External] " Matthew Weber
2021-01-25 21:15 ` [Buildroot] [PATCH 1/2] package/uboot-tools: resolve uboot env source file error Thomas Petazzoni
2021-01-25 21:30   ` Matthew Weber [this message]
2021-01-25 21:37     ` Thomas Petazzoni
2021-01-28 18:32 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANQCQpbmPKCP74bEZHfcAxL33j+ATmgOe6m4eMPQRKS=9A=3hA@mail.gmail.com' \
    --to=matthew.weber@collins.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.