From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C875C433B4 for ; Wed, 14 Apr 2021 21:49:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EBA061001 for ; Wed, 14 Apr 2021 21:49:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EBA061001 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWnNr-0004tP-KS for qemu-devel@archiver.kernel.org; Wed, 14 Apr 2021 17:49:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWnNF-0004Sv-NT for qemu-devel@nongnu.org; Wed, 14 Apr 2021 17:48:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37142) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWnNC-000825-On for qemu-devel@nongnu.org; Wed, 14 Apr 2021 17:48:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618436913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to; bh=JZQl31+Ihrf2aglFAb+Kr54/lsYY1bPdmxK/niNdHE4=; b=NEEj6BvrwNQDy1/pmq+ibgBJJuuqYs1wnldBSRoTbzduU2BGejgi3HkBYU8ItZjt9CvNZ4 0Z9TMCLap4T1vqqiGB+DbFYIbXi8g2xlKsRjKwFXs0vbP50rxOMHCP00tHymBRGWMN+qRy JOAccZfeabKkw9x0pzY9fIN6HMMT6J4= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-iLDCEtdLORWhEJZIil2orw-1; Wed, 14 Apr 2021 17:48:31 -0400 X-MC-Unique: iLDCEtdLORWhEJZIil2orw-1 Received: by mail-oi1-f198.google.com with SMTP id s9-20020acadb090000b0290101bacefaa4so7024839oig.2 for ; Wed, 14 Apr 2021 14:48:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:cc :subject:from:to:date:message-id:in-reply-to; bh=JZQl31+Ihrf2aglFAb+Kr54/lsYY1bPdmxK/niNdHE4=; b=SZWZ84xuwr4WqGuIfU7wPkpB0aOXPEf6eBU0M1treZEK6dNWdikqnFxr3Asq8TJ8E7 SqO/GskbYDf+gpVgcpjYe3lyXZgEfIc9z9CtcbDgGXbVyS1ExL+uNX3WReQdwokIkbq8 +chtz4q3xZ4PrhrZol51IDUF7AsbXNB3zKu6s4yyBMaO/tfXPG3TOdeLCFf8LhkStgoS lpZc/sOBR6lKiPKP19Vt8ye20TZblyVQb96trC52T7gTePIVO58ifOGtHVNPAhePtTMs wjkVn9g8xvSc85kG+xXWuSqcZ8v0kcu8jXz4vhPY3j2Jskm7wsm/2YqWhIip6qdrZeDr kq0Q== X-Gm-Message-State: AOAM533VnGgDzbeSVpY81FoJ4ND154W7KlbZjSlSaoY23LR0o77RFaf7 Zb2x6EElMwV9+mrNkdnansZRiD/hSfz43fXJnLelUKxr85losMhDG4I+0anC8J5ueidNQ0OWoF2 heoCMPedtC96Bn0E= X-Received: by 2002:a4a:925a:: with SMTP id g26mr205486ooh.29.1618436910766; Wed, 14 Apr 2021 14:48:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXuVylyqIkLi2ZtSTt5GuGfXmRpyjdIB3faMZBhm4GPyVocUdQzI+/mBJlOugRbYZiGZvBdw== X-Received: by 2002:a4a:925a:: with SMTP id g26mr205478ooh.29.1618436910559; Wed, 14 Apr 2021 14:48:30 -0700 (PDT) Received: from localhost (ip68-103-222-6.ks.ok.cox.net. [68.103.222.6]) by smtp.gmail.com with ESMTPSA id t20sm164047oou.6.2021.04.14.14.48.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Apr 2021 14:48:30 -0700 (PDT) Mime-Version: 1.0 Subject: Re: [Virtio-fs] [PATCH 2/2] virtiofsd: Add help for -o xattr-mapping From: "Connor Kuehl" To: "Carlos Venegas" , Date: Wed, 14 Apr 2021 16:44:26 -0500 Message-Id: In-Reply-To: <20210414201207.3612432-3-jose.carlos.venegas.munoz@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ckuehl@redhat.com X-Mimecast-Spam-Score: 1 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Received-SPF: pass client-ip=216.205.24.124; envelope-from=ckuehl@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, vgoyal@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed Apr 14, 2021 at 3:12 PM CDT, Carlos Venegas wrote: > The option is not documented in help. > > Add small help about the option. > > Signed-off-by: Carlos Venegas > --- > tools/virtiofsd/helper.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c > index 28243b51b2..5e98ed702b 100644 > --- a/tools/virtiofsd/helper.c > +++ b/tools/virtiofsd/helper.c > @@ -172,6 +172,9 @@ void fuse_cmdline_help(void) > " default: no_writeback\n" > " -o xattr|no_xattr enable/disable xattr\n" > " default: no_xattr\n" > + " -o xattrmap=3D Enable xattr mapping (enables xattr)\n" > + " is a string consists of a series of rules\n" > + " e.g. -o xattrmap=3D:map::user.virtiofs.:\n" This is a helpful note, but it doesn't tell the whole story. I think it'd be helpful to add one last note to this option which is to recommend reading the virtiofsd(1) man-page for more information on xattrmap rules. Connor From mboxrd@z Thu Jan 1 00:00:00 1970 Mime-Version: 1.0 From: "Connor Kuehl" Date: Wed, 14 Apr 2021 16:44:26 -0500 Message-Id: In-Reply-To: <20210414201207.3612432-3-jose.carlos.venegas.munoz@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Virtio-fs] [PATCH 2/2] virtiofsd: Add help for -o xattr-mapping List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Carlos Venegas , virtio-fs@redhat.com Cc: qemu-devel@nongnu.org, vgoyal@redhat.com On Wed Apr 14, 2021 at 3:12 PM CDT, Carlos Venegas wrote: > The option is not documented in help. > > Add small help about the option. > > Signed-off-by: Carlos Venegas > --- > tools/virtiofsd/helper.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c > index 28243b51b2..5e98ed702b 100644 > --- a/tools/virtiofsd/helper.c > +++ b/tools/virtiofsd/helper.c > @@ -172,6 +172,9 @@ void fuse_cmdline_help(void) > " default: no_writeback\n" > " -o xattr|no_xattr enable/disable xattr\n" > " default: no_xattr\n" > + " -o xattrmap= Enable xattr mapping (enables xattr)\n" > + " is a string consists of a series of rules\n" > + " e.g. -o xattrmap=:map::user.virtiofs.:\n" This is a helpful note, but it doesn't tell the whole story. I think it'd be helpful to add one last note to this option which is to recommend reading the virtiofsd(1) man-page for more information on xattrmap rules. Connor