All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wanpeng Li <kernellwp@gmail.com>
To: Morten Rasmussen <morten.rasmussen@arm.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
	"Yuyang Du" <yuyang.du@intel.com>,
	"Vincent Guittot" <vincent.guittot@linaro.org>,
	"Mike Galbraith" <mgalbraith@suse.de>,
	sgurrappadi@nvidia.com, "Koan-Sin Tan" <freedom.tan@mediatek.com>,
	小林敬太 <keita.kobayashi.ym@renesas.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 05/13] sched: Introduce SD_ASYM_CPUCAPACITY sched_domain topology flag
Date: Wed, 17 Aug 2016 17:26:26 +0800	[thread overview]
Message-ID: <CANRm+Cw14tk7vg9cjW6PVEVK47N-Uwk3e5-=LtRLv8wr_u4zLg@mail.gmail.com> (raw)
In-Reply-To: <20160817092345.GF3391@e105550-lin.cambridge.arm.com>

2016-08-17 17:23 GMT+08:00 Morten Rasmussen <morten.rasmussen@arm.com>:
> On Wed, Aug 17, 2016 at 04:42:36PM +0800, Wanpeng Li wrote:
>> 2016-07-25 21:34 GMT+08:00 Morten Rasmussen <morten.rasmussen@arm.com>:
>> > Add a topology flag to the sched_domain hierarchy indicating the lowest
>> > domain level where the full range of cpu capacities is represented by
>> > the domain members for asymmetric capacity topologies (e.g. ARM
>> > big.LITTLE).
>> >
>> > The flag is intended to indicate that extra care should be taken when
>> > placing tasks on cpus and this level spans all the different types of
>> > cpus found in the system (no need to look further up the domain
>> > hierarchy). This information is currently only available through
>> > iterating through the capacities of all the cpus at parent levels in the
>> > sched_domain hierarchy.
>> >
>> > SD 2      [  0      1      2      3]  SD_ASYM_CPUCAPACITY
>> >
>> > SD 1      [  0      1] [   2      3]  !SD_ASYM_CPUCAPACITY
>> >
>> > cpu:         0      1      2      3
>> > capacity:  756    756   1024   1024
>> >
>> > If the topology in the example above is duplicated to create an eight
>> > cpu example with third sched_domain level on top (SD 3), this level
>> > should not have the flag set (!SD_ASYM_CPUCAPACITY) as its two group
>> > would both have all cpu capacities represented within them.
>>
>> I didn't find the place where set SD_ASYM_CPUCAPACITY to any SDs in
>> this patchset, but you have testing result in cover letter, where I
>> miss?
>
> The flag is supposed to be set by arch-specific code. I included a few
> patches in v1 and v2 that set the flag for arch/arm. However, since they
> are hopefully soon to be superseded by patches from Juri I dropped them
> from the v3 posting and provided a pointer to branch containing this patch
> set, Juri's patches, and few additional glue patches instead that
> enabled the flag when necessary for arch/arm and arch/arm64.

Ah, ok, thanks for the information. :)

Regards,
Wanpeng Li

  reply	other threads:[~2016-08-17  9:27 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 13:34 [PATCH v3 00/13] sched: Clean-ups and asymmetric cpu capacity support Morten Rasmussen
2016-07-25 13:34 ` [PATCH v3 01/13] sched: Fix power to capacity renaming in comment Morten Rasmussen
2016-07-25 13:34 ` [PATCH v3 02/13] sched/fair: Consistent use of prev_cpu in wakeup path Morten Rasmussen
2016-07-25 13:34 ` [PATCH v3 03/13] sched/fair: Optimize find_idlest_cpu() when there is no choice Morten Rasmussen
2016-07-25 13:34 ` [PATCH v3 04/13] sched/core: Remove unnecessary null-pointer check Morten Rasmussen
2016-08-18 10:56   ` [tip:sched/core] sched/core: Remove unnecessary NULL-pointer check tip-bot for Morten Rasmussen
2016-07-25 13:34 ` [PATCH v3 05/13] sched: Introduce SD_ASYM_CPUCAPACITY sched_domain topology flag Morten Rasmussen
2016-08-15 10:54   ` Peter Zijlstra
2016-08-15 11:43     ` Morten Rasmussen
2016-08-18 10:56     ` [tip:sched/core] sched/core: Clarify SD_flags comment tip-bot for Peter Zijlstra
2016-08-17  8:42   ` [PATCH v3 05/13] sched: Introduce SD_ASYM_CPUCAPACITY sched_domain topology flag Wanpeng Li
2016-08-17  9:23     ` Morten Rasmussen
2016-08-17  9:26       ` Wanpeng Li [this message]
2016-08-18 10:56   ` [tip:sched/core] sched/core: " tip-bot for Morten Rasmussen
2016-07-25 13:34 ` [PATCH v3 06/13] sched/core: Pass child domain into sd_init Morten Rasmussen
2016-08-18 10:57   ` [tip:sched/core] sched/core: Pass child domain into sd_init() tip-bot for Morten Rasmussen
2016-07-25 13:34 ` [PATCH v3 07/13] sched: Enable SD_BALANCE_WAKE for asymmetric capacity systems Morten Rasmussen
2016-08-18 10:57   ` [tip:sched/core] sched/core: " tip-bot for Morten Rasmussen
2016-07-25 13:34 ` [PATCH v3 08/13] sched: Store maximum per-cpu capacity in root domain Morten Rasmussen
2016-08-01 18:53   ` Dietmar Eggemann
2016-08-16 12:24     ` Vincent Guittot
2016-08-18 10:58     ` [tip:sched/core] sched/core: Store maximum per-CPU " tip-bot for Dietmar Eggemann
2016-07-25 13:34 ` [PATCH v3 09/13] sched/fair: Let asymmetric cpu configurations balance at wake-up Morten Rasmussen
2016-08-15 13:39   ` Peter Zijlstra
2016-08-15 15:01     ` Morten Rasmussen
2016-08-15 15:10       ` Peter Zijlstra
2016-08-15 15:30         ` Morten Rasmussen
2016-08-18 10:58   ` [tip:sched/core] sched/fair: Let asymmetric CPU " tip-bot for Morten Rasmussen
2016-07-25 13:34 ` [PATCH v3 10/13] sched/fair: Compute task/cpu utilization at wake-up more correctly Morten Rasmussen
2016-08-15 14:23   ` Peter Zijlstra
2016-08-15 15:42     ` Morten Rasmussen
2016-08-18  8:40       ` Morten Rasmussen
2016-08-18 10:24         ` Morten Rasmussen
2016-08-18 11:46           ` Wanpeng Li
2016-08-18 13:45             ` Morten Rasmussen
2016-08-19  1:43               ` Wanpeng Li
2016-08-19 14:03                 ` Morten Rasmussen
2016-08-22  1:48                   ` Wanpeng Li
2016-08-22 11:29                     ` Morten Rasmussen
2016-07-25 13:34 ` [PATCH v3 11/13] sched/fair: Consider spare capacity in find_idlest_group() Morten Rasmussen
2016-08-16 13:57   ` Vincent Guittot
2016-08-18 11:16     ` Morten Rasmussen
2016-08-18 12:28       ` Peter Zijlstra
2016-07-25 13:34 ` [PATCH v3 12/13] sched: Add per-cpu min capacity to sched_group_capacity Morten Rasmussen
2016-07-25 13:34 ` [PATCH v3 13/13] sched/fair: Avoid pulling tasks from non-overloaded higher capacity groups Morten Rasmussen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANRm+Cw14tk7vg9cjW6PVEVK47N-Uwk3e5-=LtRLv8wr_u4zLg@mail.gmail.com' \
    --to=kernellwp@gmail.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=freedom.tan@mediatek.com \
    --cc=keita.kobayashi.ym@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgalbraith@suse.de \
    --cc=mingo@redhat.com \
    --cc=morten.rasmussen@arm.com \
    --cc=peterz@infradead.org \
    --cc=sgurrappadi@nvidia.com \
    --cc=vincent.guittot@linaro.org \
    --cc=yuyang.du@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.