From: Wanpeng Li <kernellwp@gmail.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
"Radim Kr??m???" <rkrcmar@redhat.com>,
Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 1/2] KVM: X86: Fix setup the virt_spin_lock_key before static key get initialized
Date: Tue, 27 Mar 2018 08:52:18 +0800 [thread overview]
Message-ID: <CANRm+Cw=x1YVSpX1Zcz=EkLFhojSa_zyTOLEiNX-Di3ENGmCiA@mail.gmail.com> (raw)
In-Reply-To: <20180326223232.ifaoc3zyjii4gq2f@linux-n805>
2018-03-27 6:32 GMT+08:00 Davidlohr Bueso <dave@stgolabs.net>:
> On Mon, 26 Mar 2018, Wanpeng Li wrote:
>
>> I didn't see any issue when testing this patch, could you elaborate
>> what's the bulky mechanism and how it conflicts with early smp bootup
>> stages? In addition, do you mean the xen fix is also not suitable?
>
>
> I have nothing against your patch (or the xen one for that matter), other
> than
> the fact that both seem like band-aid solutions to being able to move up the
> jump
> label init call. I was actually peddling a similar patch but didn't want to
> add
> the extra callback just for that -- at least xen already had
> smp_ops.smp_prepare_cpus.
>
> Instead of dropping the patches in -tip (ie: delaying the feature), I have
> nothing
> against these fixes being merged. If a better solution is available later,
> we can
> always move dealing with virt_spin_lock_key back into
> smp_prepare_boot_cpu().
Yeah, we can pick the current patch for the fixes and wait a better
solution is available later.
>
> Also a bit unrelated, but am I correct to assume that KVM_HINTS_DEDICATED
> can be
> used via qemu? I've only been dealing with kernel parameters.
The host admin can control it by qemu command-line, -cpu ...+kvm-hint-dedicated
Regards,
Wanpeng Li
next prev parent reply other threads:[~2018-03-27 0:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 4:17 [PATCH 1/2] KVM: X86: Fix setup the virt_spin_lock_key before static key get initialized Wanpeng Li
2018-03-26 0:27 ` Davidlohr Bueso
2018-03-26 14:10 ` Wanpeng Li
2018-03-26 22:32 ` Davidlohr Bueso
2018-03-27 0:52 ` Wanpeng Li [this message]
2018-03-27 16:29 ` Davidlohr Bueso
2018-03-28 0:45 ` Wanpeng Li
2018-03-28 20:19 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANRm+Cw=x1YVSpX1Zcz=EkLFhojSa_zyTOLEiNX-Di3ENGmCiA@mail.gmail.com' \
--to=kernellwp@gmail.com \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.