From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754558AbcIEAtz (ORCPT ); Sun, 4 Sep 2016 20:49:55 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:38291 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754146AbcIEAtv (ORCPT ); Sun, 4 Sep 2016 20:49:51 -0400 MIME-Version: 1.0 In-Reply-To: <1473013367-12173-1-git-send-email-jan.dakinevich@gmail.com> References: <1473013367-12173-1-git-send-email-jan.dakinevich@gmail.com> From: Wanpeng Li Date: Mon, 5 Sep 2016 08:49:31 +0800 Message-ID: Subject: Re: [PATCH] KVM: nVMX: pass valid guest linear-address to the L1 To: Jan Dakinevich Cc: kvm , Paolo Bonzini , Radim Krcmar , "linux-kernel@vger.kernel.org" , ynorov@caviumnetworks.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-09-05 2:22 GMT+08:00 Jan Dakinevich : > If EPT support is exposed to L1 hypervisor, guest linear-address field > of VMCS should contain GVA of L2, the access to which caused EPT violation. > > Signed-off-by: Jan Dakinevich > --- > arch/x86/kvm/vmx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 5cede40..a4bb2bd 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -10500,6 +10500,9 @@ static void prepare_vmcs12(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12, > vmcs12->guest_pdptr3 = vmcs_read64(GUEST_PDPTR3); > } > > + if (nested_cpu_has_ept(vmcs12)) > + vmcs12->guest_linear_address = vmcs_readl(GUEST_LINEAR_ADDRESS); > + No, nested_ept_inject_page_fault() will set vmcs12->guest_linear_address after L0 walks L1's EPT page table and finds that the mapping is invalid if nested EPT is enabled. prepare_vmcs12() just copies the vmcs field that could have changed by the L2 guest or the exit-information etc instead of all fields since other fields are modified by L1 with VMWRITE, which already writes to vmcs12 directly. Regards, Wanpeng Li