From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932336AbcHOWTh (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Aug 2016 18:19:37 -0400
Received: from mail-wm0-f45.google.com ([74.125.82.45]:33237 "EHLO
	mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932173AbcHOWTg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Aug 2016 18:19:36 -0400
MIME-Version: 1.0
In-Reply-To: <1471273244.32433.22.camel@redhat.com>
References: <1468421405-20056-1-git-send-email-fweisbec@gmail.com>
 <1468421405-20056-2-git-send-email-fweisbec@gmail.com> <CANRm+CyYHLaihuk+ckQg42-Lo_3vFHaS8gU=GmXh8Rfq5mMpaA@mail.gmail.com>
 <1470751579.13905.77.camel@redhat.com> <CANRm+CzxWo9i_=Ygn4CAF0L5=1avtnX=ahwMK96fj3hnQW-_zA@mail.gmail.com>
 <CANRm+CzXSCNGoVbuOB0Ruj2nmfHNRfcO3eB-91Z-fnBOnn-gbQ@mail.gmail.com>
 <20160810125212.78564dc2@annuminas.surriel.com> <CANRm+Cye=ipm5XwhBV-AxjCMZRQTb3ahuYEa6KXBMe_HzxPa2Q@mail.gmail.com>
 <1470969892.13905.120.camel@redhat.com> <CANRm+CzUAinBTigNVW37r4odfZmP6gT9vuHY1tnQrXGXp3i6jA@mail.gmail.com>
 <20160812115803.0f26211c@annuminas.surriel.com> <CANRm+CzF5RLS=yLp7xJqkUG3HO4R-xUxGsOeZUBHj8gyEiD5gA@mail.gmail.com>
 <1471273244.32433.22.camel@redhat.com>
From: Wanpeng Li <kernellwp@gmail.com>
Date: Tue, 16 Aug 2016 06:19:34 +0800
Message-ID: <CANRm+CzuRRYhK089kobRvXVJKUeUBkMTeNsuRiKMRTRKVUqrhA@mail.gmail.com>
Subject: Re: [PATCH] time,virt: resync steal time when guest & host lose sync
To: Rik van Riel <riel@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Wanpeng Li <wanpeng.li@hotmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Radim Krcmar <rkrcmar@redhat.com>, Mike Galbraith <efault@gmx.de>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2016-08-15 23:00 GMT+08:00 Rik van Riel <riel@redhat.com>:
> On Mon, 2016-08-15 at 16:53 +0800, Wanpeng Li wrote:
>> 2016-08-12 23:58 GMT+08:00 Rik van Riel <riel@redhat.com>:
>> [...]
>> > Wanpeng, does the patch below work for you?
>>
>> It will break steal time for full dynticks guest, and there is a
>> calltrace of thread_group_cputime_adjusted call stack, RIP is
>> cputime_adjust+0xff/0x130.
>
> How?  This patch is equivalent to passing ULONG_MAX to
> steal_account_process_time, which you tried to no ill
> effect before.

https://lkml.org/lkml/2016/8/15/217 I sent out a patch yesterday which
can fix the regression. Your patch breaks full dynticks guest since
vtime doesn't depend on clock ticks, so we should keep the max cputime
limit for it as my patch description mentioned, remove the limit for
vtime results in the calltrace. My patch does what Paolo suggested
https://lkml.org/lkml/2016/8/12/380 for lost ticks scenario.

Regards,
Wanpeng Li