From: Wanpeng Li <kernellwp@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "David Matlack" <dmatlack@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm list" <kvm@vger.kernel.org>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Peter Hornyack" <peterhornyack@google.com>,
"X86 ML" <x86@kernel.org>
Subject: Re: [PATCH 2/2] x86, kvm: use kvmclock to compute TSC deadline value
Date: Tue, 11 Oct 2016 12:05:42 +0800 [thread overview]
Message-ID: <CANRm+Czx1V0ni6-gbde1AMZtYdqnEOkAbjGj0ed6y8i2mbi0aw@mail.gmail.com> (raw)
In-Reply-To: <42be43c0-bb0c-8b01-9e36-39ced43209c0@redhat.com>
2016-09-10 0:38 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>
>
> On 09/09/2016 00:13, David Matlack wrote:
>> Hi Paolo,
>>
>> On Tue, Sep 6, 2016 at 3:29 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>> Bad things happen if a guest using the TSC deadline timer is migrated.
>>> The guest doesn't re-calibrate the TSC after migration, and the
>>> TSC frequency can and will change unless your processor supports TSC
>>> scaling (on Intel this is only Skylake) or your data center is perfectly
>>> homogeneous.
>>
>> Sorry, I forgot to follow up on our discussion in v1. One thing we
>> discussed there was using the APIC Timer to workaround a changing TSC
>> rate. You pointed out KVM's TSC deadline timer got a nice performance
>> boost recently, which makes it preferable. Does it makes sense to
>> apply the same optimization (using the VMX preemption timer) to the
>> APIC Timer, instead of creating a new dependency on kvmclock?
>
> Hi, yes it does.
Windows 2008 server, 2012 server etc are still using APIC Timer
periodic mode, so I am adding the VMX preemption timer support to APIC
Timer one shot/periodic mode currently.
Regards,
Wanpeng Li
next prev parent reply other threads:[~2016-10-11 4:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 22:29 [PATCH v2 0/2] if running under KVM, use kvmclock to compute TSC deadline value Paolo Bonzini
2016-09-06 22:29 ` [PATCH 1/2] x86: paravirt: add local_apic_timer_interrupt to pv_ops Paolo Bonzini
2016-09-07 6:25 ` kbuild test robot
2016-09-07 6:33 ` kbuild test robot
2016-09-06 22:29 ` [PATCH 2/2] x86, kvm: use kvmclock to compute TSC deadline value Paolo Bonzini
2016-09-08 22:13 ` David Matlack
2016-09-09 16:38 ` Paolo Bonzini
2016-09-09 20:05 ` David Matlack
2016-10-11 4:05 ` Wanpeng Li [this message]
2016-09-15 15:09 ` Radim Krčmář
2016-09-15 16:00 ` Paolo Bonzini
2016-09-15 19:59 ` Radim Krčmář
2016-09-15 21:02 ` Paolo Bonzini
2016-09-16 14:59 ` Radim Krčmář
2016-09-16 15:06 ` Paolo Bonzini
2016-09-16 15:24 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANRm+Czx1V0ni6-gbde1AMZtYdqnEOkAbjGj0ed6y8i2mbi0aw@mail.gmail.com \
--to=kernellwp@gmail.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterhornyack@google.com \
--cc=rkrcmar@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.