From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79D621C35 for ; Thu, 28 Jul 2022 14:25:45 +0000 (UTC) Received: by mail-yb1-f173.google.com with SMTP id o15so3482710yba.10 for ; Thu, 28 Jul 2022 07:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=p3LundJe/B7kP70p/sHLOn4E+FS4l10QjqFmK00htFE=; b=A1npVQRsIIGhqrLf8k1afl0RnpwTJqtndWJ9zwwdiHBec1qyAdFLwzqHsOSEz3tCvV J33JylIt6+Pd/jdRlsNR8UNmRloDG3G3NH8SDxk+u/mKNySVTad5ytB99iquy75NDEmJ 4mWC5CLDqVkcs4L2XoIG3yXXPEAHHG/8Tcg/Dvv9GYAPEUkBT69Sf5SENvQPZzOzH0sX rfGEF5dzUYaNlMOHu9Bo+MhNb46gjzqbFsnt6Os5CtChAsnh8Oe9HHUf8ZzIl+foGeav 4tev6dNQXoIBnvQvDpzSxoDwu4FxCVkjoAtNixqsdq3d7+awDvcxDaofyreOs9jcFNbc pM7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=p3LundJe/B7kP70p/sHLOn4E+FS4l10QjqFmK00htFE=; b=8QYtjjeQsAwEpm/HRfmZHWgybcGRrOqHM1RcD2WA9AwKF3c7/H7CCR1JyyRrDQiO5U aORGPwLLyIgmRterIu8uJ4FN+FpGgwJvCkr4c8Pogqcdu9+IdAwXlLoQ/J172FCJRWRX fUQbZBm16NrTq+Zz4yckESHlehuuE8JyXVIu6Dev6eLdZrgrLM+zJUplW3hR4AemT0aw S0fl8gkyVBSujuBE2EGGBJJ7S+f3+9FXqjFTDKnboUiLfL41/rBuoVv6qGjBxHz9ZcaZ ORHNTncydYN2mlJ8hXzAdD2KFpQlcCVyXIq8fAHelqdbxSpoK+AO1tuJUv7AHugQOHXx tOPQ== X-Gm-Message-State: AJIora84hfj3kkb1tCbnk5LrRGy0w6nu3U27VYAjgeG3esaOZRGvBLxQ NsCZket5uM7RV0bDr8irSj8qPorrtS4GWJDyZWw= X-Google-Smtp-Source: AGRyM1tCj4kGBTNXRwFwSGAlKun9Kno3+3NAkIfxjL5nye0CiOrWdeD4Is2ry7fRDFK14XMZzZ9IWnwfFJOA1A028zM= X-Received: by 2002:a25:e401:0:b0:66e:280a:98cd with SMTP id b1-20020a25e401000000b0066e280a98cdmr20245601ybh.540.1659018344244; Thu, 28 Jul 2022 07:25:44 -0700 (PDT) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <202207190634.ToyhlXSz-lkp@intel.com> <0551a3ad-8c42-78fe-5b50-ebbc003e55e6@intel.com> In-Reply-To: From: Jason Gerecke Date: Thu, 28 Jul 2022 07:26:00 -0700 Message-ID: Subject: Re: [PATCH] i2c: Use u8 type in i2c transfer calls To: Jonathan Cameron , Lars-Peter Clausen , Wolfram Sang Cc: linux-i2c@vger.kernel.org, Ping Cheng , "Tobita, Tatsunosuke" , Jason Gerecke , llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-iio@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 20, 2022 at 12:01 PM Jason Gerecke wrote= : > > On Tue, Jul 19, 2022 at 5:21 PM kernel test robot = wrote: > > > > > > Hi Jason, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on wsa/i2c/for-next] > > [also build test ERROR on linus/master v5.19-rc7 next-20220718] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: > > https://github.com/intel-lab-lkp/linux/commits/Jason-Gerecke/i2c-Use-u8= -type-in-i2c-transfer-calls/20220718-233658 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git > > i2c/for-next > > config: hexagon-randconfig-r026-20220718 > > (https://download.01.org/0day-ci/archive/20220719/202207190634.ToyhlXSz= -lkp@intel.com/config) > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project > > d74b88c69dc2644bd0dc5d64e2d7413a0d4040e5) > > reproduce (this is a W=3D1 build): > > wget > > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cros= s > > -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # > > https://github.com/intel-lab-lkp/linux/commit/9732240c23a365c0590f05ce8= 3196869235a2ea7 > > git remote add linux-review https://github.com/intel-lab-lkp/l= inux > > git fetch --no-tags linux-review > > Jason-Gerecke/i2c-Use-u8-type-in-i2c-transfer-calls/20220718-233658 > > git checkout 9732240c23a365c0590f05ce83196869235a2ea7 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross= W=3D1 > > O=3Dbuild_dir ARCH=3Dhexagon SHELL=3D/bin/bash drivers/iio/adc/ > > > > If you fix the issue, kindly add following tag where applicable > > Reported-by: kernel test robot > > > > All errors (new ones prefixed by >>): > > > > >> drivers/iio/adc/max1363.c:1645:12: error: incompatible function poin= ter types assigning to 'int (*)(const struct i2c_client *, const char *, in= t)' from 'int (const struct i2c_client *, const u8 *, int)' (aka 'int (cons= t struct i2c_client *, const unsigned char *, int)') [-Werror,-Wincompatibl= e-function-pointer-types] > > st->send =3D i2c_master_send; > > ^ ~~~~~~~~~~~~~~~ > > >> drivers/iio/adc/max1363.c:1646:12: error: incompatible function poin= ter types assigning to 'int (*)(const struct i2c_client *, char *, int)' fr= om 'int (const struct i2c_client *, u8 *, int)' (aka 'int (const struct i2c= _client *, unsigned char *, int)') [-Werror,-Wincompatible-function-pointer= -types] > > st->recv =3D i2c_master_recv; > > ^ ~~~~~~~~~~~~~~~ > > 2 errors generated. > > Wolfram and Jonathan, > > Writing a patch to fix the new warnings generated by my I2C patch is > simple enough, but I'd like some help coordinating getting both > patches landed. Should I wait for the I2C patch to land in "for-next" > before sending the IIO fix, or would it be preferred to send the IIO > fix right now so that both patches can be reviewed simultaneously? It's been pretty quiet, so asking again for any thoughts on how to best address this tangle... Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3955348443602990360==" MIME-Version: 1.0 From: Jason Gerecke To: kbuild-all@lists.01.org Subject: Re: [PATCH] i2c: Use u8 type in i2c transfer calls Date: Thu, 28 Jul 2022 07:26:00 -0700 Message-ID: In-Reply-To: List-Id: --===============3955348443602990360== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Jul 20, 2022 at 12:01 PM Jason Gerecke wro= te: > > On Tue, Jul 19, 2022 at 5:21 PM kernel test robot wrote: > > > > > > Hi Jason, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on wsa/i2c/for-next] > > [also build test ERROR on linus/master v5.19-rc7 next-20220718] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: > > https://github.com/intel-lab-lkp/linux/commits/Jason-Gerecke/i2c-Use-u8= -type-in-i2c-transfer-calls/20220718-233658 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git > > i2c/for-next > > config: hexagon-randconfig-r026-20220718 > > (https://download.01.org/0day-ci/archive/20220719/202207190634.ToyhlXSz= -lkp(a)intel.com/config) > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project > > d74b88c69dc2644bd0dc5d64e2d7413a0d4040e5) > > reproduce (this is a W=3D1 build): > > wget > > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross > > -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # > > https://github.com/intel-lab-lkp/linux/commit/9732240c23a365c0590f05ce8= 3196869235a2ea7 > > git remote add linux-review https://github.com/intel-lab-lkp/l= inux > > git fetch --no-tags linux-review > > Jason-Gerecke/i2c-Use-u8-type-in-i2c-transfer-calls/20220718-233658 > > git checkout 9732240c23a365c0590f05ce83196869235a2ea7 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross= W=3D1 > > O=3Dbuild_dir ARCH=3Dhexagon SHELL=3D/bin/bash drivers/iio/adc/ > > > > If you fix the issue, kindly add following tag where applicable > > Reported-by: kernel test robot > > > > All errors (new ones prefixed by >>): > > > > >> drivers/iio/adc/max1363.c:1645:12: error: incompatible function poin= ter types assigning to 'int (*)(const struct i2c_client *, const char *, in= t)' from 'int (const struct i2c_client *, const u8 *, int)' (aka 'int (cons= t struct i2c_client *, const unsigned char *, int)') [-Werror,-Wincompatibl= e-function-pointer-types] > > st->send =3D i2c_master_send; > > ^ ~~~~~~~~~~~~~~~ > > >> drivers/iio/adc/max1363.c:1646:12: error: incompatible function poin= ter types assigning to 'int (*)(const struct i2c_client *, char *, int)' fr= om 'int (const struct i2c_client *, u8 *, int)' (aka 'int (const struct i2c= _client *, unsigned char *, int)') [-Werror,-Wincompatible-function-pointer= -types] > > st->recv =3D i2c_master_recv; > > ^ ~~~~~~~~~~~~~~~ > > 2 errors generated. > > Wolfram and Jonathan, > > Writing a patch to fix the new warnings generated by my I2C patch is > simple enough, but I'd like some help coordinating getting both > patches landed. Should I wait for the I2C patch to land in "for-next" > before sending the IIO fix, or would it be preferred to send the IIO > fix right now so that both patches can be reviewed simultaneously? It's been pretty quiet, so asking again for any thoughts on how to best address this tangle... Jason --===============3955348443602990360==--