From: Shyam Prasad N <nspmangalore@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: "Aurélien Aptel" <aaptel@suse.com>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH][SMB3] 3 small multichannel client patches
Date: Sat, 8 May 2021 18:00:04 +0530 [thread overview]
Message-ID: <CANT5p=q1o7UofWJGQ4iWzXhZ4VcaSQj4iciM17G6-Tza3Mefqw@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5mu3m6FWWqrfOeQugXWGZOPiEE+Xgk8wc0rn8OgLRVPSWQ@mail.gmail.com>
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
... for all three patches.
For 0003, logging is okay for now. However, when we have a way to pass
custom messages to userspace with new mount API, we should have this
message there too.
Regards,
Shyam
On Sat, May 8, 2021 at 6:43 AM Steve French <smfrench@gmail.com> wrote:
>
> 1) we were not setting CAP_MULTICHANNEL on negotiate request
> 2) we were ignoring whether the server set CAP_NEGOTIATE in the response
> 3) we were silently ignoring multichannel when "max_channels" was > 1
> but the user forgot to include "multichannel" in mount line.
>
>
>
> --
> Thanks,
>
> Steve
--
Regards,
Shyam
next prev parent reply other threads:[~2021-05-08 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 1:13 [PATCH][SMB3] 3 small multichannel client patches Steve French
2021-05-08 12:30 ` Shyam Prasad N [this message]
2021-05-08 13:29 ` Tom Talpey
2021-05-08 15:10 ` Steve French
2021-05-08 15:20 ` Tom Talpey
2021-05-08 15:51 ` Steve French
2021-05-11 15:53 ` Aurélien Aptel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANT5p=q1o7UofWJGQ4iWzXhZ4VcaSQj4iciM17G6-Tza3Mefqw@mail.gmail.com' \
--to=nspmangalore@gmail.com \
--cc=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.