All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shyam Prasad N <nspmangalore@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: CIFS <linux-cifs@vger.kernel.org>,
	ronnie sahlberg <ronniesahlberg@gmail.com>,
	rohiths msft <rohiths.msft@gmail.com>
Subject: Re: [SMB3][PATCH] ifs: refactor create_sd_buf() and and avoid corrupting the buffer
Date: Wed, 2 Dec 2020 15:22:42 +0530	[thread overview]
Message-ID: <CANT5p=rXznKiOK0mGa+K00vsi2siTLiniKKD3M62QeKSAUj58Q@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5mt+=ELCwSASFsPPjET=qf80_1tOTMPN-gG9cF=BQd-VBg@mail.gmail.com>

On Friday, I made similar changes as a part of my changes for sending
default sec_desc, while testing against Azure.
The idea is similar to Ronnie's patch. Move the owner and group SIDs
up and push down the DACL.
In addition to the changes Ronnie made, it looks like the 8-byte
alignment is required for few of the other offset fields too.
Hopefully, I'll have it tested out by EOD, and send out another patch.

Regards,
Shyam

On Tue, Dec 1, 2020 at 9:54 AM Steve French <smfrench@gmail.com> wrote:
>
> Updated patch with fixes for various endian sparse warnings
>
>
> On Mon, Nov 30, 2020 at 12:02 AM Steve French <smfrench@gmail.com> wrote:
> >
> > When mounting with "idsfromsid" mount option, Azure
> > corrupted the owner SIDs due to excessive padding
> > caused by placing the owner fields at the end of the
> > security descriptor on create.  Placing owners at the
> > front of the security descriptor (rather than the end)
> > is also safer, as the number of ACEs (that follow it)
> > are variable.
> >
> > --
> > Thanks,
> >
> > Steve
>
>
>
> --
> Thanks,
>
> Steve



-- 
-Shyam

  reply	other threads:[~2020-12-02  9:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30  6:02 [SMB3][PATCH] ifs: refactor create_sd_buf() and and avoid corrupting the buffer Steve French
2020-12-01  4:19 ` Steve French
2020-12-02  9:52   ` Shyam Prasad N [this message]
2020-12-02 10:00     ` ronnie sahlberg
2020-12-03 16:46   ` Steve French
2020-12-03 22:08     ` ronnie sahlberg
2020-12-03 23:12       ` Steve French
2020-12-03 23:23         ` ronnie sahlberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANT5p=rXznKiOK0mGa+K00vsi2siTLiniKKD3M62QeKSAUj58Q@mail.gmail.com' \
    --to=nspmangalore@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=rohiths.msft@gmail.com \
    --cc=ronniesahlberg@gmail.com \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.