[PATCH] [Outreachy kernel] staging: mxx_udc: remove unused code

[PATCH] [Outreachy kernel] staging: mxx_udc: remove unused code

[Payal Kshirsagar]

Remove the code enclosed by #if 0 and its #endif because that code never
going to be run

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
 drivers/staging/emxx_udc/emxx_udc.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
index 540e4ca..212aded 100644
--- a/drivers/staging/emxx_udc/emxx_udc.h
+++ b/drivers/staging/emxx_udc/emxx_udc.h
@@ -8,13 +8,6 @@
 #ifndef _LINUX_EMXX_H
 #define _LINUX_EMXX_H
 
-/*---------------------------------------------------------------------------*/
-/*----------------- Default undef */
-#if FALSE
-#define DEBUG
-#define UDC_DEBUG_DUMP
-#endif
-
 /*----------------- Default define */
 #define	USE_DMA	1
 #define USE_SUSPEND_WAIT	1
-- 
2.7.4

Re: [PATCH] [Outreachy kernel] staging: mxx_udc: remove unused code

[Greg KH]

On Thu, Mar 21, 2019 at 02:03:03PM +0530, Payal Kshirsagar wrote:
> Remove the code enclosed by #if 0 and its #endif because that code never
> going to be run
> 
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
>  drivers/staging/emxx_udc/emxx_udc.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
> index 540e4ca..212aded 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.h
> +++ b/drivers/staging/emxx_udc/emxx_udc.h
> @@ -8,13 +8,6 @@
>  #ifndef _LINUX_EMXX_H
>  #define _LINUX_EMXX_H
>  
> -/*---------------------------------------------------------------------------*/
> -/*----------------- Default undef */
> -#if FALSE
> -#define DEBUG
> -#define UDC_DEBUG_DUMP
> -#endif

The reason this is here is to make it "easy" for a developer to enable
debugging for the driver.

Now we should just rely on the in-kernel dynamic debugging support, so
we should be able to get rid of this, but before you do that, you need
to remove the use of those two #defines on the codebase.

So for now, please leave this as-is.

thanks,

greg k-h

Re: [PATCH] [Outreachy kernel] staging: mxx_udc: remove unused code

[Payal Kshirsagar]

[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]

On Thu, 21 Mar 2019 at 15:31, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Thu, Mar 21, 2019 at 02:03:03PM +0530, Payal Kshirsagar wrote:
> > Remove the code enclosed by #if 0 and its #endif because that code never
> > going to be run
> >
> > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> > ---
> >  drivers/staging/emxx_udc/emxx_udc.h | 7 -------
> >  1 file changed, 7 deletions(-)
> >
> > diff --git a/drivers/staging/emxx_udc/emxx_udc.h
> b/drivers/staging/emxx_udc/emxx_udc.h
> > index 540e4ca..212aded 100644
> > --- a/drivers/staging/emxx_udc/emxx_udc.h
> > +++ b/drivers/staging/emxx_udc/emxx_udc.h
> > @@ -8,13 +8,6 @@
> >  #ifndef _LINUX_EMXX_H
> >  #define _LINUX_EMXX_H
> >
> >
> -/*---------------------------------------------------------------------------*/
> > -/*----------------- Default undef */
> > -#if FALSE
> > -#define DEBUG
> > -#define UDC_DEBUG_DUMP
> > -#endif
>
> The reason this is here is to make it "easy" for a developer to enable
> debugging for the driver.
>
> Now we should just rely on the in-kernel dynamic debugging support, so
> we should be able to get rid of this, but before you do that, you need
> to remove the use of those two #defines on the codebase.
>
> So for now, please leave this as-is.
>
> okay.
payal

thanks,
>
> greg k-h
>

[-- Attachment #2: Type: text/html, Size: 2055 bytes --]