From: Mikhail B. WproxyM <w.proxy.m@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] boot/grub2: grub-core-build-fixes-for-i386 (grub-2.04 + binutils-2.35.2 + pseudo-op .code64)
Date: Wed, 28 Apr 2021 11:07:13 +0300 [thread overview]
Message-ID: <CANTg=Qig12wrSU2WUBPmXFkjSpmmTo1gfEn1x6rgDR8vTM-82g@mail.gmail.com> (raw)
In-Reply-To: <20210426225630.113ee3d7@windsurf>
Hello, Thomas.
I have the build error, when building *from i686* to i686.
You do not have the build error, when building *from x86-64* to i686.
Looks like it is the reason.
Grub2 developers do not run build tests under i386/i686. Even you do
not run build tests under i686.
P.S.: Common build platform for most developers is x86-64, so I am not
surprised. It is too simple to lose compatibility by using too many
levels of assumptions, facades and abstractions.
--
Best regards
--
Best regards, Mikhail B.
??, 26 ???. 2021 ?. ? 23:56, Thomas Petazzoni <thomas.petazzoni@bootlin.com>:
>
> Hello Mikhail,
>
> On Tue, 20 Apr 2021 12:35:16 +0300
> "Mikhail B. WproxyM" <w.proxy.m@gmail.com> wrote:
>
> > We are using binutils-2.35.2+ (later then 2.29.1), grub-2.04,
> > cross-compiling on recent buildroot under i386/i686 and getting error:
> >
> > > lib/i386/relocator64.S:66: Error: unknown pseudo-op: `.code64'
> >
> > So, the working patch is attached. Please add it to buildroot.
>
> Do you have some details on the conditions to reproduce this issue?
> Indeed, I just tried to build grub2, with the following configuration:
>
> BR2_x86_core2=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_INIT_NONE=y
> BR2_SYSTEM_BIN_SH_NONE=y
> # BR2_PACKAGE_BUSYBOX is not set
> # BR2_TARGET_ROOTFS_TAR is not set
> BR2_TARGET_GRUB2=y
> BR2_TARGET_GRUB2_I386_EFI=y
>
> So it's using a i686 target system, with a toolchain that uses binutils
> 2.34 (i.e later than the 2.29 you're pointing). And it builds fine,
> including relocator64.S, which gets built as part of the build process.
>
> Note: I am building *from* an x86-64 system. But how can that matter,
> as relocator64.S is built using the cross-compiler?
>
> Also, why isn't this patch in upstream Grub ?
>
> Thanks a lot for the additional details you could provide.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
next prev parent reply other threads:[~2021-04-28 8:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 9:35 [Buildroot] boot/grub2: grub-core-build-fixes-for-i386 (grub-2.04 + binutils-2.35.2 + pseudo-op .code64) Mikhail B. WproxyM
2021-04-26 20:56 ` Thomas Petazzoni
2021-04-28 8:07 ` Mikhail B. WproxyM [this message]
2021-04-28 11:44 ` Thomas Petazzoni
2021-04-28 13:23 ` Mikhail B. WproxyM
2021-05-13 7:19 ` Mikhail B. WproxyM
2021-05-13 7:19 ` Mikhail B. WproxyM
2021-05-13 7:28 ` John Paul Adrian Glaubitz
2021-05-05 9:39 ` Fwd: " Mikhail B. WproxyM
2021-05-05 9:44 ` Mikhail B. WproxyM
2021-05-05 16:33 ` Daniel Kiper
2021-05-13 10:35 ` Jan Nieuwenhuizen
2021-05-17 16:49 ` Daniel Kiper
2021-05-18 5:05 ` Jan Nieuwenhuizen
2021-05-18 7:02 ` John Paul Adrian Glaubitz
2021-05-05 14:16 ` Fwd: " John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANTg=Qig12wrSU2WUBPmXFkjSpmmTo1gfEn1x6rgDR8vTM-82g@mail.gmail.com' \
--to=w.proxy.m@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.