From: Huzaifa Rahman <huzaifa.rahman@emumba.com>
To: dev@dpdk.org
Subject: Re: [PATCH] ethtool: correct format strings according to the arguments
Date: Fri, 27 May 2022 10:14:57 +0500 [thread overview]
Message-ID: <CANVhzTgra2Hr+evsD=A+RS0iRnx17tLW2pPLVVqrwsem-d5zsA@mail.gmail.com> (raw)
In-Reply-To: <20220324053124.8085-1-huzaifa.rahman@emumba.com>
[-- Attachment #1: Type: text/plain, Size: 2057 bytes --]
Hi,
The following tests are failing but my patch is not related to anything
related to these. Please re-run the tests.
Failed Tests:
- mtu_update
- scatter
Thanks,
Huzaifa
On Thu, Mar 24, 2022 at 10:31 AM huzaifa.rahman <huzaifa.rahman@emumba.com>
wrote:
> The corrected format strings are not consistent with the
> given arguments. So they are changed accordingly.
>
> Signed-off-by: huzaifa.rahman <huzaifa.rahman@emumba.com>
> ---
> examples/ethtool/ethtool-app/main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/examples/ethtool/ethtool-app/main.c
> b/examples/ethtool/ethtool-app/main.c
> index 1f011a9321..ea8332e49c 100644
> --- a/examples/ethtool/ethtool-app/main.c
> +++ b/examples/ethtool/ethtool-app/main.c
> @@ -208,7 +208,7 @@ static int worker_main(__rte_unused void *ptr_data)
> &ptr_port->mac_addr);
> if (ret != 0) {
>
> rte_spinlock_unlock(&ptr_port->lock);
> - printf("Failed to get MAC address
> (port %u): %s",
> + printf("Failed to get MAC address
> (port %i): %s",
> ptr_port->idx_port,
> rte_strerror(-ret));
> return ret;
> @@ -284,11 +284,11 @@ int main(int argc, char **argv)
> rte_exit(EXIT_FAILURE, "rte_eal_init(): Failed");
>
> cnt_ports = rte_eth_dev_count_avail();
> - printf("Number of NICs: %i\n", cnt_ports);
> + printf("Number of NICs: %u\n", cnt_ports);
> if (cnt_ports == 0)
> rte_exit(EXIT_FAILURE, "No available NIC ports!\n");
> if (cnt_ports > MAX_PORTS) {
> - printf("Info: Using only %i of %i ports\n",
> + printf("Info: Using only %u of %i ports\n",
> cnt_ports, MAX_PORTS
> );
> cnt_ports = MAX_PORTS;
> --
> 2.25.1
>
>
[-- Attachment #2: Type: text/html, Size: 3634 bytes --]
next prev parent reply other threads:[~2022-05-27 5:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 5:31 [PATCH] ethtool: correct format strings according to the arguments huzaifa.rahman
2022-05-27 5:14 ` Huzaifa Rahman [this message]
2023-07-03 22:32 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANVhzTgra2Hr+evsD=A+RS0iRnx17tLW2pPLVVqrwsem-d5zsA@mail.gmail.com' \
--to=huzaifa.rahman@emumba.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.