From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDAAAC48BE8 for ; Fri, 18 Jun 2021 20:57:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A79F6610C7 for ; Fri, 18 Jun 2021 20:57:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234307AbhFRU7h (ORCPT ); Fri, 18 Jun 2021 16:59:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234310AbhFRU7g (ORCPT ); Fri, 18 Jun 2021 16:59:36 -0400 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EE27C061760 for ; Fri, 18 Jun 2021 13:57:27 -0700 (PDT) Received: by mail-oi1-x22d.google.com with SMTP id x196so11937366oif.10 for ; Fri, 18 Jun 2021 13:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DD2GAVQkoZQHyaa/X6JS/cvzxNBSW/U8mImYnLJWDS0=; b=ptBPdegoTpxFZL3hRqyoHkhcHHHZWlkRWd0gzrxCWkhD2Yb1oedkwGS9bJffqTKc3M FVPxkXRUpkJIdAEv0zXdYGme0UjQ/Udf7ECul7eK0UPqFrPIp1ZQ/zQQ+Eow8uM4VDrt 96Gz0zuGPj2eIwzYYQy1EYN4ewU/emTLtwM8R+RrtI4tOO6tbc69r0O0oIw3mMpqILON Gl4+/+EwS/bdx0TRCEmRYaihLfwKghlRe8dcKUbItvY4GXz3HZLDSaGAzSAMVoHEVKpy 5uPJ8ZK0NHnJjXS1hq324j+Y7zGYQ2ReyYD9TJdiwOh36ITLanoEJvRVGpP0A5HwQkhK FtPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DD2GAVQkoZQHyaa/X6JS/cvzxNBSW/U8mImYnLJWDS0=; b=TpEqHzvUQrij95OHCUuTzasWm0l7bCLIb1emg+lnCLI5z1ZycBMpfZ6Z67fywh+cN/ TkyI8aHNHfw0Boa3T2LO2nxv1K7ReXzG85FB4nAvRSxzecVJKfAXIobbbyFpS4PnOGCa 92Df0qWxAJTgH1aSQ6N9x7LqHzl0getAac6bfMAaqA06bJZnq+52ohWuSMEFP81izVkF 8vClAACpxMmYiMxvx5S35avpHGOXVAZ+TXjt3bxbXebNoDTtikdul4WlhUgqTol6QWqs 4840TAc4TNHa9Yv7Q4+MspHioLyLiDZAXpnXPQgcMYCatK/N0Zs8JX9DNVvVUUgFSxsd vbfg== X-Gm-Message-State: AOAM533DnfOLVB3G/005AFO3NfxU5jWs51EK1ssSET9D2v4nDNEEHkVs F9+eUxM/ljBwUMMLQSugMzEZQZqvZb8gqzNoYnMPC+//Pgkb9g== X-Google-Smtp-Source: ABdhPJxRB5c05EfPudE7eVPn1bY0E2Y68W2rPmh1RTx0OS0PaLG1sASXax99ETUdCZhBYj5NOi8AbtA+1j1FjdyeaeU= X-Received: by 2002:aca:aa4e:: with SMTP id t75mr16238217oie.0.1624049846727; Fri, 18 Jun 2021 13:57:26 -0700 (PDT) MIME-Version: 1.0 References: <20210618113118.70621-1-laramglazier@gmail.com> In-Reply-To: From: Lara Lazier Date: Fri, 18 Jun 2021 22:57:15 +0200 Message-ID: Subject: Re: [PATCH kvm-unit-tests] svm: Updated cr4 in test_efer to fix report msg To: Jim Mattson Cc: Krish Sadhukhan , kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Am Fr., 18. Juni 2021 um 22:26 Uhr schrieb Jim Mattson : > > On Fri, Jun 18, 2021 at 12:59 PM Lara Lazier wrote: > > > My understanding is as follows: > > The "first" test should succeed with an SVM_EXIT_ERR when EFER.LME and > > CR0.PG are both > > non-zero and CR0.PE is zero (so I believe we do not really care > > whether CR4.PAE is set or not though > > I might be overlooking something here). > > You are overlooking the fact that the test will fail if CR4.PAE is > clear. If CR4.PAE is 0 *and* CR0.PE is 0, then you can't be sure which > one triggered the failure. Oh, yes that makes sense! Thank you for the explanation. I will move it back up.