From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89BE6C55199 for ; Mon, 27 Apr 2020 08:47:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 561702098B for ; Mon, 27 Apr 2020 08:47:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="aJaVtmhn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726611AbgD0Ir6 (ORCPT ); Mon, 27 Apr 2020 04:47:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbgD0Ir6 (ORCPT ); Mon, 27 Apr 2020 04:47:58 -0400 Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E583EC061A0F for ; Mon, 27 Apr 2020 01:47:57 -0700 (PDT) Received: by mail-ot1-x344.google.com with SMTP id z25so24820009otq.13 for ; Mon, 27 Apr 2020 01:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mlWbhU9/EmkPkE3KgFalNDlgj8IuZTC+N04d/sX94zU=; b=aJaVtmhnB60iCS5aU72qYpjSl4GarLyMRo6mE3SWoVddygx/s1bcaKs3gTE7K6UUbO o4RayG4kLMsthZ9NAP40ehfOAxyhj1LEfHG6eB/gKUS0vVj/9mXcBIpIkUzUKNi3NCri hHRRvTjFPtdMy6vHuqYxugy7S7L4Le7YTPCBV3O/K1uZVjb6eeVVAy9m9PSWczUpLWJI OQ0ci1aMz8766LfwSXYkTxDlOXnE+Sp7uR/aCOClWA2dJTGvai4EeTwjlFCYCtpdtzm8 fyrwDqx8JizdfM4qescTEoft91MXwbAOE8Jn49/tyDCfNvjsXpUyPgTfuA80krsiVVb/ 7qew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mlWbhU9/EmkPkE3KgFalNDlgj8IuZTC+N04d/sX94zU=; b=e1CADfzOk4Dv2xmiIwv1GYe/XFphRSD2cbR7Iyum+hzKOzCFcydRK9iHY+PCv+8+nV wetXP0UvpmdVkEMBLdHWhRNWy1QfHgxD0OhJo8eRwpoRMOYza4W0LRb1uCZZIerah8mu dcGfSIPrNm8oSOuUnAIBwM6RsL7S4/Xwsd4I/uUok7ks5ZyIvKIZ+m4XnZSGuj1nZ5/i 7aejI0FLm3T63QGyGrjO1f/DQO2MBRiDK4dPngUPHU6ZQIWT/3SJI3UWrfhNJBy3c8l9 dXqDlKoTNhsP09yfpdkwhfNf8TlN5oh+z0RCk/j+b1c8cNqN6f5x7Jjw4pXF2kTDXWOs 8sJg== X-Gm-Message-State: AGi0PuYh5pzZzvLT5SzxSYRsHqjKDbB6Txhs0V562fTBzvGd018kkN7t BsvgPlEtacIzW9S78SUlLMIDb/7EUFE9Bc9vFvxkAg== X-Google-Smtp-Source: APiQypLF9Liz1Wy9Drrlg62h9adl1IQdvPHEtoI3csNtrhxw2UwXHBiWwoYfsvKYHOmr9NvTZRbKN9FmhAyxIBwBF3g= X-Received: by 2002:aca:c78d:: with SMTP id x135mr351307oif.91.1587977277220; Mon, 27 Apr 2020 01:47:57 -0700 (PDT) MIME-Version: 1.0 References: <23980cd0f0e5d79e24a92169116407c75bcc650d.1587455584.git.zong.li@sifive.com> <20200427074915.GA11787@willie-the-truck> In-Reply-To: <20200427074915.GA11787@willie-the-truck> From: Zong Li Date: Mon, 27 Apr 2020 16:47:47 +0800 Message-ID: Subject: Re: [PATCH 1/4] mm: add DEBUG_WX support To: Will Deacon Cc: akpm@linux-foundation.org, linux-mm@kvack.org, "linux-kernel@vger.kernel.org List" , Paul Walmsley , Palmer Dabbelt , linux-riscv , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, catalin.marinas@arm.com, linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 27, 2020 at 3:49 PM Will Deacon wrote: > > On Tue, Apr 21, 2020 at 04:17:12PM +0800, Zong Li wrote: > > Some architectures support DEBUG_WX function, it's verbatim from each > > others. Extract to mm/Kconfig.debug for shared use. > > > > Signed-off-by: Zong Li > > Suggested-by: Palmer Dabbelt > > --- > > mm/Kconfig.debug | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > > index 0271b22e063f..077458ad968d 100644 > > --- a/mm/Kconfig.debug > > +++ b/mm/Kconfig.debug > > @@ -118,6 +118,39 @@ config DEBUG_RODATA_TEST > > ---help--- > > This option enables a testcase for the setting rodata read-only. > > > > +config ARCH_HAS_DEBUG_WX > > + bool > > + > > +config DEBUG_WX > > + bool "Warn on W+X mappings at boot" > > + depends on ARCH_HAS_DEBUG_WX > > + select PTDUMP_CORE > > + help > > + Generate a warning if any W+X mappings are found at boot. > > + > > + This is useful for discovering cases where the kernel is leaving > > + W+X mappings after applying NX, as such mappings are a security risk. > > + This check also includes UXN, which should be set on all kernel > > + mappings. > > "UXN" is the name of a bit in the arm64 page-table descriptors, so this > should be reworded now that it's in generic help text. > It's exactly. Sorry for missing the statement. Hi Andrew, Shall I send a next version patch to fix it? It should be "This is useful for discovering cases where the kernel is leaving W+X mappings after applying NX, as such mappings are a security risk." here. > Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 678CEC54FD0 for ; Mon, 27 Apr 2020 08:48:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 344C6206D4 for ; Mon, 27 Apr 2020 08:48:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XKq/QCmd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="aJaVtmhn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 344C6206D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To: Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mlWbhU9/EmkPkE3KgFalNDlgj8IuZTC+N04d/sX94zU=; b=XKq/QCmdxkd43/VG5Pf6eX5uG gQ6eMC8VwHsErQO0F4WWfV4TUlPtHK/xwazC9EVQJ0U75PxbuDNIj9ZwbImO79k0jycsPu/jRcNm8 XjnOSo038EsrPY19yWKzOKYd9IiwMX3rHuIM3yx+6f4SvdWyyKBSVA1Hf/XjLd2/X5nFvJQK1S0qZ XqUzW5oHxZ3x2L6ggghpbPFgxwI0SuKGnK4/woV/mqMk2+FClrkWsN/5EWH8NKTeUndjRAtJUTuS0 H3a1JrVEumkiK/UA7dSL443arbsAJwtFVNMntQfdoHjj+pA5zgcrCpEvuAS7fH742ZUWBhbSfgvTQ 4vViRlJhQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSzR0-0006Br-Mh; Mon, 27 Apr 2020 08:48:14 +0000 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSzQl-0005zW-VZ for linux-riscv@lists.infradead.org; Mon, 27 Apr 2020 08:48:01 +0000 Received: by mail-ot1-x344.google.com with SMTP id c3so24849612otp.8 for ; Mon, 27 Apr 2020 01:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mlWbhU9/EmkPkE3KgFalNDlgj8IuZTC+N04d/sX94zU=; b=aJaVtmhnB60iCS5aU72qYpjSl4GarLyMRo6mE3SWoVddygx/s1bcaKs3gTE7K6UUbO o4RayG4kLMsthZ9NAP40ehfOAxyhj1LEfHG6eB/gKUS0vVj/9mXcBIpIkUzUKNi3NCri hHRRvTjFPtdMy6vHuqYxugy7S7L4Le7YTPCBV3O/K1uZVjb6eeVVAy9m9PSWczUpLWJI OQ0ci1aMz8766LfwSXYkTxDlOXnE+Sp7uR/aCOClWA2dJTGvai4EeTwjlFCYCtpdtzm8 fyrwDqx8JizdfM4qescTEoft91MXwbAOE8Jn49/tyDCfNvjsXpUyPgTfuA80krsiVVb/ 7qew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mlWbhU9/EmkPkE3KgFalNDlgj8IuZTC+N04d/sX94zU=; b=iq2pJSXuUzu3xp10XN88T6txdl0pN91Km4w7X3GrDxRkiJM/WHfbvaUY5HNvf71pO0 U1w9cxo6S8bg4maR4/AyVEYziR6l6G0TEBtRbsvjlPQxhsseFmwPmlXcpz8MNtqBeSaj A5OFa8NTu3Yhug5zTuE63Oncq2a2fxly7JNa/PChTrtOlmEB3AK1lsd6FBFCbXvdDCRw H7ElnvCL5BYZhRtG7yPh+tZxSRX7emwLR3OeeLp/ux+B/4kiJwkYsjY6wZ6rosQn+4ha ONC6FcO3v1fpLR3YzZLNbn4Oh2Y6YA52UiwkNTDDAjz7sbLs2ylcjXi5mHkCfl9gLxRH JeIA== X-Gm-Message-State: AGi0PuY7HSq2ZRLHnsYi3KyFSD7C1ogk/gIgzvdtIw5yyK05zhYKR31P ebzGs1uM8K4API3l0zW7f4S2G9q3EUzCta8286WcPw== X-Google-Smtp-Source: APiQypLF9Liz1Wy9Drrlg62h9adl1IQdvPHEtoI3csNtrhxw2UwXHBiWwoYfsvKYHOmr9NvTZRbKN9FmhAyxIBwBF3g= X-Received: by 2002:aca:c78d:: with SMTP id x135mr351307oif.91.1587977277220; Mon, 27 Apr 2020 01:47:57 -0700 (PDT) MIME-Version: 1.0 References: <23980cd0f0e5d79e24a92169116407c75bcc650d.1587455584.git.zong.li@sifive.com> <20200427074915.GA11787@willie-the-truck> In-Reply-To: <20200427074915.GA11787@willie-the-truck> From: Zong Li Date: Mon, 27 Apr 2020 16:47:47 +0800 Message-ID: Subject: Re: [PATCH 1/4] mm: add DEBUG_WX support To: Will Deacon Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_014800_043758_09E22A48 X-CRM114-Status: GOOD ( 17.55 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tglx@linutronix.de, catalin.marinas@arm.com, x86@kernel.org, "linux-kernel@vger.kernel.org List" , linux-mm@kvack.org, mingo@redhat.com, Palmer Dabbelt , Paul Walmsley , bp@alien8.de, akpm@linux-foundation.org, hpa@zytor.com, linux-riscv , linux-arm-kernel Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Apr 27, 2020 at 3:49 PM Will Deacon wrote: > > On Tue, Apr 21, 2020 at 04:17:12PM +0800, Zong Li wrote: > > Some architectures support DEBUG_WX function, it's verbatim from each > > others. Extract to mm/Kconfig.debug for shared use. > > > > Signed-off-by: Zong Li > > Suggested-by: Palmer Dabbelt > > --- > > mm/Kconfig.debug | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > > index 0271b22e063f..077458ad968d 100644 > > --- a/mm/Kconfig.debug > > +++ b/mm/Kconfig.debug > > @@ -118,6 +118,39 @@ config DEBUG_RODATA_TEST > > ---help--- > > This option enables a testcase for the setting rodata read-only. > > > > +config ARCH_HAS_DEBUG_WX > > + bool > > + > > +config DEBUG_WX > > + bool "Warn on W+X mappings at boot" > > + depends on ARCH_HAS_DEBUG_WX > > + select PTDUMP_CORE > > + help > > + Generate a warning if any W+X mappings are found at boot. > > + > > + This is useful for discovering cases where the kernel is leaving > > + W+X mappings after applying NX, as such mappings are a security risk. > > + This check also includes UXN, which should be set on all kernel > > + mappings. > > "UXN" is the name of a bit in the arm64 page-table descriptors, so this > should be reworded now that it's in generic help text. > It's exactly. Sorry for missing the statement. Hi Andrew, Shall I send a next version patch to fix it? It should be "This is useful for discovering cases where the kernel is leaving W+X mappings after applying NX, as such mappings are a security risk." here. > Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8027FC54FD0 for ; Mon, 27 Apr 2020 08:47:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 42F2A206D4 for ; Mon, 27 Apr 2020 08:47:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="aJaVtmhn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42F2A206D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D50058E0005; Mon, 27 Apr 2020 04:47:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D00E68E0001; Mon, 27 Apr 2020 04:47:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C16A88E0005; Mon, 27 Apr 2020 04:47:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id AA6C88E0001 for ; Mon, 27 Apr 2020 04:47:58 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5A74B824934B for ; Mon, 27 Apr 2020 08:47:58 +0000 (UTC) X-FDA: 76753007436.16.pets24_28759ddaf3204 X-HE-Tag: pets24_28759ddaf3204 X-Filterd-Recvd-Size: 4757 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Apr 2020 08:47:57 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id m13so24838932otf.6 for ; Mon, 27 Apr 2020 01:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mlWbhU9/EmkPkE3KgFalNDlgj8IuZTC+N04d/sX94zU=; b=aJaVtmhnB60iCS5aU72qYpjSl4GarLyMRo6mE3SWoVddygx/s1bcaKs3gTE7K6UUbO o4RayG4kLMsthZ9NAP40ehfOAxyhj1LEfHG6eB/gKUS0vVj/9mXcBIpIkUzUKNi3NCri hHRRvTjFPtdMy6vHuqYxugy7S7L4Le7YTPCBV3O/K1uZVjb6eeVVAy9m9PSWczUpLWJI OQ0ci1aMz8766LfwSXYkTxDlOXnE+Sp7uR/aCOClWA2dJTGvai4EeTwjlFCYCtpdtzm8 fyrwDqx8JizdfM4qescTEoft91MXwbAOE8Jn49/tyDCfNvjsXpUyPgTfuA80krsiVVb/ 7qew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mlWbhU9/EmkPkE3KgFalNDlgj8IuZTC+N04d/sX94zU=; b=NI5NCCU+M90UXKQwPzkmjwPgPuQgYjS3d4ZaRP7Y2D1+e+bkoHrFsnTsiTP+pli9wk ckPCoyCznctQNhHS0FTCX9T1d+dvtlHmWoaqgH+0jKK+JFe2x4bhvIdtGqe1ttpGUOfX MgzRG++lPvUNNwu8TKH2Eg3HxvHDYjZhUXDWbl6md9nvjADisQzbgALnqZNaWpGZeS5q gvKWZrNUku3mU+YfaU7Bj84tNmcZpS5ZimuSUwToL1QjOYeE+z1MpZMEzd4IKEWwvgr+ TgtxceHSyJ/PiFCkqKuXQ4X0cRErDkbXNAusx48ODsru58D2pYogdyeFtCHPFToTjKhF RRGw== X-Gm-Message-State: AGi0PuZFbkCKUWelcUkXM/ANmGEkTKW4e20jksJIi9gqQWuaFNc2QtTl 8MBzWNqjHCSsULH0aPi2bbheeYA1z/LoaVwnl7qo6A== X-Google-Smtp-Source: APiQypLF9Liz1Wy9Drrlg62h9adl1IQdvPHEtoI3csNtrhxw2UwXHBiWwoYfsvKYHOmr9NvTZRbKN9FmhAyxIBwBF3g= X-Received: by 2002:aca:c78d:: with SMTP id x135mr351307oif.91.1587977277220; Mon, 27 Apr 2020 01:47:57 -0700 (PDT) MIME-Version: 1.0 References: <23980cd0f0e5d79e24a92169116407c75bcc650d.1587455584.git.zong.li@sifive.com> <20200427074915.GA11787@willie-the-truck> In-Reply-To: <20200427074915.GA11787@willie-the-truck> From: Zong Li Date: Mon, 27 Apr 2020 16:47:47 +0800 Message-ID: Subject: Re: [PATCH 1/4] mm: add DEBUG_WX support To: Will Deacon Cc: akpm@linux-foundation.org, linux-mm@kvack.org, "linux-kernel@vger.kernel.org List" , Paul Walmsley , Palmer Dabbelt , linux-riscv , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, catalin.marinas@arm.com, linux-arm-kernel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 27, 2020 at 3:49 PM Will Deacon wrote: > > On Tue, Apr 21, 2020 at 04:17:12PM +0800, Zong Li wrote: > > Some architectures support DEBUG_WX function, it's verbatim from each > > others. Extract to mm/Kconfig.debug for shared use. > > > > Signed-off-by: Zong Li > > Suggested-by: Palmer Dabbelt > > --- > > mm/Kconfig.debug | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > > index 0271b22e063f..077458ad968d 100644 > > --- a/mm/Kconfig.debug > > +++ b/mm/Kconfig.debug > > @@ -118,6 +118,39 @@ config DEBUG_RODATA_TEST > > ---help--- > > This option enables a testcase for the setting rodata read-only. > > > > +config ARCH_HAS_DEBUG_WX > > + bool > > + > > +config DEBUG_WX > > + bool "Warn on W+X mappings at boot" > > + depends on ARCH_HAS_DEBUG_WX > > + select PTDUMP_CORE > > + help > > + Generate a warning if any W+X mappings are found at boot. > > + > > + This is useful for discovering cases where the kernel is leaving > > + W+X mappings after applying NX, as such mappings are a security risk. > > + This check also includes UXN, which should be set on all kernel > > + mappings. > > "UXN" is the name of a bit in the arm64 page-table descriptors, so this > should be reworded now that it's in generic help text. > It's exactly. Sorry for missing the statement. Hi Andrew, Shall I send a next version patch to fix it? It should be "This is useful for discovering cases where the kernel is leaving W+X mappings after applying NX, as such mappings are a security risk." here. > Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5389EC55199 for ; Mon, 27 Apr 2020 08:48:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25662206D4 for ; Mon, 27 Apr 2020 08:48:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jiPBzVw0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="aJaVtmhn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25662206D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I4KC2f7wuLD1MxxBTUAXTJaEkfKI7N7ckqEcQcmqtr8=; b=jiPBzVw0g/6NYM H07KmFaSJmij1EBjxi8APYdEeeEi3uhoXhogNPNE22mxqzQP/+ismhaQsa6bDRCwuJ5/qxY46A57d VOXRtyyegfR4ttjtzT5qgqwQB8w6MCd9hkR6uh2VshOlay/IgeGSVWdm8ZvSjRIz9vL64hbUtMEo9 A8SaWMCO1OD3W4s4meL5RBkGlkQnyQq4K1nVk6NvBJBrm82Ruzsf60CZ2v+sC6PuVvpBHFuCT+hrj s+/FgYqrS+emZJuRisaFE3m1hmw1soMzU6AwmAtwk7lp26gzGgzyB9DLRFpgzeM1fckohkJvmgpSk OcfTtaHN5Dja8tib08qg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSzQp-00061d-Og; Mon, 27 Apr 2020 08:48:03 +0000 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSzQl-0005zX-VN for linux-arm-kernel@lists.infradead.org; Mon, 27 Apr 2020 08:48:01 +0000 Received: by mail-ot1-x341.google.com with SMTP id g14so24827926otg.10 for ; Mon, 27 Apr 2020 01:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mlWbhU9/EmkPkE3KgFalNDlgj8IuZTC+N04d/sX94zU=; b=aJaVtmhnB60iCS5aU72qYpjSl4GarLyMRo6mE3SWoVddygx/s1bcaKs3gTE7K6UUbO o4RayG4kLMsthZ9NAP40ehfOAxyhj1LEfHG6eB/gKUS0vVj/9mXcBIpIkUzUKNi3NCri hHRRvTjFPtdMy6vHuqYxugy7S7L4Le7YTPCBV3O/K1uZVjb6eeVVAy9m9PSWczUpLWJI OQ0ci1aMz8766LfwSXYkTxDlOXnE+Sp7uR/aCOClWA2dJTGvai4EeTwjlFCYCtpdtzm8 fyrwDqx8JizdfM4qescTEoft91MXwbAOE8Jn49/tyDCfNvjsXpUyPgTfuA80krsiVVb/ 7qew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mlWbhU9/EmkPkE3KgFalNDlgj8IuZTC+N04d/sX94zU=; b=mMZU07LGv9OZFTNgIbDa77MMQPgwD+knoQM8stCwJv+BrXiwA8qLOJSI4Cs1rceb33 vyub0PBxlAQUhV4jl2JJBQ/EhiEizo5G8+Xa/ClnR4Wn1sayHuHwKz0+9I3jN8juM7Wt HVTOahpOIO3Hcua05KjRE9trZRKtEMadT2EPs4LOLiaZ2TfZui91Aj0VxlOwtrGtRIvy mj3eDDqHyco+ZlLioXX4MkbfAJ7ueF7Fft+CqQqd3v5SI4leNGBw2W09g5SaAqLCcUsc BGAFw8lk+XiHlDBZihommiYa9yYyHQJhdcLPi1PZMXNUmjAuXQr4X7L02N/2KXsJhVEL DZEw== X-Gm-Message-State: AGi0PuajaRhHKwlZbyovSGSaw86GYuwkl9JpXiqppPQlypE2Eog/CqnK fu8r9+aVGjMY2MOXwAn8AGrLnR+mcnBVaomCGrCPLXbeQNs= X-Google-Smtp-Source: APiQypLF9Liz1Wy9Drrlg62h9adl1IQdvPHEtoI3csNtrhxw2UwXHBiWwoYfsvKYHOmr9NvTZRbKN9FmhAyxIBwBF3g= X-Received: by 2002:aca:c78d:: with SMTP id x135mr351307oif.91.1587977277220; Mon, 27 Apr 2020 01:47:57 -0700 (PDT) MIME-Version: 1.0 References: <23980cd0f0e5d79e24a92169116407c75bcc650d.1587455584.git.zong.li@sifive.com> <20200427074915.GA11787@willie-the-truck> In-Reply-To: <20200427074915.GA11787@willie-the-truck> From: Zong Li Date: Mon, 27 Apr 2020 16:47:47 +0800 Message-ID: Subject: Re: [PATCH 1/4] mm: add DEBUG_WX support To: Will Deacon X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_014800_044426_A781E2F2 X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tglx@linutronix.de, catalin.marinas@arm.com, x86@kernel.org, "linux-kernel@vger.kernel.org List" , linux-mm@kvack.org, mingo@redhat.com, Palmer Dabbelt , Paul Walmsley , bp@alien8.de, akpm@linux-foundation.org, hpa@zytor.com, linux-riscv , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 27, 2020 at 3:49 PM Will Deacon wrote: > > On Tue, Apr 21, 2020 at 04:17:12PM +0800, Zong Li wrote: > > Some architectures support DEBUG_WX function, it's verbatim from each > > others. Extract to mm/Kconfig.debug for shared use. > > > > Signed-off-by: Zong Li > > Suggested-by: Palmer Dabbelt > > --- > > mm/Kconfig.debug | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > > index 0271b22e063f..077458ad968d 100644 > > --- a/mm/Kconfig.debug > > +++ b/mm/Kconfig.debug > > @@ -118,6 +118,39 @@ config DEBUG_RODATA_TEST > > ---help--- > > This option enables a testcase for the setting rodata read-only. > > > > +config ARCH_HAS_DEBUG_WX > > + bool > > + > > +config DEBUG_WX > > + bool "Warn on W+X mappings at boot" > > + depends on ARCH_HAS_DEBUG_WX > > + select PTDUMP_CORE > > + help > > + Generate a warning if any W+X mappings are found at boot. > > + > > + This is useful for discovering cases where the kernel is leaving > > + W+X mappings after applying NX, as such mappings are a security risk. > > + This check also includes UXN, which should be set on all kernel > > + mappings. > > "UXN" is the name of a bit in the arm64 page-table descriptors, so this > should be reworded now that it's in generic help text. > It's exactly. Sorry for missing the statement. Hi Andrew, Shall I send a next version patch to fix it? It should be "This is useful for discovering cases where the kernel is leaving W+X mappings after applying NX, as such mappings are a security risk." here. > Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel