From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EA24C10F1B for ; Tue, 27 Dec 2022 07:14:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229719AbiL0HOG (ORCPT ); Tue, 27 Dec 2022 02:14:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbiL0HOD (ORCPT ); Tue, 27 Dec 2022 02:14:03 -0500 Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C596D2AE6 for ; Mon, 26 Dec 2022 23:14:00 -0800 (PST) Received: by mail-vs1-xe30.google.com with SMTP id d185so11982927vsd.0 for ; Mon, 26 Dec 2022 23:14:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+KQfd0qQa24pmN4jbSpJWNWeqDqVNRsi5GfHHVHb10I=; b=JnDgLgH3KEZYTTFz2OogWOc6UzxCg8sWVfEVHFghkWlpxlqZqelxy06X6jxl+1Qu4U 5XbZ9CYTNySXfjx+Auz3LO7ziUDzSgOCEbwfyVWxcBj6aHAVy30eyInCPVqdjrDhDv5D azzjNfXtFa5kF8SmRD+zMOl+khoViUXeCmhNAe9I72Wjdi9Ui5C8X9geF1uK+l4iH7Yk 3fd4ZsS+OZBcYdUAkNiCfqhm0ZUf8J05J/Y34snl9SUh4i+9ws7mgvc5B0ot+dCwyb9z atFV+c2Hn+RKPH8wgEI+ZMKfo6h7s7HJ5APo3ZeAwVy6CrblZf3x2fXCkVo+ZEQH/TBJ Ytuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+KQfd0qQa24pmN4jbSpJWNWeqDqVNRsi5GfHHVHb10I=; b=0W4Vabdz4n4P/au8dTHjRhMwIu5ynuKUc5H6BXxXdTyjqY+1OS9iQEzlUr9LKNRH/w mloAFSdwiIhuq0pJdtdvHBMkz8ucLb3yWjd4taUr3BPWGo6HiZ8WOSmxYCvU1WXwC9Pq l0PUqVLshbrs3Dktg2667ZndNbib9c06D0ULsaKJEzPMGk9PaOKONrMLPIF+nielMSoy tfjotSvj4scTEtXRaf5pxWBOZSR8Jtfm7q7+OSJCEWzbKDFNXCVdwasdqBO0/XASf54z but5jmoCWvd8Pp5pdWSZhzMkZtVHS1ydoWDMbUrieGSR65w9L1fxxcTg88FOJMeKM7w3 lMgQ== X-Gm-Message-State: AFqh2kp2l+ic0AMSsD6UIscTG3Gl8z5U2jzdujtLD84kerQmQRmRbaTl JhUaBhCRcP0gZPBy5t+o1DE+NnMb+oTaXT9JHR5f8A== X-Google-Smtp-Source: AMrXdXveVEzfaCgCX7ll10/TckFbSv+JK5mIYKf8aCht+1Noe74CJXwAERw1BZvxxJVNWvLE//EQJd/v6X6NLOza8Yc= X-Received: by 2002:a05:6102:14a7:b0:3b5:1126:2b62 with SMTP id d39-20020a05610214a700b003b511262b62mr2182450vsv.51.1672125239853; Mon, 26 Dec 2022 23:13:59 -0800 (PST) MIME-Version: 1.0 References: <20221227022528.609839-1-mie@igel.co.jp> <20221227022528.609839-3-mie@igel.co.jp> <20221227020425-mutt-send-email-mst@kernel.org> In-Reply-To: <20221227020425-mutt-send-email-mst@kernel.org> From: Shunsuke Mie Date: Tue, 27 Dec 2022 16:13:49 +0900 Message-ID: Subject: Re: [RFC PATCH 2/9] vringh: remove vringh_iov and unite to vringh_kiov To: "Michael S. Tsirkin" Cc: Jason Wang , Rusty Russell , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2022=E5=B9=B412=E6=9C=8827=E6=97=A5(=E7=81=AB) 16:05 Michael S. Tsirkin : > > On Tue, Dec 27, 2022 at 02:04:03PM +0800, Jason Wang wrote: > > On Tue, Dec 27, 2022 at 10:25 AM Shunsuke Mie wrote: > > > > > > struct vringh_iov is defined to hold userland addresses. However, to = use > > > common function, __vring_iov, finally the vringh_iov converts to the > > > vringh_kiov with simple cast. It includes compile time check code to = make > > > sure it can be cast correctly. > > > > > > To simplify the code, this patch removes the struct vringh_iov and un= ifies > > > APIs to struct vringh_kiov. > > > > > > Signed-off-by: Shunsuke Mie > > > > While at this, I wonder if we need to go further, that is, switch to > > using an iov iterator instead of a vringh customized one. > > > > Thanks > > Possibly, but when doing changes like this one needs to be careful > to avoid breaking all the inlining tricks vringh relies on for > performance. Definitely, I'm evaluating the performance using vringh_test. I'll add a result of the evaluation. But, If there are other evaluation methods, could= you please tell me? > -- > MST > Best, Shunsuke From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F8D5C10F1B for ; Tue, 27 Dec 2022 07:14:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id B64568139B; Tue, 27 Dec 2022 07:14:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B64568139B Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=igel-co-jp.20210112.gappssmtp.com header.i=@igel-co-jp.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=JnDgLgH3 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DRctbz0aREza; Tue, 27 Dec 2022 07:14:04 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4945781385; Tue, 27 Dec 2022 07:14:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4945781385 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1AFE3C0032; Tue, 27 Dec 2022 07:14:03 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id E5AF0C002D for ; Tue, 27 Dec 2022 07:14:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B5D2C403A7 for ; Tue, 27 Dec 2022 07:14:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B5D2C403A7 Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=igel-co-jp.20210112.gappssmtp.com header.i=@igel-co-jp.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=JnDgLgH3 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oFkuLqL6jWIn for ; Tue, 27 Dec 2022 07:14:01 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 1F481400D1 Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by smtp2.osuosl.org (Postfix) with ESMTPS id 1F481400D1 for ; Tue, 27 Dec 2022 07:14:01 +0000 (UTC) Received: by mail-vs1-xe33.google.com with SMTP id h26so11924330vsr.5 for ; Mon, 26 Dec 2022 23:14:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+KQfd0qQa24pmN4jbSpJWNWeqDqVNRsi5GfHHVHb10I=; b=JnDgLgH3KEZYTTFz2OogWOc6UzxCg8sWVfEVHFghkWlpxlqZqelxy06X6jxl+1Qu4U 5XbZ9CYTNySXfjx+Auz3LO7ziUDzSgOCEbwfyVWxcBj6aHAVy30eyInCPVqdjrDhDv5D azzjNfXtFa5kF8SmRD+zMOl+khoViUXeCmhNAe9I72Wjdi9Ui5C8X9geF1uK+l4iH7Yk 3fd4ZsS+OZBcYdUAkNiCfqhm0ZUf8J05J/Y34snl9SUh4i+9ws7mgvc5B0ot+dCwyb9z atFV+c2Hn+RKPH8wgEI+ZMKfo6h7s7HJ5APo3ZeAwVy6CrblZf3x2fXCkVo+ZEQH/TBJ Ytuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+KQfd0qQa24pmN4jbSpJWNWeqDqVNRsi5GfHHVHb10I=; b=7d5z9SbjaLbgCZYV7QtSPLtBdX6TaGuqZavrntiblIJqjP3XePlzOhbr+82ZlHETgk +S9T8gTg3PUyJKAe/ft+fqyEuX1VzhHsW1ewXUvdyD0HSRffX6XyQoIniDSEwR9E82le cikAQLRW6W7FbsybVUkxL3SRR7rVHWosM7O02onBAhx/K7nDGidvyYW6nznKC4lTEqdj QD/tzGT/FdVBQQRapwWP4FhuDNPLWR/Y3o9o0YO4j5QLNJyJodq5JS5h9P2OKuDz2xPa 4bVdk0kHmCdZsJeeLwIcfOdrcItCQz+HIGFLkOzLH7NihDamEkzwxhfRxSDQDskwUli6 bRIg== X-Gm-Message-State: AFqh2krBMPAaPPVZMmLDxxFrxZFVzd+Py0OgVDRwXVwsfhIQ/I8hALvG WMoNINsD1VEIBUi5JBbCLlHQpfHn6mrMhtcCI/kdog== X-Google-Smtp-Source: AMrXdXveVEzfaCgCX7ll10/TckFbSv+JK5mIYKf8aCht+1Noe74CJXwAERw1BZvxxJVNWvLE//EQJd/v6X6NLOza8Yc= X-Received: by 2002:a05:6102:14a7:b0:3b5:1126:2b62 with SMTP id d39-20020a05610214a700b003b511262b62mr2182450vsv.51.1672125239853; Mon, 26 Dec 2022 23:13:59 -0800 (PST) MIME-Version: 1.0 References: <20221227022528.609839-1-mie@igel.co.jp> <20221227022528.609839-3-mie@igel.co.jp> <20221227020425-mutt-send-email-mst@kernel.org> In-Reply-To: <20221227020425-mutt-send-email-mst@kernel.org> From: Shunsuke Mie Date: Tue, 27 Dec 2022 16:13:49 +0900 Message-ID: Subject: Re: [RFC PATCH 2/9] vringh: remove vringh_iov and unite to vringh_kiov To: "Michael S. Tsirkin" Cc: kvm@vger.kernel.org, netdev@vger.kernel.org, Rusty Russell , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" MjAyMuW5tDEy5pyIMjfml6Uo54GrKSAxNjowNSBNaWNoYWVsIFMuIFRzaXJraW4gPG1zdEByZWRo YXQuY29tPjoKPgo+IE9uIFR1ZSwgRGVjIDI3LCAyMDIyIGF0IDAyOjA0OjAzUE0gKzA4MDAsIEph c29uIFdhbmcgd3JvdGU6Cj4gPiBPbiBUdWUsIERlYyAyNywgMjAyMiBhdCAxMDoyNSBBTSBTaHVu c3VrZSBNaWUgPG1pZUBpZ2VsLmNvLmpwPiB3cm90ZToKPiA+ID4KPiA+ID4gc3RydWN0IHZyaW5n aF9pb3YgaXMgZGVmaW5lZCB0byBob2xkIHVzZXJsYW5kIGFkZHJlc3Nlcy4gSG93ZXZlciwgdG8g dXNlCj4gPiA+IGNvbW1vbiBmdW5jdGlvbiwgX192cmluZ19pb3YsIGZpbmFsbHkgdGhlIHZyaW5n aF9pb3YgY29udmVydHMgdG8gdGhlCj4gPiA+IHZyaW5naF9raW92IHdpdGggc2ltcGxlIGNhc3Qu IEl0IGluY2x1ZGVzIGNvbXBpbGUgdGltZSBjaGVjayBjb2RlIHRvIG1ha2UKPiA+ID4gc3VyZSBp dCBjYW4gYmUgY2FzdCBjb3JyZWN0bHkuCj4gPiA+Cj4gPiA+IFRvIHNpbXBsaWZ5IHRoZSBjb2Rl LCB0aGlzIHBhdGNoIHJlbW92ZXMgdGhlIHN0cnVjdCB2cmluZ2hfaW92IGFuZCB1bmlmaWVzCj4g PiA+IEFQSXMgdG8gc3RydWN0IHZyaW5naF9raW92Lgo+ID4gPgo+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBTaHVuc3VrZSBNaWUgPG1pZUBpZ2VsLmNvLmpwPgo+ID4KPiA+IFdoaWxlIGF0IHRoaXMsIEkg d29uZGVyIGlmIHdlIG5lZWQgdG8gZ28gZnVydGhlciwgdGhhdCBpcywgc3dpdGNoIHRvCj4gPiB1 c2luZyBhbiBpb3YgaXRlcmF0b3IgaW5zdGVhZCBvZiBhIHZyaW5naCBjdXN0b21pemVkIG9uZS4K PiA+Cj4gPiBUaGFua3MKPgo+IFBvc3NpYmx5LCBidXQgd2hlbiBkb2luZyBjaGFuZ2VzIGxpa2Ug dGhpcyBvbmUgbmVlZHMgdG8gYmUgY2FyZWZ1bAo+IHRvIGF2b2lkIGJyZWFraW5nIGFsbCB0aGUg aW5saW5pbmcgdHJpY2tzIHZyaW5naCByZWxpZXMgb24gZm9yCj4gcGVyZm9ybWFuY2UuCkRlZmlu aXRlbHksIEknbSBldmFsdWF0aW5nIHRoZSBwZXJmb3JtYW5jZSB1c2luZyB2cmluZ2hfdGVzdC4g SSdsbCBhZGQgYQpyZXN1bHQgb2YgdGhlIGV2YWx1YXRpb24uIEJ1dCwgSWYgdGhlcmUgYXJlIG90 aGVyIGV2YWx1YXRpb24gbWV0aG9kcywgY291bGQgeW91CnBsZWFzZSB0ZWxsIG1lPwo+IC0tCj4g TVNUCj4KCkJlc3QsClNodW5zdWtlCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBs aXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5v cmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==