From: Jiang Xin <worldhello.net@gmail.com>
To: "Jean-Noël AVILA" <jn.avila@free.fr>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Git List" <git@vger.kernel.org>,
"Alexander Shopov" <ash@kambanaria.org>,
"Jordi Mas" <jmas@softcatala.org>,
"Matthias Rüster" <matthias.ruester@gmail.com>,
"Jimmy Angelakos" <vyruss@hellug.gr>,
"Christopher Díaz" <christopher.diaz.riv@gmail.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Alessandro Menti" <alessandro.menti@alessandromenti.it>,
"Gwan-gyeong Mun" <elongbug@gmail.com>, Arusekk <arek_koz@o2.pl>,
"Daniel Santos" <hello@brighterdan.com>,
"Dimitriy Ryazantcev" <DJm00n@mail.ru>,
"Peter Krefting" <peter@softwolves.pp.se>,
"Emir SARI" <bitigchi@me.com>,
"Trần Ngọc Quân" <vnwildman@gmail.com>,
"Fangyi Zhou" <me@fangyi.io>, "Yi-Jyun Pan" <pan93412@gmail.com>,
"Jiang Xin" <zhiyou.jx@alibaba-inc.com>
Subject: Re: [PATCH 1/1] ci: new github-action for git-l10n code review
Date: Tue, 31 Aug 2021 09:03:28 +0800 [thread overview]
Message-ID: <CANYiYbGwOqm=BLVd-7zFD+5W0_jGaz2yCN0HoQHYnr7wLQSd+Q@mail.gmail.com> (raw)
In-Reply-To: <3020682.V8qLCztWNM@cayenne>
On Tue, Aug 31, 2021 at 4:49 AM Jean-Noël AVILA <jn.avila@free.fr> wrote:
>
> Le mardi 24 août 2021, 11:27:44 CEST Johannes Schindelin a écrit :
> >
> > The biggest problem is that there are forks of `git-l10n/git-po` that
> > accept PRs in their own right. That is what I tried to address by using
> > just the repository name, without the org/user prefix.
> >
> > Ciao,
> > Dscho
> >
>
> Well, I'm in this case, plus my repo is a fork of git/git.
>
> Would it not possible to formally require the presence of a "dumb" secret to run this rule?
>
It is not supported to use secrets/env in if condition. See this post:
https://github.community/t/jobs-job-id-if-does-not-work-with-env-secrets/16928
In patch v3, will check both repo name and branch names. See:
https://lore.kernel.org/git/20210827071320.14183-1-worldhello.net@gmail.com/
--
Jiang Xin
next prev parent reply other threads:[~2021-08-31 1:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 16:13 [PATCH 0/1] ci: new github-action for git-l10n code review Jiang Xin
2021-08-22 16:13 ` [PATCH 1/1] " Jiang Xin
2021-08-23 6:28 ` Bagas Sanjaya
2021-08-23 6:42 ` Jiang Xin
2021-08-23 21:02 ` Johannes Schindelin
2021-08-23 21:36 ` Junio C Hamano
2021-08-24 9:27 ` Johannes Schindelin
2021-08-24 19:04 ` Junio C Hamano
2021-08-24 21:34 ` Jean-Noël AVILA
2021-08-31 1:03 ` Jiang Xin [this message]
2021-08-24 13:36 ` Jiang Xin
2021-08-24 19:06 ` Junio C Hamano
2021-08-24 13:21 ` Jiang Xin
2021-08-25 12:14 ` Johannes Schindelin
2021-08-26 2:25 ` Jiang Xin
2021-08-27 2:10 ` Jeff King
2021-08-27 2:49 ` Jiang Xin
2021-08-27 7:13 ` [PATCH v3] " Jiang Xin
2021-09-02 2:31 ` [PATCH v4 0/1] " Jiang Xin
2021-09-09 9:09 ` [PATCH v5 " Jiang Xin
2021-09-09 9:09 ` [PATCH v5 1/1] " Jiang Xin
2021-09-02 2:31 ` [PATCH v4 " Jiang Xin
2021-08-23 14:28 ` [PATCH v2 0/1] " Jiang Xin
2021-08-23 14:28 ` [PATCH v2 1/1] " Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANYiYbGwOqm=BLVd-7zFD+5W0_jGaz2yCN0HoQHYnr7wLQSd+Q@mail.gmail.com' \
--to=worldhello.net@gmail.com \
--cc=DJm00n@mail.ru \
--cc=Johannes.Schindelin@gmx.de \
--cc=alessandro.menti@alessandromenti.it \
--cc=arek_koz@o2.pl \
--cc=ash@kambanaria.org \
--cc=bagasdotme@gmail.com \
--cc=bitigchi@me.com \
--cc=christopher.diaz.riv@gmail.com \
--cc=elongbug@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hello@brighterdan.com \
--cc=jmas@softcatala.org \
--cc=jn.avila@free.fr \
--cc=matthias.ruester@gmail.com \
--cc=me@fangyi.io \
--cc=pan93412@gmail.com \
--cc=peter@softwolves.pp.se \
--cc=vnwildman@gmail.com \
--cc=vyruss@hellug.gr \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.