From: Christopher Li <sparse@chrisli.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH] Avoid reuse of string buffer when concatening adjacent string litterals
Date: Tue, 3 Feb 2015 19:26:05 -0800 [thread overview]
Message-ID: <CANeU7Q=op73uMi-q-+fpZ1b+apf_FGbeCBFNcBADMOdfgOYoMQ@mail.gmail.com> (raw)
In-Reply-To: <20150204003208.GA8867@macbook.lan>
On Tue, Feb 3, 2015 at 4:32 PM, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
> Now thinking about it, it's obvious that the string buffer can't be reused at all
> if there is any kind of expansion done on it, the adjacent strings concatenation
> make just the thing worse but are not the cause of it.
>
Right. That is what I think after reading your patch too.
String concatenation is a not a good indicator on macro expand.
There should be a fix base on the macro expand.
Even though I haven't construct an test case like Rasmus did.
Chris
next prev parent reply other threads:[~2015-02-04 3:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 22:16 Bad interaction between macro expansion and literal concatenation Rasmus Villemoes
2015-01-31 1:23 ` [PATCH] Avoid reuse of string buffer when concatening adjacent string litterals Luc Van Oostenryck
2015-02-03 22:38 ` Rasmus Villemoes
2015-02-04 0:32 ` Luc Van Oostenryck
2015-02-04 3:26 ` Christopher Li [this message]
2015-02-04 8:39 ` Rasmus Villemoes
2015-02-04 8:58 ` Rasmus Villemoes
2015-02-04 16:20 ` Christopher Li
2015-02-06 21:52 ` Rasmus Villemoes
2015-02-07 1:30 ` Christopher Li
2015-02-09 21:48 ` Damien Lespiau
2015-02-04 2:01 ` [PATCH v2] Avoid reusing string buffer when doing string expansion Luc Van Oostenryck
2015-02-04 5:30 ` Christopher Li
2015-02-04 6:22 ` Luc Van Oostenryck
2015-02-04 8:01 ` Christopher Li
2015-02-04 16:38 ` Christopher Li
2015-02-04 23:38 ` Luc Van Oostenryck
2015-02-06 13:58 ` Christopher Li
2015-02-06 20:32 ` Rasmus Villemoes
2015-02-04 23:38 ` Luc Van Oostenryck
2015-01-31 5:16 ` Bad interaction between macro expansion and literal concatenation Christopher Li
2015-02-01 2:19 ` [PATCH 0/4] Teach sparse to display data/initial values Luc Van Oostenryck
2015-02-01 2:19 ` [PATCH 1/4] Add support for '-vdata', the equivalent of '-ventry' but for data Luc Van Oostenryck
2015-02-01 2:19 ` [PATCH 2/4] Add support for show_data() Luc Van Oostenryck
2015-02-02 5:30 ` Christopher Li
2015-02-04 0:50 ` Luc Van Oostenryck
2015-02-01 2:19 ` [PATCH 3/4] Teach sparse to display data/initial values Luc Van Oostenryck
2015-02-01 2:19 ` [PATCH 4/4] Small test/exemple for using '-vdata' Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANeU7Q=op73uMi-q-+fpZ1b+apf_FGbeCBFNcBADMOdfgOYoMQ@mail.gmail.com' \
--to=sparse@chrisli.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.