From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Li Subject: Re: [PATCH v2] Avoid reusing string buffer when doing string expansion Date: Fri, 6 Feb 2015 05:58:15 -0800 Message-ID: References: <87y4ojhq2f.fsf@rasmusvillemoes.dk> <20150131012339.GA3460@macpro.local> <87386mvcxh.fsf@rasmusvillemoes.dk> <20150204020059.GA7069@macpro.local> <20150204062250.GA9989@macbook.lan> <20150204233853.GB2275@macpro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-qg0-f50.google.com ([209.85.192.50]:64053 "EHLO mail-qg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753240AbbBFN6Q (ORCPT ); Fri, 6 Feb 2015 08:58:16 -0500 Received: by mail-qg0-f50.google.com with SMTP id j5so11243477qga.9 for ; Fri, 06 Feb 2015 05:58:16 -0800 (PST) In-Reply-To: <20150204233853.GB2275@macpro.local> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Luc Van Oostenryck Cc: Rasmus Villemoes , Linux-Sparse On Wed, Feb 4, 2015 at 3:38 PM, Luc Van Oostenryck wrote: > > Working perfectly here. > Any update of the string test case? I commit a review version of the immutable string fix in review-immutable-string branch. Compare to the last patch, it take into account that string can come from macro arguments rather than macro body. It also avoid the string copy if there is no change, that is pretty common as well. Care to give this version a try? https://git.kernel.org/cgit/devel/sparse/chrisl/sparse.git/commit/?h=review-immutable-string&id=de1fa7e60d3d179a1b67c47a0429b2d0ac4e4842 Chris