All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Li <sparse@chrisli.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Josh Triplett" <josh@joshtriplett.org>,
	"Jeff Layton" <jlayton@redhat.com>
Subject: Re: [PATCH v3 00/37] Makefile reorganization
Date: Fri, 10 Nov 2017 03:11:10 +0800	[thread overview]
Message-ID: <CANeU7QkBakvfoWn1RdZz-D3evS3=UEdjgqE8mfuddxFup_hf+w@mail.gmail.com> (raw)
In-Reply-To: <20171109064648.15379-1-luc.vanoostenryck@gmail.com>

On Thu, Nov 9, 2017 at 2:46 PM, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
> The goal of this series is to reorganize sparse's Makefile
> in order to offer a few features asked by the distros:
> 1) allow CFLAGS & CPPFLAGS to be taken from the command line

That can be done in one patch.

> 2) allow PREFIX to be taken from the environment

Not straightly necessary. You can invoke "make PREFIX=$PREFIX".

I will have to hold of the review of this series as well
as I feel most of the review is not straightly necessary.

Some of the stuff get removed, I am actually still using.

Another thing is that, there is an earlier debug version of sparse
makefile change under discussion. I have express that I want to
hold off big Makefile changes until the debug version series
reach to some conclusion.

In general I don't like big rewrite and rename for the
sake of rewrite.

Chris

  parent reply	other threads:[~2017-11-09 19:11 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09  6:46 [PATCH v3 00/37] Makefile reorganization Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 01/37] build: make PREFIX overwritable from the environment Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 02/37] build: put comment about local.mk to the place where it is included Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 03/37] build: drop BASIC_CFLAGS and ALL_CFLAGS Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 04/37] build: drop -g from LDFLAGS Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 05/37] build: pass CPPFLAGS to compiler Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 06/37] build: fix effectiveness of generated dependencies Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 07/37] build: remove unused support for pkgconfig Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 08/37] build: use '_OBJS' instead of '_EXTRA_DEPS' Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 09/37] build: use '_LDLIBS' instead of '_EXTRA_OBJS' Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 10/37] build: allow target-specific CFLAGS, CPPFLAGS, LDFLAGS & LDLIBS Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 11/37] build: allow CFLAGS & friends from command line Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 12/37] build: avoid rule-specific CFLAGS Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 13/37] build: use $LIBS directly in the dependency list Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 14/37] build: no need to use wildcards for generated dependencies Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 15/37] build: reuse rule for ALL_OBJS Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 16/37] build: CHECKER_FLAGS=-Wno-vla for all targets Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 17/37] build: move tests near their use Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 18/37] build: only generate version.h when needed Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 19/37] build: add note about overwritable vars Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 20/37] build: remove references to unexisting pre-process.h Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 21/37] build: move clean & clean-check together Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 22/37] build: make clean targets quieter Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 23/37] build: remove rule for shared lib, it's unused Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 24/37] build: normalize rules Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 25/37] build: remove the dist rule since unused Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 26/37] build: use one line per item Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 27/37] build: use a dot file name instead of local.mk: .sparse.mk Luc Van Oostenryck
2017-11-09 14:56   ` Ramsay Jones
2017-11-09 15:18     ` Luc Van Oostenryck
2017-11-09 15:28       ` Ramsay Jones
2017-11-09  6:46 ` [PATCH v3 28/37] build: use standard rules for install Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 29/37] build: remove unused QUIET_INST_SH Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 30/37] build: let quiet commands use less indentation Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 31/37] build: simplify quiet commands Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 32/37] build: simplify clean pattern Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 33/37] build: add *.o to clean-check pattern Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 34/37] build: avoid foreach Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 35/37] build: reorg & add comment Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 36/37] build: use a single space before assignments Luc Van Oostenryck
2017-11-09  6:46 ` [PATCH v3 37/37] build: add rule to run a single test Luc Van Oostenryck
2017-11-09 19:11 ` Christopher Li [this message]
2017-11-09 20:54   ` [PATCH v3 00/37] Makefile reorganization Luc Van Oostenryck
2017-11-09 21:03     ` Christopher Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANeU7QkBakvfoWn1RdZz-D3evS3=UEdjgqE8mfuddxFup_hf+w@mail.gmail.com' \
    --to=sparse@chrisli.org \
    --cc=jlayton@redhat.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.