All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Li <sparse@chrisli.org>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Cody P Schafer <cody@linux.vnet.ibm.com>,
	Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH] build: allow use of LLVM_CONFIG to override llvm-config config script
Date: Tue, 15 Apr 2014 15:05:21 -0700	[thread overview]
Message-ID: <CANeU7QmOQwveOeTRP9rrcXaCJYv3DMBGAW_yp1uGG0Juvm0agw@mail.gmail.com> (raw)
In-Reply-To: <20140415180045.GA2707@leaf>

On Tue, Apr 15, 2014 at 11:00 AM, Josh Triplett <josh@joshtriplett.org> wrote:
> On Tue, Apr 15, 2014 at 10:22:49AM -0700, Cody P Schafer wrote:
>> On systems like ubuntu 12.04, llvm-config is llvm 2.9, but
>> llvm-config-3.0 and llvm-config-3.3 (for example) are versions 3.0 and
>> 3.3 respectively. Allow overriding the name/path of the llvm-config
>> script so people can use these versioned config scripts
>>
>> Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

Applied with trivial modification to use simple
expanded variable.

Chris

diff --git a/Makefile b/Makefile
index bbdc088..f453ded 100644
--- a/Makefile
+++ b/Makefile
@@ -30,10 +30,10 @@ HAVE_GCC_DEP:=$(shell touch .gcc-test.c &&
                $(CC) -c -Wp,-MD,.gcc-test.d .gcc-test.c 2>/dev/null && \
                echo 'yes'; rm -f .gcc-test.d .gcc-test.o .gcc-test.c)
 HAVE_GTK2:=$(shell pkg-config --exists gtk+-2.0 2>/dev/null && echo 'yes')
-LLVM_CONFIG=llvm-config
+LLVM_CONFIG:=llvm-config
 HAVE_LLVM:=$(shell $(LLVM_CONFIG) --version >/dev/null 2>&1 && echo 'yes')
 HAVE_LLVM_VERSION:=$(shell $(LLVM_CONFIG) --version | grep "^[3-9].*" >/dev/nul
-LLVM_VERSION=$(shell $(LLVM_CONFIG) --version)
+LLVM_VERSION:=$(shell $(LLVM_CONFIG) --version)

 GCC_BASE = $(shell $(CC) --print-file-name=)
 BASIC_CFLAGS = -DGCC_BASE=\"$(GCC_BASE)\"

      reply	other threads:[~2014-04-15 22:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 17:22 [PATCH] build: allow use of LLVM_CONFIG to override llvm-config config script Cody P Schafer
2014-04-15 18:00 ` Josh Triplett
2014-04-15 22:05   ` Christopher Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANeU7QmOQwveOeTRP9rrcXaCJYv3DMBGAW_yp1uGG0Juvm0agw@mail.gmail.com \
    --to=sparse@chrisli.org \
    --cc=cody@linux.vnet.ibm.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-sparse@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.